All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] rcar-du: add/rename DEFR6 TCON bits
Date: Tue, 26 Apr 2016 00:11:15 +0300	[thread overview]
Message-ID: <3463066.Db4xpr3SQR@avalon> (raw)
In-Reply-To: <2036550.BKBaf2zquB@wasted.cogentembedded.com>

Hi Sergei,

Thank you for the patch.

On Saturday 23 Apr 2016 01:56:07 Sergei Shtylyov wrote:
> The  TCNE2 bit  of the DEFR6 register was renamed to TCNE1 in the R-Car gen2
> manuals -- which makes more  sense as that bit controls whether DU1, not
> DU2 is connected to TCON.
> 
> While at it, add the TCNE0 bit which controls whether DU0 is connected to
> TCON.
> 
> Based on the large patch by Andrey Gusakov
> <andrey.gusakov@cogentembedded.com>.
> 
> Signed-off-by: Andrey Gusakov <andrey.gusakov@cogentembedded.com>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

and applied to my tree.

> ---
> The patch is against David Airlie's 'linux.git' repo's 'drm-next' branch.
> 
>  drivers/gpu/drm/rcar-du/rcar_du_regs.h |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> Index: linux/drivers/gpu/drm/rcar-du/rcar_du_regs.h
> ===================================================================
> --- linux.orig/drivers/gpu/drm/rcar-du/rcar_du_regs.h
> +++ linux/drivers/gpu/drm/rcar-du/rcar_du_regs.h
> @@ -195,9 +195,10 @@
>  #define DEFR6_ODPM12_DISP	(2 << 8)
>  #define DEFR6_ODPM12_CDE	(3 << 8)
>  #define DEFR6_ODPM12_MASK	(3 << 8)
> -#define DEFR6_TCNE2		(1 << 6)
> +#define DEFR6_TCNE1		(1 << 6)
> +#define DEFR6_TCNE0		(1 << 4)
>  #define DEFR6_MLOS1		(1 << 2)
> -#define DEFR6_DEFAULT		(DEFR6_CODE | DEFR6_TCNE2)
> +#define DEFR6_DEFAULT		(DEFR6_CODE | DEFR6_TCNE1)
> 
>  /* ------------------------------------------------------------------------
>   * R8A7790-only Control Registers

-- 
Regards,

Laurent Pinchart

WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] rcar-du: add/rename DEFR6 TCON bits
Date: Tue, 26 Apr 2016 00:11:15 +0300	[thread overview]
Message-ID: <3463066.Db4xpr3SQR@avalon> (raw)
In-Reply-To: <2036550.BKBaf2zquB@wasted.cogentembedded.com>

Hi Sergei,

Thank you for the patch.

On Saturday 23 Apr 2016 01:56:07 Sergei Shtylyov wrote:
> The  TCNE2 bit  of the DEFR6 register was renamed to TCNE1 in the R-Car gen2
> manuals -- which makes more  sense as that bit controls whether DU1, not
> DU2 is connected to TCON.
> 
> While at it, add the TCNE0 bit which controls whether DU0 is connected to
> TCON.
> 
> Based on the large patch by Andrey Gusakov
> <andrey.gusakov@cogentembedded.com>.
> 
> Signed-off-by: Andrey Gusakov <andrey.gusakov@cogentembedded.com>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

and applied to my tree.

> ---
> The patch is against David Airlie's 'linux.git' repo's 'drm-next' branch.
> 
>  drivers/gpu/drm/rcar-du/rcar_du_regs.h |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> Index: linux/drivers/gpu/drm/rcar-du/rcar_du_regs.h
> ===================================================================
> --- linux.orig/drivers/gpu/drm/rcar-du/rcar_du_regs.h
> +++ linux/drivers/gpu/drm/rcar-du/rcar_du_regs.h
> @@ -195,9 +195,10 @@
>  #define DEFR6_ODPM12_DISP	(2 << 8)
>  #define DEFR6_ODPM12_CDE	(3 << 8)
>  #define DEFR6_ODPM12_MASK	(3 << 8)
> -#define DEFR6_TCNE2		(1 << 6)
> +#define DEFR6_TCNE1		(1 << 6)
> +#define DEFR6_TCNE0		(1 << 4)
>  #define DEFR6_MLOS1		(1 << 2)
> -#define DEFR6_DEFAULT		(DEFR6_CODE | DEFR6_TCNE2)
> +#define DEFR6_DEFAULT		(DEFR6_CODE | DEFR6_TCNE1)
> 
>  /* ------------------------------------------------------------------------
>   * R8A7790-only Control Registers

-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2016-04-25 21:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-22 22:56 [PATCH] rcar-du: add/rename DEFR6 TCON bits Sergei Shtylyov
2016-04-25  7:25 ` Geert Uytterhoeven
2016-04-25 11:34   ` Sergei Shtylyov
2016-04-25 21:07   ` Laurent Pinchart
2016-04-25 21:07     ` Laurent Pinchart
2016-04-25 21:11 ` Laurent Pinchart [this message]
2016-04-25 21:11   ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3463066.Db4xpr3SQR@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.