[KJ][PATCH] linux-2.6.15-rc2 apm_emu.c audit misc_register() ret. code

[KJ][PATCH] linux-2.6.15-rc2 apm_emu.c audit misc_register() ret. code

[Paolo Teti]

from: Paolo Teti

fix a missing check on misc_register() return code

Signed-off-by: Paolo Teti <paolo.teti@gmail.com>

---
--- linux-2.6.15-rc2/drivers/macintosh/apm_emu.c.orig	Tue Nov 22 17:37:06 2005
+++ linux-2.6.15-rc2/drivers/macintosh/apm_emu.c	Tue Nov 22 18:03:31 2005
@@ -530,7 +530,11 @@ static int __init apm_emu_init(void)
 	if (apm_proc)
 		apm_proc->owner = THIS_MODULE;

-	misc_register(&apm_device);
+	if (misc_register(&apm_device) != 0) {
+		remove_proc_entry("apm", NULL);
+		printk(KERN_ERR "apm_emu: Failed to register APM Emulation.\n");
+		return -ENODEV;
+	}

 	pmu_register_sleep_notifier(&apm_sleep_notifier);

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ][PATCH] linux-2.6.15-rc2 apm_emu.c audit misc_register() ret.

[Christophe Lucas]

[-- Attachment #1: Type: text/plain, Size: 889 bytes --]

Paolo Teti (paolo.teti@gmail.com) wrote:
> from: Paolo Teti
> 
> fix a missing check on misc_register() return code
> 
> Signed-off-by: Paolo Teti <paolo.teti@gmail.com>
> 
> ---
> --- linux-2.6.15-rc2/drivers/macintosh/apm_emu.c.orig	Tue Nov 22 17:37:06 2005
> +++ linux-2.6.15-rc2/drivers/macintosh/apm_emu.c	Tue Nov 22 18:03:31 2005
> @@ -530,7 +530,11 @@ static int __init apm_emu_init(void)
>  	if (apm_proc)
>  		apm_proc->owner = THIS_MODULE;
> 
> -	misc_register(&apm_device);
> +	if (misc_register(&apm_device) != 0) {
> +		remove_proc_entry("apm", NULL);
> +		printk(KERN_ERR "apm_emu: Failed to register APM Emulation.\n");
> +		return -ENODEV;
> +	}
> 
>  	pmu_register_sleep_notifier(&apm_sleep_notifier);
 

Good retry :)

Already done here :

	http://lists.osdl.org/pipermail/kernel-janitors/2005-June/004243.html

Have a nice day,

				- Christophe (clucas@rotomalug.org)


[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ][PATCH] linux-2.6.15-rc2 apm_emu.c audit misc_register() ret.

[Paolo Teti]

2005/11/24, Christophe Lucas <clucas@rotomalug.org>:
> Good retry :)
>
> Already done here :
>
>         http://lists.osdl.org/pipermail/kernel-janitors/2005-June/004243.html
>
> Have a nice day,
>

Oops!
Yes it's true!... some _minor_ difference but the patch it's the same.

Pao

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ][PATCH] linux-2.6.15-rc2 apm_emu.c audit misc_register() ret.

[Alexey Dobriyan]

[-- Attachment #1: Type: text/plain, Size: 922 bytes --]

On Thu, Nov 24, 2005 at 08:32:01AM +0100, Christophe Lucas wrote:
> Paolo Teti (paolo.teti@gmail.com) wrote:
> > --- linux-2.6.15-rc2/drivers/macintosh/apm_emu.c.orig
> > +++ linux-2.6.15-rc2/drivers/macintosh/apm_emu.c
> > @@ -530,7 +530,11 @@ static int __init apm_emu_init(void)
> >  	if (apm_proc)
> >  		apm_proc->owner = THIS_MODULE;
> >
> > -	misc_register(&apm_device);
> > +	if (misc_register(&apm_device) != 0) {
> > +		remove_proc_entry("apm", NULL);
> > +		printk(KERN_ERR "apm_emu: Failed to register APM Emulation.\n");
> > +		return -ENODEV;
> > +	}

applied, thanks.

> >  	pmu_register_sleep_notifier(&apm_sleep_notifier);
>
>
> Good retry :)
>
> Already done here :
>
> 	http://lists.osdl.org/pipermail/kernel-janitors/2005-June/004243.html

[You sort your patch collection. Nothing happens.]

Speaking of your patch, it shouldn't use KERN_WARNING and should (minor
nitpick) test for "< 0", not "!= 0".


[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ][PATCH] linux-2.6.15-rc2 apm_emu.c audit misc_register() ret.

[Paolo Teti]

> Speaking of your patch, it shouldn't use KERN_WARNING and should (minor
> nitpick) test for "< 0", not "!= 0".
>
>

Why?
Looking at misc_register function the rule is

"A zero is returned on success and a negative errno code for failure."

So test for !=0 is also correct!!

Sorry probably because I have used Ccr instead of Cc I have also sent this patch
to Benjamin Herrenschmidt ( the ppc APM manteiner) and now this patch
is on the -mm
tree as show below!

Sorry!!

----
The patch titled

    apm_emu.c: fix a missing check on misc_register() return code

has been added to the -mm tree.  Its filename is

    apm_emuc-fix-a-missing-check-on-misc_register-return-code.patch


From: Paolo Teti <paolo.teti@gmail.com>

fix a missing check on misc_register() return code

Signed-off-by: Paolo Teti <tetipaol@libero.it>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>


Acked by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ][PATCH] linux-2.6.15-rc2 apm_emu.c audit misc_register() ret.

[Christophe Lucas]

[-- Attachment #1: Type: text/plain, Size: 779 bytes --]

Paolo Teti (paolo.teti@gmail.com) wrote:
> > Speaking of your patch, it shouldn't use KERN_WARNING and should (minor
> > nitpick) test for "< 0", not "!= 0".
> >
> >
> 
> Why?
> Looking at misc_register function the rule is
> 
> "A zero is returned on success and a negative errno code for failure."
> 
> So test for !=0 is also correct!!
> 
> Sorry probably because I have used Ccr instead of Cc I have also sent this patch
> to Benjamin Herrenschmidt ( the ppc APM manteiner) and now this patch
> is on the -mm
> tree as show below!
> 
> Sorry!!
 
You don't have to be sorry. It is about my patch Alexey say that.

I understand your reply Alexey. I would have prefered to know that in
July 2005 not in November 2005.

Have a nice day,

				- Christophe (clucas@rotomalug.org)


[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ][PATCH] linux-2.6.15-rc2 apm_emu.c audit misc_register() ret.

[Paolo Teti]

> > Sorry!!
>
> You don't have to be sorry. It is about my patch Alexey say that.
>
> I understand your reply Alexey. I would have prefered to know that in
> July 2005 not in November 2005.
>

Ok. Christophe

but I have asked "sorry" because I have sent also to Benjamin the patch
(probably I have used Ccr instead of Cc) and know the patch is in the -mm tree
checked by Benjamin

Hi, Pao

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

[KJ] [PATCH] linux-2.6.15-rc2 apm_emu.c audit misc_register() ret.

[Paolo Teti]

from: Paolo Teti

fix a missing check on misc_register() return code

Signed-off-by: Paolo Teti <tetipaol@libero.it>

---
--- linux-2.6.15-rc2/drivers/macintosh/apm_emu.c.orig	Tue Nov 22 17:37:06 2005
+++ linux-2.6.15-rc2/drivers/macintosh/apm_emu.c	Tue Nov 22 18:03:31 2005
@@ -530,7 +530,11 @@ static int __init apm_emu_init(void)
 	if (apm_proc)
 		apm_proc->owner = THIS_MODULE;
 
-	misc_register(&apm_device);
+	if (misc_register(&apm_device) != 0) {
+		remove_proc_entry("apm", NULL);
+		printk(KERN_ERR "apm_emu: Failed to register APM Emulation.\n");
+		return -ENODEV;
+	}
 
 	pmu_register_sleep_notifier(&apm_sleep_notifier);
 



_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors