From: SF Markus Elfring <elfring@users.sourceforge.net>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 05/10] dlm: Improve a size determination in dlm_recover_waiters_pre()
Date: Sat, 6 May 2017 10:41:59 +0200 [thread overview]
Message-ID: <34dae3fb-31e8-d8a9-7beb-77b40dc94388@users.sourceforge.net> (raw)
In-Reply-To: <4bd895d7-9448-928d-1e4c-42326ce20607@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 6 May 2017 08:48:29 +0200
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
fs/dlm/lock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c
index fd6fe55bedae..ffadb817ad39 100644
--- a/fs/dlm/lock.c
+++ b/fs/dlm/lock.c
@@ -5119,7 +5119,7 @@ void dlm_recover_waiters_pre(struct dlm_ls *ls)
int wait_type, stub_unlock_result, stub_cancel_result;
int dir_nodeid;
- ms_stub = kmalloc(sizeof(struct dlm_message), GFP_KERNEL);
+ ms_stub = kmalloc(sizeof(*ms_stub), GFP_KERNEL);
if (!ms_stub) {
log_error(ls, "dlm_recover_waiters_pre no mem");
return;
--
2.12.2
WARNING: multiple messages have this Message-ID (diff)
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: cluster-devel@redhat.com,
Christine Caulfield <ccaulfie@redhat.com>,
David Teigland <teigland@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 05/10] dlm: Improve a size determination in dlm_recover_waiters_pre()
Date: Sat, 06 May 2017 08:41:59 +0000 [thread overview]
Message-ID: <34dae3fb-31e8-d8a9-7beb-77b40dc94388@users.sourceforge.net> (raw)
In-Reply-To: <4bd895d7-9448-928d-1e4c-42326ce20607@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 6 May 2017 08:48:29 +0200
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
fs/dlm/lock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c
index fd6fe55bedae..ffadb817ad39 100644
--- a/fs/dlm/lock.c
+++ b/fs/dlm/lock.c
@@ -5119,7 +5119,7 @@ void dlm_recover_waiters_pre(struct dlm_ls *ls)
int wait_type, stub_unlock_result, stub_cancel_result;
int dir_nodeid;
- ms_stub = kmalloc(sizeof(struct dlm_message), GFP_KERNEL);
+ ms_stub = kmalloc(sizeof(*ms_stub), GFP_KERNEL);
if (!ms_stub) {
log_error(ls, "dlm_recover_waiters_pre no mem");
return;
--
2.12.2
WARNING: multiple messages have this Message-ID (diff)
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: cluster-devel@redhat.com,
Christine Caulfield <ccaulfie@redhat.com>,
David Teigland <teigland@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 05/10] dlm: Improve a size determination in dlm_recover_waiters_pre()
Date: Sat, 6 May 2017 10:41:59 +0200 [thread overview]
Message-ID: <34dae3fb-31e8-d8a9-7beb-77b40dc94388@users.sourceforge.net> (raw)
In-Reply-To: <4bd895d7-9448-928d-1e4c-42326ce20607@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 6 May 2017 08:48:29 +0200
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
fs/dlm/lock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c
index fd6fe55bedae..ffadb817ad39 100644
--- a/fs/dlm/lock.c
+++ b/fs/dlm/lock.c
@@ -5119,7 +5119,7 @@ void dlm_recover_waiters_pre(struct dlm_ls *ls)
int wait_type, stub_unlock_result, stub_cancel_result;
int dir_nodeid;
- ms_stub = kmalloc(sizeof(struct dlm_message), GFP_KERNEL);
+ ms_stub = kmalloc(sizeof(*ms_stub), GFP_KERNEL);
if (!ms_stub) {
log_error(ls, "dlm_recover_waiters_pre no mem");
return;
--
2.12.2
next prev parent reply other threads:[~2017-05-06 8:41 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-06 8:34 [Cluster-devel] [PATCH 00/10] fs-DLM: Fine-tuning for several function implementations SF Markus Elfring
2017-05-06 8:34 ` SF Markus Elfring
2017-05-06 8:34 ` SF Markus Elfring
2017-05-06 8:36 ` [Cluster-devel] [PATCH 01/10] dlm: Replace six seq_puts() calls by seq_putc() SF Markus Elfring
2017-05-06 8:36 ` SF Markus Elfring
2017-05-06 8:36 ` SF Markus Elfring
2017-05-06 8:38 ` [Cluster-devel] [PATCH 02/10] dlm: Add spaces for better code readability SF Markus Elfring
2017-05-06 8:38 ` SF Markus Elfring
2017-05-06 8:38 ` SF Markus Elfring
2017-05-06 8:39 ` [Cluster-devel] [PATCH 03/10] dlm: Improve a size determination in table_seq_start() SF Markus Elfring
2017-05-06 8:39 ` SF Markus Elfring
2017-05-06 8:39 ` SF Markus Elfring
2017-05-06 8:40 ` [Cluster-devel] [PATCH 04/10] dlm: Use kcalloc() in dlm_scan_waiters() SF Markus Elfring
2017-05-06 8:40 ` SF Markus Elfring
2017-05-06 8:40 ` SF Markus Elfring
2017-05-06 8:41 ` SF Markus Elfring [this message]
2017-05-06 8:41 ` [PATCH 05/10] dlm: Improve a size determination in dlm_recover_waiters_pre() SF Markus Elfring
2017-05-06 8:41 ` SF Markus Elfring
2017-05-06 8:43 ` [Cluster-devel] [PATCH 06/10] dlm: Delete an error message for a failed memory allocation " SF Markus Elfring
2017-05-06 8:43 ` SF Markus Elfring
2017-05-06 8:43 ` [PATCH 06/10] dlm: Delete an error message for a failed memory allocation in dlm_recover_waiters_pre SF Markus Elfring
2017-05-06 8:44 ` [Cluster-devel] [PATCH 07/10] dlm: Use kmalloc_array() in make_member_array() SF Markus Elfring
2017-05-06 8:44 ` SF Markus Elfring
2017-05-06 8:44 ` SF Markus Elfring
2017-05-06 8:45 ` [Cluster-devel] [PATCH 08/10] dlm: Use kcalloc() in two functions SF Markus Elfring
2017-05-06 8:45 ` SF Markus Elfring
2017-05-06 8:45 ` SF Markus Elfring
2017-05-06 8:47 ` [Cluster-devel] [PATCH 09/10] dlm: Improve a size determination " SF Markus Elfring
2017-05-06 8:47 ` SF Markus Elfring
2017-05-06 8:47 ` SF Markus Elfring
2017-05-06 8:48 ` [Cluster-devel] [PATCH 10/10] dlm: Delete an unnecessary variable initialisation in dlm_ls_start() SF Markus Elfring
2017-05-06 8:48 ` SF Markus Elfring
2017-05-06 8:48 ` SF Markus Elfring
2017-05-08 20:08 ` [Cluster-devel] [PATCH 00/10] fs-DLM: Fine-tuning for several function implementations Bob Peterson
2017-05-08 20:08 ` Bob Peterson
2017-05-08 20:08 ` Bob Peterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34dae3fb-31e8-d8a9-7beb-77b40dc94388@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.