From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 13/15] [media] omap3isp: include linux/mm_types.h
Date: Sat, 01 Jun 2013 17:30:17 +0200 [thread overview]
Message-ID: <3507557.BiLMFItQuE@avalon> (raw)
In-Reply-To: <1370038972-2318779-14-git-send-email-arnd@arndb.de>
Hi Arnd,
Thank you for the patch.
On Saturday 01 June 2013 00:22:50 Arnd Bergmann wrote:
> The ispqueue.h file uses vm_flags_t, which is defined in
> linux/mm_types.h, so we must include that header in order
> to build in all configurations.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
> Cc: linux-media at vger.kernel.org
> Cc: Konstantin Khlebnikov <khlebnikov@openvz.org>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
(with a minor nitpick below)
> ---
> drivers/media/platform/omap3isp/ispqueue.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/omap3isp/ispqueue.h
> b/drivers/media/platform/omap3isp/ispqueue.h index 908dfd7..e6e720c 100644
> --- a/drivers/media/platform/omap3isp/ispqueue.h
> +++ b/drivers/media/platform/omap3isp/ispqueue.h
> @@ -31,6 +31,7 @@
> #include <linux/mutex.h>
> #include <linux/videodev2.h>
> #include <linux/wait.h>
> +#include <linux/mm_types.h>
Could you please make sure the headers are sorted alphabetically ?
Would you like me to take the patch in my tree ? If so I'll sort the headers
myself.
> struct isp_video_queue;
> struct page;
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-kernel@vger.kernel.org, patches@lists.linaro.org,
linux-arm-kernel@lists.infradead.org,
Mauro Carvalho Chehab <mchehab@redhat.com>,
linux-media@vger.kernel.org,
Konstantin Khlebnikov <khlebnikov@openvz.org>
Subject: Re: [PATCH 13/15] [media] omap3isp: include linux/mm_types.h
Date: Sat, 01 Jun 2013 17:30:17 +0200 [thread overview]
Message-ID: <3507557.BiLMFItQuE@avalon> (raw)
In-Reply-To: <1370038972-2318779-14-git-send-email-arnd@arndb.de>
Hi Arnd,
Thank you for the patch.
On Saturday 01 June 2013 00:22:50 Arnd Bergmann wrote:
> The ispqueue.h file uses vm_flags_t, which is defined in
> linux/mm_types.h, so we must include that header in order
> to build in all configurations.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
> Cc: linux-media@vger.kernel.org
> Cc: Konstantin Khlebnikov <khlebnikov@openvz.org>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
(with a minor nitpick below)
> ---
> drivers/media/platform/omap3isp/ispqueue.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/omap3isp/ispqueue.h
> b/drivers/media/platform/omap3isp/ispqueue.h index 908dfd7..e6e720c 100644
> --- a/drivers/media/platform/omap3isp/ispqueue.h
> +++ b/drivers/media/platform/omap3isp/ispqueue.h
> @@ -31,6 +31,7 @@
> #include <linux/mutex.h>
> #include <linux/videodev2.h>
> #include <linux/wait.h>
> +#include <linux/mm_types.h>
Could you please make sure the headers are sorted alphabetically ?
Would you like me to take the patch in my tree ? If so I'll sort the headers
myself.
> struct isp_video_queue;
> struct page;
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-06-01 15:30 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 22:22 [PATCH 00/15] Linux-3.10 ARM randconfig fixes Arnd Bergmann
2013-05-31 22:22 ` Arnd Bergmann
2013-05-31 22:22 ` Arnd Bergmann
2013-05-31 22:22 ` Arnd Bergmann
2013-05-31 22:22 ` Arnd Bergmann
2013-05-31 22:22 ` Arnd Bergmann
2013-05-31 22:22 ` [PATCH 01/15] irqdomain: export irq_domain_add_simple Arnd Bergmann
2013-05-31 22:22 ` Arnd Bergmann
2013-05-31 22:22 ` [PATCH 02/15] mtd: omap2: allow bulding as a module Arnd Bergmann
2013-05-31 22:22 ` Arnd Bergmann
2013-05-31 22:22 ` Arnd Bergmann
2013-05-31 22:22 ` [PATCH 03/15] drm/nouveau: use mdelay instead of large udelay constants Arnd Bergmann
2013-05-31 22:22 ` Arnd Bergmann
2013-05-31 22:30 ` Roy Spliet
2013-05-31 23:34 ` Aaro Koskinen
2013-05-31 23:34 ` Aaro Koskinen
2013-05-31 22:22 ` [PATCH 04/15] [SCSI] nsp32: " Arnd Bergmann
2013-05-31 22:22 ` Arnd Bergmann
2013-05-31 22:22 ` [PATCH 05/15] hwrng: bcm2835: fix MODULE_LICENSE tag Arnd Bergmann
2013-05-31 22:22 ` Arnd Bergmann
2013-06-21 7:16 ` Herbert Xu
2013-06-21 7:16 ` Herbert Xu
2013-05-31 22:22 ` [PATCH 06/15] cpuidle: calxeda: select ARM_CPU_SUSPEND Arnd Bergmann
2013-05-31 22:22 ` Arnd Bergmann
2013-05-31 22:22 ` [PATCH 07/15] cpufreq: spear needs cpufreq table Arnd Bergmann
2013-05-31 22:22 ` Arnd Bergmann
2013-06-01 1:58 ` Viresh Kumar
2013-06-01 1:58 ` Viresh Kumar
2013-06-01 9:03 ` Arnd Bergmann
2013-06-01 9:03 ` Arnd Bergmann
2013-06-01 9:45 ` Viresh Kumar
2013-06-01 9:45 ` Viresh Kumar
2013-06-01 2:17 ` Ezequiel Garcia
2013-06-02 20:42 ` Andrew Lunn
2013-05-31 22:22 ` [PATCH 08/15] thermal: cpu_cooling: fix stub function Arnd Bergmann
2013-05-31 22:22 ` Arnd Bergmann
2013-06-19 17:25 ` Eduardo Valentin
2013-06-19 17:25 ` Eduardo Valentin
2013-06-19 18:18 ` Arnd Bergmann
2013-06-19 18:18 ` Arnd Bergmann
2013-05-31 22:22 ` [PATCH 09/15] drm: always provide debugfs function prototypes Arnd Bergmann
2013-05-31 22:22 ` Arnd Bergmann
2013-05-31 22:22 ` [PATCH 10/15] drm/tilcd: select BACKLIGHT_LCD_SUPPORT Arnd Bergmann
2013-05-31 22:22 ` Arnd Bergmann
2013-05-31 22:22 ` Arnd Bergmann
2013-05-31 22:22 ` [PATCH 11/15] iwlegacy: il_pm_ops is only provided for PM_SLEEP Arnd Bergmann
2013-05-31 22:22 ` Arnd Bergmann
2013-06-01 5:43 ` Brian Norris
2013-06-01 5:43 ` Brian Norris
2013-06-01 9:03 ` Arnd Bergmann
2013-06-01 9:03 ` Arnd Bergmann
2013-06-01 9:12 ` [PATCH v2] " Arnd Bergmann
2013-06-01 9:12 ` Arnd Bergmann
2013-05-31 22:22 ` [PATCH 12/15] [media] davinci: vpfe_capture needs i2c Arnd Bergmann
2013-05-31 22:22 ` Arnd Bergmann
2013-05-31 22:22 ` [PATCH 13/15] [media] omap3isp: include linux/mm_types.h Arnd Bergmann
2013-05-31 22:22 ` Arnd Bergmann
2013-06-01 15:30 ` Laurent Pinchart [this message]
2013-06-01 15:30 ` Laurent Pinchart
2013-06-01 20:04 ` Arnd Bergmann
2013-06-01 20:04 ` Arnd Bergmann
2013-05-31 22:22 ` [PATCH 14/15] clk: tegra: provide tegra_periph_reset_assert alternative Arnd Bergmann
2013-05-31 22:22 ` Arnd Bergmann
2013-05-31 22:22 ` [PATCH 15/15] OF: remove #ifdef from linux/of_platform.h Arnd Bergmann
2013-05-31 22:22 ` Arnd Bergmann
2013-06-01 14:01 ` Rob Herring
2013-06-01 14:01 ` Rob Herring
2013-06-01 20:03 ` Arnd Bergmann
2013-06-01 20:03 ` Arnd Bergmann
2013-06-01 20:30 ` Rob Herring
2013-06-01 20:30 ` Rob Herring
2013-06-01 20:57 ` Arnd Bergmann
2013-06-01 20:57 ` Arnd Bergmann
2013-06-04 13:01 ` Rob Herring
2013-06-04 13:01 ` Rob Herring
2013-06-04 17:51 ` Arnd Bergmann
2013-06-04 17:51 ` Arnd Bergmann
2013-06-04 22:24 ` Rob Herring
2013-06-04 22:24 ` Rob Herring
2013-06-05 12:13 ` Arnd Bergmann
2013-06-05 12:13 ` Arnd Bergmann
2013-06-05 21:48 ` Grant Likely
2013-06-05 21:48 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3507557.BiLMFItQuE@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.