All of lore.kernel.org
 help / color / mirror / Atom feed
From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 15/15] OF: remove #ifdef from linux/of_platform.h
Date: Sat, 01 Jun 2013 15:30:08 -0500	[thread overview]
Message-ID: <51AA59D0.7020805@gmail.com> (raw)
In-Reply-To: <201306012203.39133.arnd@arndb.de>

On 06/01/2013 03:03 PM, Arnd Bergmann wrote:
> On Saturday 01 June 2013, Rob Herring wrote:
>> On Fri, May 31, 2013 at 5:22 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>>> A lot of code uses the functions from of_platform.h when built for
>>> devicetree-enabled platforms but can also be built without them.
>>> In order to avoid using #ifdef everywhere in drivers, this
>>> makes all the function declarations visible, which means we
>>> can use "if (IS_ENABLED(CONFIG_OF))" in driver code and get build
>>> coverage over the code but let the compiler drop the reference
>>> in the object code.
>>>
>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>> Cc: Grant Likely <grant.likely@linaro.org>
>>> Cc: Rob Herring <rob.herring@calxeda.com>
>>
>> I've got a more complete series for 3.11 that removes OF_DEVICE and
>> of_platform_driver completely. I'm waiting on ack from Ben H.
> 
> Ok. Does your series also remove the #ifdef CONFIG_OF part from this
> header?

No, we still need empty functions. Here is what of_device.h looks like:

http://tinyurl.com/l2azz5m

BTW, it has your ack.

Rob

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robherring2@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Grant Likely <grant.likely@linaro.org>,
	patches@lists.linaro.org, Rob Herring <rob.herring@calxeda.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH 15/15] OF: remove #ifdef from linux/of_platform.h
Date: Sat, 01 Jun 2013 15:30:08 -0500	[thread overview]
Message-ID: <51AA59D0.7020805@gmail.com> (raw)
In-Reply-To: <201306012203.39133.arnd@arndb.de>

On 06/01/2013 03:03 PM, Arnd Bergmann wrote:
> On Saturday 01 June 2013, Rob Herring wrote:
>> On Fri, May 31, 2013 at 5:22 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>>> A lot of code uses the functions from of_platform.h when built for
>>> devicetree-enabled platforms but can also be built without them.
>>> In order to avoid using #ifdef everywhere in drivers, this
>>> makes all the function declarations visible, which means we
>>> can use "if (IS_ENABLED(CONFIG_OF))" in driver code and get build
>>> coverage over the code but let the compiler drop the reference
>>> in the object code.
>>>
>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>> Cc: Grant Likely <grant.likely@linaro.org>
>>> Cc: Rob Herring <rob.herring@calxeda.com>
>>
>> I've got a more complete series for 3.11 that removes OF_DEVICE and
>> of_platform_driver completely. I'm waiting on ack from Ben H.
> 
> Ok. Does your series also remove the #ifdef CONFIG_OF part from this
> header?

No, we still need empty functions. Here is what of_device.h looks like:

http://tinyurl.com/l2azz5m

BTW, it has your ack.

Rob

  reply	other threads:[~2013-06-01 20:30 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-31 22:22 [PATCH 00/15] Linux-3.10 ARM randconfig fixes Arnd Bergmann
2013-05-31 22:22 ` Arnd Bergmann
2013-05-31 22:22 ` Arnd Bergmann
2013-05-31 22:22 ` Arnd Bergmann
2013-05-31 22:22 ` Arnd Bergmann
2013-05-31 22:22 ` Arnd Bergmann
2013-05-31 22:22 ` [PATCH 01/15] irqdomain: export irq_domain_add_simple Arnd Bergmann
2013-05-31 22:22   ` Arnd Bergmann
2013-05-31 22:22 ` [PATCH 02/15] mtd: omap2: allow bulding as a module Arnd Bergmann
2013-05-31 22:22   ` Arnd Bergmann
2013-05-31 22:22   ` Arnd Bergmann
2013-05-31 22:22 ` [PATCH 03/15] drm/nouveau: use mdelay instead of large udelay constants Arnd Bergmann
2013-05-31 22:22   ` Arnd Bergmann
2013-05-31 22:30   ` Roy Spliet
2013-05-31 23:34   ` Aaro Koskinen
2013-05-31 23:34     ` Aaro Koskinen
2013-05-31 22:22 ` [PATCH 04/15] [SCSI] nsp32: " Arnd Bergmann
2013-05-31 22:22   ` Arnd Bergmann
2013-05-31 22:22 ` [PATCH 05/15] hwrng: bcm2835: fix MODULE_LICENSE tag Arnd Bergmann
2013-05-31 22:22   ` Arnd Bergmann
2013-06-21  7:16   ` Herbert Xu
2013-06-21  7:16     ` Herbert Xu
2013-05-31 22:22 ` [PATCH 06/15] cpuidle: calxeda: select ARM_CPU_SUSPEND Arnd Bergmann
2013-05-31 22:22   ` Arnd Bergmann
2013-05-31 22:22 ` [PATCH 07/15] cpufreq: spear needs cpufreq table Arnd Bergmann
2013-05-31 22:22   ` Arnd Bergmann
2013-06-01  1:58   ` Viresh Kumar
2013-06-01  1:58     ` Viresh Kumar
2013-06-01  9:03     ` Arnd Bergmann
2013-06-01  9:03       ` Arnd Bergmann
2013-06-01  9:45       ` Viresh Kumar
2013-06-01  9:45         ` Viresh Kumar
2013-06-01  2:17   ` Ezequiel Garcia
2013-06-02 20:42     ` Andrew Lunn
2013-05-31 22:22 ` [PATCH 08/15] thermal: cpu_cooling: fix stub function Arnd Bergmann
2013-05-31 22:22   ` Arnd Bergmann
2013-06-19 17:25   ` Eduardo Valentin
2013-06-19 17:25     ` Eduardo Valentin
2013-06-19 18:18     ` Arnd Bergmann
2013-06-19 18:18       ` Arnd Bergmann
2013-05-31 22:22 ` [PATCH 09/15] drm: always provide debugfs function prototypes Arnd Bergmann
2013-05-31 22:22   ` Arnd Bergmann
2013-05-31 22:22 ` [PATCH 10/15] drm/tilcd: select BACKLIGHT_LCD_SUPPORT Arnd Bergmann
2013-05-31 22:22   ` Arnd Bergmann
2013-05-31 22:22   ` Arnd Bergmann
2013-05-31 22:22 ` [PATCH 11/15] iwlegacy: il_pm_ops is only provided for PM_SLEEP Arnd Bergmann
2013-05-31 22:22   ` Arnd Bergmann
2013-06-01  5:43   ` Brian Norris
2013-06-01  5:43     ` Brian Norris
2013-06-01  9:03     ` Arnd Bergmann
2013-06-01  9:03       ` Arnd Bergmann
2013-06-01  9:12     ` [PATCH v2] " Arnd Bergmann
2013-06-01  9:12       ` Arnd Bergmann
2013-05-31 22:22 ` [PATCH 12/15] [media] davinci: vpfe_capture needs i2c Arnd Bergmann
2013-05-31 22:22   ` Arnd Bergmann
2013-05-31 22:22 ` [PATCH 13/15] [media] omap3isp: include linux/mm_types.h Arnd Bergmann
2013-05-31 22:22   ` Arnd Bergmann
2013-06-01 15:30   ` Laurent Pinchart
2013-06-01 15:30     ` Laurent Pinchart
2013-06-01 20:04     ` Arnd Bergmann
2013-06-01 20:04       ` Arnd Bergmann
2013-05-31 22:22 ` [PATCH 14/15] clk: tegra: provide tegra_periph_reset_assert alternative Arnd Bergmann
2013-05-31 22:22   ` Arnd Bergmann
2013-05-31 22:22 ` [PATCH 15/15] OF: remove #ifdef from linux/of_platform.h Arnd Bergmann
2013-05-31 22:22   ` Arnd Bergmann
2013-06-01 14:01   ` Rob Herring
2013-06-01 14:01     ` Rob Herring
2013-06-01 20:03     ` Arnd Bergmann
2013-06-01 20:03       ` Arnd Bergmann
2013-06-01 20:30       ` Rob Herring [this message]
2013-06-01 20:30         ` Rob Herring
2013-06-01 20:57         ` Arnd Bergmann
2013-06-01 20:57           ` Arnd Bergmann
2013-06-04 13:01           ` Rob Herring
2013-06-04 13:01             ` Rob Herring
2013-06-04 17:51             ` Arnd Bergmann
2013-06-04 17:51               ` Arnd Bergmann
2013-06-04 22:24               ` Rob Herring
2013-06-04 22:24                 ` Rob Herring
2013-06-05 12:13                 ` Arnd Bergmann
2013-06-05 12:13                   ` Arnd Bergmann
2013-06-05 21:48                 ` Grant Likely
2013-06-05 21:48                   ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51AA59D0.7020805@gmail.com \
    --to=robherring2@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.