From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Aditya Pakki <pakki001@umn.edu>,
Marek Lindner <mareklindner@neomailbox.ch>,
kjlu@umn.edu, Antonio Quartulli <a@unstable.cc>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv/main: Fix check on return value of rtnl_link_register
Date: Mon, 24 Dec 2018 19:46:32 +0100 [thread overview]
Message-ID: <3515548.IyJqbIalli@sven-edge> (raw)
In-Reply-To: <20181224174926.20321-1-pakki001@umn.edu>
[-- Attachment #1: Type: text/plain, Size: 400 bytes --]
On Monday, 24 December 2018 18.49.26 CET Aditya Pakki wrote:
> rtnl_link_register() may fail and can impact registering the device.
> The fix checks the return value and pushes the error upstream.
Regarding the commit message - what is "batman-adv/main"? Shouldn't this be
"batman-adv: "?
And the device can still be registered without batadv_link_ops - just not
using rtnl.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Sven Eckelmann <sven-KaDOiPu9UxWEi8DpZVb4nw@public.gmane.org>
To: b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org
Cc: Marek Lindner
<mareklindner-rVWd3aGhH2z5bpWLKbzFeg@public.gmane.org>,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Antonio Quartulli <a@unstable.cc>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Aditya Pakki <pakki001-OJFnDUYgAso@public.gmane.org>,
kjlu-OJFnDUYgAso@public.gmane.org,
"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Subject: Re: [PATCH] batman-adv/main: Fix check on return value of rtnl_link_register
Date: Mon, 24 Dec 2018 19:46:32 +0100 [thread overview]
Message-ID: <3515548.IyJqbIalli@sven-edge> (raw)
In-Reply-To: <20181224174926.20321-1-pakki001-OJFnDUYgAso@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 400 bytes --]
On Monday, 24 December 2018 18.49.26 CET Aditya Pakki wrote:
> rtnl_link_register() may fail and can impact registering the device.
> The fix checks the return value and pushes the error upstream.
Regarding the commit message - what is "batman-adv/main"? Shouldn't this be
"batman-adv: "?
And the device can still be registered without batadv_link_ops - just not
using rtnl.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-12-24 18:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-24 17:49 [B.A.T.M.A.N.] [PATCH] batman-adv/main: Fix check on return value of rtnl_link_register Aditya Pakki
2018-12-24 17:49 ` Aditya Pakki
2018-12-24 18:43 ` [B.A.T.M.A.N.] " Sven Eckelmann
2018-12-24 18:43 ` Sven Eckelmann
2018-12-24 18:46 ` Sven Eckelmann [this message]
2018-12-24 18:46 ` Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3515548.IyJqbIalli@sven-edge \
--to=sven@narfation.org \
--cc=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=mareklindner@neomailbox.ch \
--cc=netdev@vger.kernel.org \
--cc=pakki001@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.