All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wu Fengguang <wfg@mail.ustc.edu.cn>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, Wu Fengguang <wfg@mail.ustc.edu.cn>
Subject: [PATCH 09/28] readahead: rescue_pages()
Date: Wed, 15 Nov 2006 15:50:16 +0800	[thread overview]
Message-ID: <363577023.13886@ustc.edu.cn> (raw)
Message-ID: <20061115075027.139255636@localhost.localdomain> (raw)
In-Reply-To: 20061115075007.832957580@localhost.localdomain

[-- Attachment #1: readahead-rescue_pages.patch --]
[-- Type: text/plain, Size: 3207 bytes --]

Introduce function rescue_pages() to protect pages in danger of thrashing.

Signed-off-by: Wu Fengguang <wfg@mail.ustc.edu.cn>
Signed-off-by: Andrew Morton <akpm@osdl.org>
--- linux-2.6.19-rc5-mm1.orig/mm/readahead.c
+++ linux-2.6.19-rc5-mm1/mm/readahead.c
@@ -708,6 +708,96 @@ unsigned long max_sane_readahead(unsigne
 }
 
 /*
+ * Adaptive read-ahead.
+ *
+ * Good read patterns are compact both in space and time. The read-ahead logic
+ * tries to grant larger read-ahead size to better readers under the constraint
+ * of system memory and load pressure.
+ *
+ * It employs two methods to estimate the max thrashing safe read-ahead size:
+ *   1. state based   - the default one
+ *   2. context based - the failsafe one
+ * The integration of the dual methods has the merit of being agile and robust.
+ * It makes the overall design clean: special cases are handled in general by
+ * the stateless method, leaving the stateful one simple and fast.
+ *
+ * To improve throughput and decrease read delay, the logic 'looks ahead'.
+ * In most read-ahead chunks, one page will be selected and tagged with
+ * PG_readahead. Later when the page with PG_readahead is read, the logic
+ * will be notified to submit the next read-ahead chunk in advance.
+ *
+ *                 a read-ahead chunk
+ *    +-----------------------------------------+
+ *    |       # PG_readahead                    |
+ *    +-----------------------------------------+
+ *            ^ When this page is read, notify me for the next read-ahead.
+ *
+ */
+
+#ifdef CONFIG_ADAPTIVE_READAHEAD
+
+/*
+ * Move pages in danger (of thrashing) to the head of inactive_list.
+ * Not expected to happen frequently.
+ *
+ * @page will be skipped: it's grabbed and won't die away.
+ * The following @nr_pages-1 pages will be protected.
+ */
+static unsigned long rescue_pages(struct page *page, unsigned long nr_pages)
+{
+	int pgrescue = 0;
+	pgoff_t index = page_index(page);
+	struct address_space *mapping = page_mapping(page);
+	struct page *grabbed_page = NULL;
+	struct zone *zone;
+
+	dprintk("rescue_pages(ino=%lu, index=%lu nr=%lu)\n",
+			mapping->host->i_ino, index, nr_pages);
+
+	for(;;) {
+		zone = page_zone(page);
+		spin_lock_irq(&zone->lru_lock);
+
+		if (!PageLRU(page))
+			goto out_unlock;
+
+		while (page_mapping(page) == mapping &&
+				page_index(page) == index) {
+			struct page *the_page = page;
+			page = list_entry((page)->lru.prev, struct page, lru);
+			if (!PageActive(the_page) &&
+					!PageLocked(the_page) &&
+					page_count(the_page) == 1) {
+				list_move(&the_page->lru, &zone->inactive_list);
+				pgrescue++;
+			}
+			index++;
+			if (!--nr_pages)
+				goto out_unlock;
+		}
+
+		spin_unlock_irq(&zone->lru_lock);
+		cond_resched();
+
+		if (grabbed_page)
+			page_cache_release(grabbed_page);
+		grabbed_page = page = find_get_page(mapping, index);
+		if (!page)
+			goto out;
+	}
+
+out_unlock:
+	spin_unlock_irq(&zone->lru_lock);
+out:
+	if (grabbed_page)
+		page_cache_release(grabbed_page);
+	ra_account(NULL, RA_EVENT_READAHEAD_RESCUE, pgrescue);
+	return nr_pages;
+}
+
+#endif /* CONFIG_ADAPTIVE_READAHEAD */
+
+/*
  * Read-ahead events accounting.
  */
 #ifdef CONFIG_DEBUG_READAHEAD

--

  parent reply	other threads:[~2006-11-15  7:52 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-15  7:50 [PATCH 00/28] Adaptive readahead V16 Wu Fengguang
2006-11-15  7:50 ` Wu Fengguang
2006-11-15  7:50 ` [PATCH 01/28] readahead: kconfig options Wu Fengguang
2006-11-15  7:50   ` Wu Fengguang
2006-11-15  7:50 ` [PATCH 02/28] radixtree: introduce scan hole/data functions Wu Fengguang
2006-11-15  7:50   ` Wu Fengguang
2006-11-15  7:50 ` [PATCH 03/28] mm: introduce probe_page() Wu Fengguang
2006-11-15  7:50   ` Wu Fengguang
2006-11-15  7:50 ` [PATCH 04/28] mm: introduce PG_readahead Wu Fengguang
2006-11-15  7:50   ` Wu Fengguang
2006-11-15  7:50 ` [PATCH 06/28] readahead: insert cond_resched() calls Wu Fengguang
2006-11-15  7:50   ` Wu Fengguang
2006-11-15  7:50 ` Wu Fengguang [this message]
2006-11-15  7:50   ` [PATCH 09/28] readahead: rescue_pages() Wu Fengguang
2006-11-15  7:50 ` [PATCH 11/28] readahead: min/max sizes Wu Fengguang
2006-11-15  7:50   ` Wu Fengguang
2006-11-15  7:50 ` [PATCH 12/28] readahead: state based method - aging accounting Wu Fengguang
2006-11-15  7:50   ` Wu Fengguang
2006-11-15 16:54     ` Christoph Lameter
2006-11-16 13:39       ` Wu Fengguang
2006-11-16 13:39         ` Wu Fengguang
2006-11-15  7:50 ` [PATCH 13/28] readahead: state based method - routines Wu Fengguang
2006-11-15  7:50   ` Wu Fengguang
2006-11-15  7:50 ` [PATCH 14/28] readahead: state based method Wu Fengguang
2006-11-15  7:50   ` Wu Fengguang
2006-11-15  7:50 ` [PATCH 15/28] readahead: context " Wu Fengguang
2006-11-15  7:50   ` Wu Fengguang
2006-11-15  7:50 ` [PATCH 16/28] readahead: initial method - guiding sizes Wu Fengguang
2006-11-15  7:50   ` Wu Fengguang
2006-11-15  7:50 ` [PATCH 17/28] readahead: initial method - thrashing guard size Wu Fengguang
2006-11-15  7:50   ` Wu Fengguang
2006-11-15  7:50 ` [PATCH 18/28] readahead: initial method - user recommended size Wu Fengguang
2006-11-15  7:50   ` Wu Fengguang
2006-11-15  7:50 ` [PATCH 20/28] readahead: backward prefetching method Wu Fengguang
2006-11-15  7:50   ` Wu Fengguang
2006-11-15  7:50 ` [PATCH 21/28] readahead: thrashing recovery method Wu Fengguang
2006-11-15  7:50   ` Wu Fengguang
2006-11-15  7:50 ` [PATCH 22/28] readahead: call scheme Wu Fengguang
2006-11-15  7:50   ` Wu Fengguang
2006-11-15  7:50 ` [PATCH 23/28] readahead: laptop mode Wu Fengguang
2006-11-15  7:50   ` Wu Fengguang
2006-11-15  7:50 ` [PATCH 24/28] readahead: loop case Wu Fengguang
2006-11-15  7:50   ` Wu Fengguang
2006-11-15  7:50 ` [PATCH 25/28] readahead: nfsd case Wu Fengguang
2006-11-15  7:50   ` Wu Fengguang
2006-11-15  7:50 ` [PATCH 26/28] readahead: turn on by default Wu Fengguang
2006-11-15  7:50   ` Wu Fengguang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=363577023.13886@ustc.edu.cn \
    --to=wfg@mail.ustc.edu.cn \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.