All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wu Fengguang <wfg@mail.ustc.edu.cn>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, Wu Fengguang <wfg@mail.ustc.edu.cn>
Subject: [PATCH 23/28] readahead: laptop mode
Date: Wed, 15 Nov 2006 15:50:30 +0800	[thread overview]
Message-ID: <363577028.93218@ustc.edu.cn> (raw)
Message-ID: <20061115075031.909090639@localhost.localdomain> (raw)
In-Reply-To: 20061115075007.832957580@localhost.localdomain

[-- Attachment #1: readahead-laptop-mode.patch --]
[-- Type: text/plain, Size: 3190 bytes --]

When the laptop drive is spinned down, defer look-ahead to spin up time.

The implementation employs a poll based method, for performance is not a
concern in this code path. The poll interval is 64KB, which should be small
enough for movies/musics. The user space application is responsible for
proper caching to hide the spin-up-and-read delay.

For crazy laptop users who prefer aggressive read-ahead, here is the way:

# echo 1000 > /proc/sys/vm/readahead_ratio
# blockdev --setra 524280 /dev/hda      # this is the max possible value

Notes:
- It is still an untested feature.
- It is safer to use blockdev+fadvise to increase ra-max for a single file,
  which needs patching your movie player.
- Be sure to restore them to sane values in normal operations!

Signed-off-by: Wu Fengguang <wfg@mail.ustc.edu.cn>
Signed-off-by: Andrew Morton <akpm@osdl.org>
--- linux-2.6.19-rc5-mm2.orig/include/linux/writeback.h
+++ linux-2.6.19-rc5-mm2/include/linux/writeback.h
@@ -86,6 +86,12 @@ void laptop_io_completion(void);
 void laptop_sync_completion(void);
 void throttle_vm_writeout(void);
 
+extern struct timer_list laptop_mode_wb_timer;
+static inline int laptop_spinned_down(void)
+{
+	return !timer_pending(&laptop_mode_wb_timer);
+}
+
 /* These are exported to sysctl. */
 extern int dirty_background_ratio;
 extern int vm_dirty_ratio;
--- linux-2.6.19-rc5-mm2.orig/mm/page-writeback.c
+++ linux-2.6.19-rc5-mm2/mm/page-writeback.c
@@ -375,7 +375,7 @@ static void wb_timer_fn(unsigned long un
 static void laptop_timer_fn(unsigned long unused);
 
 static DEFINE_TIMER(wb_timer, wb_timer_fn, 0, 0);
-static DEFINE_TIMER(laptop_mode_wb_timer, laptop_timer_fn, 0, 0);
+DEFINE_TIMER(laptop_mode_wb_timer, laptop_timer_fn, 0, 0);
 
 /*
  * Periodic writeback of "old" data.
--- linux-2.6.19-rc5-mm2.orig/mm/readahead.c
+++ linux-2.6.19-rc5-mm2/mm/readahead.c
@@ -17,6 +17,7 @@
 #include <linux/backing-dev.h>
 #include <linux/pagevec.h>
 #include <linux/buffer_head.h>
+#include <linux/writeback.h>
 
 #include <asm/div64.h>
 
@@ -822,6 +823,32 @@ out:
 }
 
 /*
+ * Set a new look-ahead mark at @next.
+ * Return 0 if the new mark is successfully set.
+ */
+static int renew_lookahead(struct address_space *mapping,
+				struct file_ra_state *ra,
+				pgoff_t offset, pgoff_t next)
+{
+	struct page *page;
+
+	if (offset == ra->lookahead_index &&
+	      next >= ra->readahead_index)
+		return 1;
+
+	if (!(page = find_get_page(mapping, next)))
+		return 1;
+
+	SetPageReadahead(page);
+	page_cache_release(page);
+
+	if (ra->lookahead_index == offset)
+	    ra->lookahead_index = next;
+
+	return 0;
+}
+
+/*
  * Update `backing_dev_info.ra_thrash_bytes' to be a _biased_ average of
  * read-ahead sizes. Which makes it an a-bit-risky(*) estimation of the
  * _minimal_ read-ahead thrashing threshold on the device.
@@ -1629,6 +1656,15 @@ page_cache_readahead_adaptive(struct add
 			ra_account(ra, RA_EVENT_IO_CONGESTION, req_size);
 			return 0;
 		}
+
+		/*
+		 * Defer read-ahead to save energy.
+		 */
+		if (unlikely(laptop_mode && laptop_spinned_down())) {
+			if (!renew_lookahead(mapping, ra, offset,
+						offset + LAPTOP_POLL_INTERVAL))
+				return 0;
+		}
 	}
 
 	if (page)

--

  parent reply	other threads:[~2006-11-15  7:56 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-15  7:50 [PATCH 00/28] Adaptive readahead V16 Wu Fengguang
2006-11-15  7:50 ` Wu Fengguang
2006-11-15  7:50 ` [PATCH 01/28] readahead: kconfig options Wu Fengguang
2006-11-15  7:50   ` Wu Fengguang
2006-11-15  7:50 ` [PATCH 02/28] radixtree: introduce scan hole/data functions Wu Fengguang
2006-11-15  7:50   ` Wu Fengguang
2006-11-15  7:50 ` [PATCH 03/28] mm: introduce probe_page() Wu Fengguang
2006-11-15  7:50   ` Wu Fengguang
2006-11-15  7:50 ` [PATCH 04/28] mm: introduce PG_readahead Wu Fengguang
2006-11-15  7:50   ` Wu Fengguang
2006-11-15  7:50 ` [PATCH 06/28] readahead: insert cond_resched() calls Wu Fengguang
2006-11-15  7:50   ` Wu Fengguang
2006-11-15  7:50 ` [PATCH 09/28] readahead: rescue_pages() Wu Fengguang
2006-11-15  7:50   ` Wu Fengguang
2006-11-15  7:50 ` [PATCH 11/28] readahead: min/max sizes Wu Fengguang
2006-11-15  7:50   ` Wu Fengguang
2006-11-15  7:50 ` [PATCH 12/28] readahead: state based method - aging accounting Wu Fengguang
2006-11-15  7:50   ` Wu Fengguang
2006-11-15 16:54     ` Christoph Lameter
2006-11-16 13:39       ` Wu Fengguang
2006-11-16 13:39         ` Wu Fengguang
2006-11-15  7:50 ` [PATCH 13/28] readahead: state based method - routines Wu Fengguang
2006-11-15  7:50   ` Wu Fengguang
2006-11-15  7:50 ` [PATCH 14/28] readahead: state based method Wu Fengguang
2006-11-15  7:50   ` Wu Fengguang
2006-11-15  7:50 ` [PATCH 15/28] readahead: context " Wu Fengguang
2006-11-15  7:50   ` Wu Fengguang
2006-11-15  7:50 ` [PATCH 16/28] readahead: initial method - guiding sizes Wu Fengguang
2006-11-15  7:50   ` Wu Fengguang
2006-11-15  7:50 ` [PATCH 17/28] readahead: initial method - thrashing guard size Wu Fengguang
2006-11-15  7:50   ` Wu Fengguang
2006-11-15  7:50 ` [PATCH 18/28] readahead: initial method - user recommended size Wu Fengguang
2006-11-15  7:50   ` Wu Fengguang
2006-11-15  7:50 ` [PATCH 20/28] readahead: backward prefetching method Wu Fengguang
2006-11-15  7:50   ` Wu Fengguang
2006-11-15  7:50 ` [PATCH 21/28] readahead: thrashing recovery method Wu Fengguang
2006-11-15  7:50   ` Wu Fengguang
2006-11-15  7:50 ` [PATCH 22/28] readahead: call scheme Wu Fengguang
2006-11-15  7:50   ` Wu Fengguang
2006-11-15  7:50 ` Wu Fengguang [this message]
2006-11-15  7:50   ` [PATCH 23/28] readahead: laptop mode Wu Fengguang
2006-11-15  7:50 ` [PATCH 24/28] readahead: loop case Wu Fengguang
2006-11-15  7:50   ` Wu Fengguang
2006-11-15  7:50 ` [PATCH 25/28] readahead: nfsd case Wu Fengguang
2006-11-15  7:50   ` Wu Fengguang
2006-11-15  7:50 ` [PATCH 26/28] readahead: turn on by default Wu Fengguang
2006-11-15  7:50   ` Wu Fengguang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=363577028.93218@ustc.edu.cn \
    --to=wfg@mail.ustc.edu.cn \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.