From: Matthias Brugger <mbrugger@suse.com>
To: Charles Mirabile <cmirabil@redhat.com>, linux-kernel@vger.kernel.org
Cc: Peter Robinson <pbrobinson@gmail.com>,
Serge Schneider <serge@raspberrypi.org>,
Stefan Wahren <stefan.wahren@i2se.com>,
Nicolas Saenz Julienne <nicolassaenzj@gmail.com>,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, rh-kdlp@googlegroups.com,
Joel Slebodnick <jslebodn@redhat.com>,
Joel Savitz <jsavitz@redhat.com>
Subject: Re: [PATCH v10 0/6] Raspberry Pi Sense HAT driver
Date: Wed, 24 Aug 2022 13:28:49 +0200 [thread overview]
Message-ID: <369a74dd-e357-a352-fb17-fa5aa3726e0e@suse.com> (raw)
In-Reply-To: <20220823174158.45579-1-cmirabil@redhat.com>
On 23/08/2022 19:41, Charles Mirabile wrote:
> This patch series adds a set of drivers for operating the Sense HAT
> peripheral device. This board is an add on for the Raspberry Pi that is
> designed to connect using the GPIO connector and communicate via I2C.
>
> It features:
> - a joystick
> - an 8x8 RGB LED matrix display
> - a whole bunch of environmental sensors with their own drivers
> (those are already in upstream Linux)
>
> This is a refactor of the work of Serge Schneider, the author of a
> version of this driver that is currently in the Raspberry Pi downstream
> kernel. We modified his code to make it suitable for upstream Linux.
>
> A couple of tests are available for the driver in the test folder in
> this repo: https://github.com/underground-software/sensehat.git
> - sensehat_joystick_test logs the input events from the
> joystick to the console
> - sensehat_display_test displays various solid colors on
> the LED panel.
> - full_sensehat_test displays a single lit cell that can be
> moved with the joystick. Pressing the joystick ends the
> program.
>
> For more information about the Sense HAT, visit:
> https://www.raspberrypi.org/products/sense-hat/
>
> Changes since v9:
> - The driver for the sensehat joystick was accepted upstream so
> it is no longer included in this patchset.
> - Some of the people involved in the development of earlier
> versions of these patches are no longer involved in the project
> so they have been removed from the list of maintainers and the
> patches.
I'd would expect the patches to honor their involvement in the past, but if they
are fine from being dropped, I will not object...
Regards,
Matthias
> - The code is completely unchanged and so based on the discussions
> from version 9 of the patches, it should be ready to be merged.
>
> My appologies for the long delay between v9 and v10 especially given the
> fact that there are no changes to the code. We appreciate the maintainers'
> patience and guidance throughout all 10 versions of this sensehat patchset,
> and we are excited for this driver to hopefully be fully accepted.
>
> Best - Charlie
>
> Co-developed-by: Joel Slebodnick <jslebodn@redhat.com>
> Signed-off-by: Joel Slebodnick <jslebodn@redhat.com>
> Co-developed-by: Joel Savitz <jsavitz@redhat.com>
> Signed-off-by: Joel Savitz <jsavitz@redhat.com>
> Signed-off-by: Charles Mirabile <cmirabil@redhat.com>
>
> Charles Mirabile (5):
> drivers/mfd: sensehat: Add Raspberry Pi Sense HAT to simple_mfd_i2c
> drivers/auxdisplay: sensehat: Raspberry Pi Sense HAT display driver
> dt-bindings: mfd: sensehat: Add Raspberry Pi Sense HAT schema
> MAINTAINERS: Add sensehat driver authors to MAINTAINERS
> DO NOT MERGE: full sensehat device tree overlay for raspberry pi 4
>
> .../raspberrypi,sensehat-display.yaml | 26 +++
> .../input/raspberrypi,sensehat-joystick.yaml | 31 +++
> .../bindings/mfd/raspberrypi,sensehat.yaml | 57 +++++
> MAINTAINERS | 10 +
> drivers/auxdisplay/Kconfig | 8 +
> drivers/auxdisplay/Makefile | 1 +
> drivers/auxdisplay/sensehat-display.c | 205 ++++++++++++++++++
> drivers/mfd/simple-mfd-i2c.c | 1 +
> sensehat.dtbs | 52 +++++
> 9 files changed, 391 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/auxdisplay/raspberrypi,sensehat-display.yaml
> create mode 100644 Documentation/devicetree/bindings/input/raspberrypi,sensehat-joystick.yaml
> create mode 100644 Documentation/devicetree/bindings/mfd/raspberrypi,sensehat.yaml
> create mode 100644 drivers/auxdisplay/sensehat-display.c
> create mode 100644 sensehat.dtbs
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Brugger <mbrugger@suse.com>
To: Charles Mirabile <cmirabil@redhat.com>, linux-kernel@vger.kernel.org
Cc: Peter Robinson <pbrobinson@gmail.com>,
Serge Schneider <serge@raspberrypi.org>,
Stefan Wahren <stefan.wahren@i2se.com>,
Nicolas Saenz Julienne <nicolassaenzj@gmail.com>,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, rh-kdlp@googlegroups.com,
Joel Slebodnick <jslebodn@redhat.com>,
Joel Savitz <jsavitz@redhat.com>
Subject: Re: [PATCH v10 0/6] Raspberry Pi Sense HAT driver
Date: Wed, 24 Aug 2022 13:28:49 +0200 [thread overview]
Message-ID: <369a74dd-e357-a352-fb17-fa5aa3726e0e@suse.com> (raw)
In-Reply-To: <20220823174158.45579-1-cmirabil@redhat.com>
On 23/08/2022 19:41, Charles Mirabile wrote:
> This patch series adds a set of drivers for operating the Sense HAT
> peripheral device. This board is an add on for the Raspberry Pi that is
> designed to connect using the GPIO connector and communicate via I2C.
>
> It features:
> - a joystick
> - an 8x8 RGB LED matrix display
> - a whole bunch of environmental sensors with their own drivers
> (those are already in upstream Linux)
>
> This is a refactor of the work of Serge Schneider, the author of a
> version of this driver that is currently in the Raspberry Pi downstream
> kernel. We modified his code to make it suitable for upstream Linux.
>
> A couple of tests are available for the driver in the test folder in
> this repo: https://github.com/underground-software/sensehat.git
> - sensehat_joystick_test logs the input events from the
> joystick to the console
> - sensehat_display_test displays various solid colors on
> the LED panel.
> - full_sensehat_test displays a single lit cell that can be
> moved with the joystick. Pressing the joystick ends the
> program.
>
> For more information about the Sense HAT, visit:
> https://www.raspberrypi.org/products/sense-hat/
>
> Changes since v9:
> - The driver for the sensehat joystick was accepted upstream so
> it is no longer included in this patchset.
> - Some of the people involved in the development of earlier
> versions of these patches are no longer involved in the project
> so they have been removed from the list of maintainers and the
> patches.
I'd would expect the patches to honor their involvement in the past, but if they
are fine from being dropped, I will not object...
Regards,
Matthias
> - The code is completely unchanged and so based on the discussions
> from version 9 of the patches, it should be ready to be merged.
>
> My appologies for the long delay between v9 and v10 especially given the
> fact that there are no changes to the code. We appreciate the maintainers'
> patience and guidance throughout all 10 versions of this sensehat patchset,
> and we are excited for this driver to hopefully be fully accepted.
>
> Best - Charlie
>
> Co-developed-by: Joel Slebodnick <jslebodn@redhat.com>
> Signed-off-by: Joel Slebodnick <jslebodn@redhat.com>
> Co-developed-by: Joel Savitz <jsavitz@redhat.com>
> Signed-off-by: Joel Savitz <jsavitz@redhat.com>
> Signed-off-by: Charles Mirabile <cmirabil@redhat.com>
>
> Charles Mirabile (5):
> drivers/mfd: sensehat: Add Raspberry Pi Sense HAT to simple_mfd_i2c
> drivers/auxdisplay: sensehat: Raspberry Pi Sense HAT display driver
> dt-bindings: mfd: sensehat: Add Raspberry Pi Sense HAT schema
> MAINTAINERS: Add sensehat driver authors to MAINTAINERS
> DO NOT MERGE: full sensehat device tree overlay for raspberry pi 4
>
> .../raspberrypi,sensehat-display.yaml | 26 +++
> .../input/raspberrypi,sensehat-joystick.yaml | 31 +++
> .../bindings/mfd/raspberrypi,sensehat.yaml | 57 +++++
> MAINTAINERS | 10 +
> drivers/auxdisplay/Kconfig | 8 +
> drivers/auxdisplay/Makefile | 1 +
> drivers/auxdisplay/sensehat-display.c | 205 ++++++++++++++++++
> drivers/mfd/simple-mfd-i2c.c | 1 +
> sensehat.dtbs | 52 +++++
> 9 files changed, 391 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/auxdisplay/raspberrypi,sensehat-display.yaml
> create mode 100644 Documentation/devicetree/bindings/input/raspberrypi,sensehat-joystick.yaml
> create mode 100644 Documentation/devicetree/bindings/mfd/raspberrypi,sensehat.yaml
> create mode 100644 drivers/auxdisplay/sensehat-display.c
> create mode 100644 sensehat.dtbs
>
next prev parent reply other threads:[~2022-08-24 11:30 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 17:41 [PATCH v10 0/6] Raspberry Pi Sense HAT driver Charles Mirabile
2022-08-23 17:41 ` Charles Mirabile
2022-08-23 17:41 ` [PATCH 1/5] drivers/mfd: sensehat: Add Raspberry Pi Sense HAT to simple_mfd_i2c Charles Mirabile
2022-08-23 17:41 ` Charles Mirabile
2022-09-05 13:58 ` Lee Jones
2022-09-05 13:58 ` Lee Jones
2022-09-06 2:28 ` Bagas Sanjaya
2022-09-06 2:28 ` Bagas Sanjaya
2022-08-23 17:41 ` [PATCH 2/5] drivers/auxdisplay: sensehat: Raspberry Pi Sense HAT display driver Charles Mirabile
2022-08-23 17:41 ` Charles Mirabile
2022-08-24 11:26 ` Matthias Brugger
2022-08-24 11:26 ` Matthias Brugger
2022-09-06 2:31 ` Bagas Sanjaya
2022-09-06 2:31 ` Bagas Sanjaya
2022-09-08 15:26 ` Wander Lairson Costa
2022-09-08 15:26 ` Wander Lairson Costa
2022-08-23 17:41 ` [PATCH 3/5] dt-bindings: mfd: sensehat: Add Raspberry Pi Sense HAT schema Charles Mirabile
2022-08-23 17:41 ` Charles Mirabile
2022-08-24 12:13 ` Matthias Brugger
2022-08-24 12:13 ` Matthias Brugger
2022-09-06 2:47 ` Bagas Sanjaya
2022-09-06 2:47 ` Bagas Sanjaya
2022-08-23 17:41 ` [PATCH 4/5] MAINTAINERS: Add sensehat driver authors to MAINTAINERS Charles Mirabile
2022-08-23 17:41 ` Charles Mirabile
2022-09-06 2:48 ` Bagas Sanjaya
2022-09-06 2:48 ` Bagas Sanjaya
2022-08-23 17:41 ` [PATCH 5/5] DO NOT MERGE: full sensehat device tree overlay for raspberry pi 4 Charles Mirabile
2022-08-23 17:41 ` Charles Mirabile
2022-09-06 2:52 ` Bagas Sanjaya
2022-09-06 2:52 ` Bagas Sanjaya
2022-09-06 10:52 ` Matthias Brugger
2022-09-06 10:52 ` Matthias Brugger
2022-08-23 21:30 ` [PATCH v10 0/6] Raspberry Pi Sense HAT driver Stefan Wahren
2022-08-23 21:30 ` Stefan Wahren
2022-08-24 12:06 ` Charles Mirabile
2022-08-24 12:06 ` Charles Mirabile
2022-08-24 15:30 ` Maxime Ripard
2022-08-24 15:30 ` Maxime Ripard
2022-08-24 18:21 ` Stefan Wahren
2022-08-24 18:21 ` Stefan Wahren
2022-08-24 11:28 ` Matthias Brugger [this message]
2022-08-24 11:28 ` Matthias Brugger
2022-08-24 12:17 ` Charles Mirabile
2022-08-24 12:17 ` Charles Mirabile
2022-09-06 2:21 ` Bagas Sanjaya
2022-09-06 2:21 ` Bagas Sanjaya
2022-09-06 10:53 ` Matthias Brugger
2022-09-06 10:53 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=369a74dd-e357-a352-fb17-fa5aa3726e0e@suse.com \
--to=mbrugger@suse.com \
--cc=cmirabil@redhat.com \
--cc=jsavitz@redhat.com \
--cc=jslebodn@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nicolassaenzj@gmail.com \
--cc=pbrobinson@gmail.com \
--cc=rh-kdlp@googlegroups.com \
--cc=serge@raspberrypi.org \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.