All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Charles Mirabile <cmirabil@redhat.com>
Cc: linux-kernel@vger.kernel.org,
	Peter Robinson <pbrobinson@gmail.com>,
	Serge Schneider <serge@raspberrypi.org>,
	Stefan Wahren <stefan.wahren@i2se.com>,
	Nicolas Saenz Julienne <nicolassaenzj@gmail.com>,
	Mattias Brugger <mbrugger@suse.com>,
	linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, rh-kdlp@googlegroups.com,
	Joel Slebodnick <jslebodn@redhat.com>,
	Joel Savitz <jsavitz@redhat.com>
Subject: Re: [PATCH v10 0/6] Raspberry Pi Sense HAT driver
Date: Tue, 6 Sep 2022 09:21:11 +0700	[thread overview]
Message-ID: <Yxaul73DR7BVT7/C@debian.me> (raw)
In-Reply-To: <20220823174158.45579-1-cmirabil@redhat.com>


[-- Attachment #1.1: Type: text/plain, Size: 1093 bytes --]

On Tue, Aug 23, 2022 at 01:41:53PM -0400, Charles Mirabile wrote:
> This patch series adds a set of drivers for operating the Sense HAT
> peripheral device. This board is an add on for the Raspberry Pi that is
> designed to connect using the GPIO connector and communicate via I2C.
> 

Better say "Add a set of drivers for Sense HAT peripheral add-on device
for Raspberry Pi. The device is connected using GPIO connector and
communicate via I2C".

> This is a refactor of the work of Serge Schneider, the author of a
> version of this driver that is currently in the Raspberry Pi downstream
> kernel. We modified his code to make it suitable for upstream Linux.
> 

s/We modified his code/The driver code is modified/

Also, I see that description of individual patches is written in
descriptive mood. However, it is preferable to write in imperative
instead (see "Describe your changes" in
Documentation/process/submitting-patches.rst). The specific suggested
wordings are in reply to each patch.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Charles Mirabile <cmirabil@redhat.com>
Cc: linux-kernel@vger.kernel.org,
	Peter Robinson <pbrobinson@gmail.com>,
	Serge Schneider <serge@raspberrypi.org>,
	Stefan Wahren <stefan.wahren@i2se.com>,
	Nicolas Saenz Julienne <nicolassaenzj@gmail.com>,
	Mattias Brugger <mbrugger@suse.com>,
	linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, rh-kdlp@googlegroups.com,
	Joel Slebodnick <jslebodn@redhat.com>,
	Joel Savitz <jsavitz@redhat.com>
Subject: Re: [PATCH v10 0/6] Raspberry Pi Sense HAT driver
Date: Tue, 6 Sep 2022 09:21:11 +0700	[thread overview]
Message-ID: <Yxaul73DR7BVT7/C@debian.me> (raw)
In-Reply-To: <20220823174158.45579-1-cmirabil@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1093 bytes --]

On Tue, Aug 23, 2022 at 01:41:53PM -0400, Charles Mirabile wrote:
> This patch series adds a set of drivers for operating the Sense HAT
> peripheral device. This board is an add on for the Raspberry Pi that is
> designed to connect using the GPIO connector and communicate via I2C.
> 

Better say "Add a set of drivers for Sense HAT peripheral add-on device
for Raspberry Pi. The device is connected using GPIO connector and
communicate via I2C".

> This is a refactor of the work of Serge Schneider, the author of a
> version of this driver that is currently in the Raspberry Pi downstream
> kernel. We modified his code to make it suitable for upstream Linux.
> 

s/We modified his code/The driver code is modified/

Also, I see that description of individual patches is written in
descriptive mood. However, it is preferable to write in imperative
instead (see "Describe your changes" in
Documentation/process/submitting-patches.rst). The specific suggested
wordings are in reply to each patch.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  parent reply	other threads:[~2022-09-06  2:22 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-23 17:41 [PATCH v10 0/6] Raspberry Pi Sense HAT driver Charles Mirabile
2022-08-23 17:41 ` Charles Mirabile
2022-08-23 17:41 ` [PATCH 1/5] drivers/mfd: sensehat: Add Raspberry Pi Sense HAT to simple_mfd_i2c Charles Mirabile
2022-08-23 17:41   ` Charles Mirabile
2022-09-05 13:58   ` Lee Jones
2022-09-05 13:58     ` Lee Jones
2022-09-06  2:28   ` Bagas Sanjaya
2022-09-06  2:28     ` Bagas Sanjaya
2022-08-23 17:41 ` [PATCH 2/5] drivers/auxdisplay: sensehat: Raspberry Pi Sense HAT display driver Charles Mirabile
2022-08-23 17:41   ` Charles Mirabile
2022-08-24 11:26   ` Matthias Brugger
2022-08-24 11:26     ` Matthias Brugger
2022-09-06  2:31   ` Bagas Sanjaya
2022-09-06  2:31     ` Bagas Sanjaya
2022-09-08 15:26   ` Wander Lairson Costa
2022-09-08 15:26     ` Wander Lairson Costa
2022-08-23 17:41 ` [PATCH 3/5] dt-bindings: mfd: sensehat: Add Raspberry Pi Sense HAT schema Charles Mirabile
2022-08-23 17:41   ` Charles Mirabile
2022-08-24 12:13   ` Matthias Brugger
2022-08-24 12:13     ` Matthias Brugger
2022-09-06  2:47   ` Bagas Sanjaya
2022-09-06  2:47     ` Bagas Sanjaya
2022-08-23 17:41 ` [PATCH 4/5] MAINTAINERS: Add sensehat driver authors to MAINTAINERS Charles Mirabile
2022-08-23 17:41   ` Charles Mirabile
2022-09-06  2:48   ` Bagas Sanjaya
2022-09-06  2:48     ` Bagas Sanjaya
2022-08-23 17:41 ` [PATCH 5/5] DO NOT MERGE: full sensehat device tree overlay for raspberry pi 4 Charles Mirabile
2022-08-23 17:41   ` Charles Mirabile
2022-09-06  2:52   ` Bagas Sanjaya
2022-09-06  2:52     ` Bagas Sanjaya
2022-09-06 10:52     ` Matthias Brugger
2022-09-06 10:52       ` Matthias Brugger
2022-08-23 21:30 ` [PATCH v10 0/6] Raspberry Pi Sense HAT driver Stefan Wahren
2022-08-23 21:30   ` Stefan Wahren
2022-08-24 12:06   ` Charles Mirabile
2022-08-24 12:06     ` Charles Mirabile
2022-08-24 15:30     ` Maxime Ripard
2022-08-24 15:30       ` Maxime Ripard
2022-08-24 18:21     ` Stefan Wahren
2022-08-24 18:21       ` Stefan Wahren
2022-08-24 11:28 ` Matthias Brugger
2022-08-24 11:28   ` Matthias Brugger
2022-08-24 12:17   ` Charles Mirabile
2022-08-24 12:17     ` Charles Mirabile
2022-09-06  2:21 ` Bagas Sanjaya [this message]
2022-09-06  2:21   ` Bagas Sanjaya
2022-09-06 10:53   ` Matthias Brugger
2022-09-06 10:53     ` Matthias Brugger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yxaul73DR7BVT7/C@debian.me \
    --to=bagasdotme@gmail.com \
    --cc=cmirabil@redhat.com \
    --cc=jsavitz@redhat.com \
    --cc=jslebodn@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=mbrugger@suse.com \
    --cc=nicolassaenzj@gmail.com \
    --cc=pbrobinson@gmail.com \
    --cc=rh-kdlp@googlegroups.com \
    --cc=serge@raspberrypi.org \
    --cc=stefan.wahren@i2se.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.