All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: Chukun Pan <amadeus@jmu.edu.cn>,
	Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: rockchip: enable saradc for ArmSoM Sige5
Date: Mon, 22 Dec 2025 14:39:49 +0100	[thread overview]
Message-ID: <3767252.NG923GbCHz@phil> (raw)
In-Reply-To: <aUlHa-QhCLOk8AGa@venus>

Am Montag, 22. Dezember 2025, 14:32:53 Mitteleuropäische Normalzeit schrieb Sebastian Reichel:
> Hi,
> 
> On Sat, Dec 20, 2025 at 06:00:10PM +0800, Chukun Pan wrote:
> > Add ADC support to ArmSoM Sige5 board.
> > 
> > Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> > ---
> 
> The reference voltage is different between the different board
> revisions. Older boards (1.1 and 1.2) have SARADC_AVDD1V8 connected
> to &vcca_1v8_s0, but newer boards (1.3) use VCCA1V8_PLDO2_S0
> instead. I guess considering &vcca1v8_pldo2_s0 is marked as always
> on, we can ignore this difference, but I think it's worth a comment
> in the DT and the commit description. Otherwise:
> 
> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>

darn, too late for this one - should've waited longer for
this possible Rb :-) ... I did add the others before pushing
though.


Heiko




WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Chukun Pan <amadeus@jmu.edu.cn>,
	Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: rockchip: enable saradc for ArmSoM Sige5
Date: Mon, 22 Dec 2025 14:39:49 +0100	[thread overview]
Message-ID: <3767252.NG923GbCHz@phil> (raw)
In-Reply-To: <aUlHa-QhCLOk8AGa@venus>

Am Montag, 22. Dezember 2025, 14:32:53 Mitteleuropäische Normalzeit schrieb Sebastian Reichel:
> Hi,
> 
> On Sat, Dec 20, 2025 at 06:00:10PM +0800, Chukun Pan wrote:
> > Add ADC support to ArmSoM Sige5 board.
> > 
> > Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> > ---
> 
> The reference voltage is different between the different board
> revisions. Older boards (1.1 and 1.2) have SARADC_AVDD1V8 connected
> to &vcca_1v8_s0, but newer boards (1.3) use VCCA1V8_PLDO2_S0
> instead. I guess considering &vcca1v8_pldo2_s0 is marked as always
> on, we can ignore this difference, but I think it's worth a comment
> in the DT and the commit description. Otherwise:
> 
> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>

darn, too late for this one - should've waited longer for
this possible Rb :-) ... I did add the others before pushing
though.


Heiko



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2025-12-22 13:40 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-20 10:00 [PATCH 1/3] arm64: dts: rockchip: remove rtc regulator for ArmSoM Sige5 Chukun Pan
2025-12-20 10:00 ` Chukun Pan
2025-12-20 10:00 ` [PATCH 2/3] arm64: dts: rockchip: fix hp-det pin " Chukun Pan
2025-12-20 10:00   ` Chukun Pan
2025-12-22 13:28   ` Sebastian Reichel
2025-12-22 13:28     ` Sebastian Reichel
2025-12-20 10:00 ` [PATCH 3/3] arm64: dts: rockchip: enable saradc " Chukun Pan
2025-12-20 10:00   ` Chukun Pan
2025-12-22 13:32   ` Sebastian Reichel
2025-12-22 13:32     ` Sebastian Reichel
2025-12-22 13:39     ` Heiko Stuebner [this message]
2025-12-22 13:39       ` Heiko Stuebner
2025-12-22 13:24 ` [PATCH 1/3] arm64: dts: rockchip: remove rtc regulator " Sebastian Reichel
2025-12-22 13:24   ` Sebastian Reichel
2025-12-22 13:38 ` Heiko Stuebner
2025-12-22 13:38   ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3767252.NG923GbCHz@phil \
    --to=heiko@sntech.de \
    --cc=amadeus@jmu.edu.cn \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh@kernel.org \
    --cc=sebastian.reichel@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.