Re: [PATCH 3/3] arm64: dts: rockchip: enable saradc for ArmSoM Sige5

From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Chukun Pan <amadeus@jmu.edu.cn>
Cc: Heiko Stuebner <heiko@sntech.de>, Rob Herring <robh@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	 devicetree@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: rockchip: enable saradc for ArmSoM Sige5
Date: Mon, 22 Dec 2025 14:32:53 +0100	[thread overview]
Message-ID: <aUlHa-QhCLOk8AGa@venus> (raw)
In-Reply-To: <20251220100010.26643-3-amadeus@jmu.edu.cn>

[-- Attachment #1: Type: text/plain, Size: 1280 bytes --]

Hi,

On Sat, Dec 20, 2025 at 06:00:10PM +0800, Chukun Pan wrote:
> Add ADC support to ArmSoM Sige5 board.
> 
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> ---

The reference voltage is different between the different board
revisions. Older boards (1.1 and 1.2) have SARADC_AVDD1V8 connected
to &vcca_1v8_s0, but newer boards (1.3) use VCCA1V8_PLDO2_S0
instead. I guess considering &vcca1v8_pldo2_s0 is marked as always
on, we can ignore this difference, but I think it's worth a comment
in the DT and the commit description. Otherwise:

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>

-- Sebastian

>  arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts b/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
> index a0d8f52a706f..d372ba252af8 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
> @@ -897,6 +897,11 @@ &sai6 {
>  	status = "okay";
>  };
>  
> +&saradc {
> +	vref-supply = <&vcca_1v8_s0>;
> +	status = "okay";
> +};
> +
>  &sdhci {
>  	bus-width = <8>;
>  	full-pwr-cycle-in-suspend;
> -- 
> 2.25.1
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]