Re: [lm-sensors] [PATCH] hwmon: add Maxim MAX197 support

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: lm-sensors@lm-sensors.org, Jean Delvare <khali@linux-fr.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] hwmon: add Maxim MAX197 support
Date: Thu, 30 Aug 2012 21:22:02 +0000	[thread overview]
Message-ID: <378258773.403150.1346361722651.JavaMail.root@mail.savoirfairelinux.com> (raw)
In-Reply-To: <20120830211444.GA11181@roeck-us.net>
In-Reply-To: <1346351995-9038-1-git-send-email-vivien.didelot@savoirfairelinux.com>

SSBndWVzcyB3ZSdyZSB0b28gZmFzdCEKCkkndmUganVzdCBzZWVuIHlvdXIgcmVwbHksIHRoaXMg
aXMgbXVjaCBjbGVhbmVyLCBpbmRlZWQuCkknbGwgdXBkYXRlIHRoZSBtYXgxOTcgZHJpdmVyLCBh
bmQgZml4IHRoZSBzaHQxNSBkcml2ZXIgYXMgc29vbiBhcyBJIGNhbi4KClRoYW5rcywKVml2aWVu
CgotLS0tLSBNYWlsIG9yaWdpbmFsIC0tLS0tCkRlOiAiR3VlbnRlciBSb2VjayIgPGxpbnV4QHJv
ZWNrLXVzLm5ldD4Kw4A6ICJWaXZpZW4gRGlkZWxvdCIgPHZpdmllbi5kaWRlbG90QHNhdm9pcmZh
aXJlbGludXguY29tPgpDYzogbG0tc2Vuc29yc0BsbS1zZW5zb3JzLm9yZywgIkplYW4gRGVsdmFy
ZSIgPGtoYWxpQGxpbnV4LWZyLm9yZz4sIGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmcKRW52
b3nDqTogSmV1ZGkgMzAgQW/Du3QgMjAxMiAxNzoxNDo0NApPYmpldDogUmU6IFtQQVRDSF0gaHdt
b246IGFkZCBNYXhpbSBNQVgxOTcgc3VwcG9ydAoKT24gVGh1LCBBdWcgMzAsIDIwMTIgYXQgMDU6
MTA6MzJQTSAtMDQwMCwgVml2aWVuIERpZGVsb3Qgd3JvdGU6Cj4gSGkgR3VlbnRlciwKPiAKPiBU
aGFua3MgZm9yIHlvdXIgZGV0YWlsZWQgY29tbWVudHMuIEknbGwgc2VuZCBhIG5ldyB2ZXJzaW9u
IHNvb24uCj4gCj4gQWJvdXQgdGhlIGZvbGxvd2luZyBjb21tZW50LCBJIGFncmVlIHdpdGggeW91
LiBIb3dldmVyIGFzIHRoZXJlIGlzIG5vIGNvbnZlbnRpb24gZm9yIHRoaXMgY2FzZSwgZm9yIG5v
dyBJIHdvdWxkIHByZWZlciB0byBzdGljayB3aXRoIHRoZSBtb2RlbCBhcyBzZWVuIGluIGRyaXZl
cnMgc3VjaCBhcyBzaHQxNS4KPiAKQWN0dWFsbHksIHRoZXJlIGlzIGEgY29udmVudGlvbiwgYW5k
IGl0IGlzIG11Y2ggY2xlYW5lciB0aGFuIHVzaW5nCm11bHRpcGxlIHBsYXRmb3JtIGRyaXZlciBp
bnN0YW5jZXMuIEkgc2VudCB5b3UgYSBzZXBhcmF0ZSBlLW1haWwgYQptaW51dGUgYWdvLCBkZXNj
cmliaW5nIGhvdyBpdCB3b3Jrcy4KCldlIHNob3VsZCBhY3R1YWxseSBmaXggdGhlIHNodDE1IGRy
aXZlciBhcyB3ZWxsIHRvIHVzZSB0aGUgc2FtZSBhcHByb2FjaC4KClRoYW5rcywKR3VlbnRlcgoK
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbG0tc2Vuc29y
cyBtYWlsaW5nIGxpc3QKbG0tc2Vuc29yc0BsbS1zZW5zb3JzLm9yZwpodHRwOi8vbGlzdHMubG0t
c2Vuc29ycy5vcmcvbWFpbG1hbi9saXN0aW5mby9sbS1zZW5zb3Jz

WARNING: multiple messages have this Message-ID (diff)

From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: lm-sensors@lm-sensors.org, Jean Delvare <khali@linux-fr.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: add Maxim MAX197 support
Date: Thu, 30 Aug 2012 17:22:02 -0400 (EDT)	[thread overview]
Message-ID: <378258773.403150.1346361722651.JavaMail.root@mail.savoirfairelinux.com> (raw)
In-Reply-To: <20120830211444.GA11181@roeck-us.net>

I guess we're too fast!

I've just seen your reply, this is much cleaner, indeed.
I'll update the max197 driver, and fix the sht15 driver as soon as I can.

Thanks,
Vivien

----- Mail original -----
De: "Guenter Roeck" <linux@roeck-us.net>
À: "Vivien Didelot" <vivien.didelot@savoirfairelinux.com>
Cc: lm-sensors@lm-sensors.org, "Jean Delvare" <khali@linux-fr.org>, linux-kernel@vger.kernel.org
Envoyé: Jeudi 30 Août 2012 17:14:44
Objet: Re: [PATCH] hwmon: add Maxim MAX197 support

On Thu, Aug 30, 2012 at 05:10:32PM -0400, Vivien Didelot wrote:
> Hi Guenter,
> 
> Thanks for your detailed comments. I'll send a new version soon.
> 
> About the following comment, I agree with you. However as there is no convention for this case, for now I would prefer to stick with the model as seen in drivers such as sht15.
> 
Actually, there is a convention, and it is much cleaner than using
multiple platform driver instances. I sent you a separate e-mail a
minute ago, describing how it works.

We should actually fix the sht15 driver as well to use the same approach.

Thanks,
Guenter

next prev parent reply	other threads:[~2012-08-30 21:22 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-30 18:39 [lm-sensors] [PATCH] hwmon: add Maxim MAX197 support Vivien Didelot
2012-08-30 18:39 ` Vivien Didelot
2012-08-30 20:10 ` [lm-sensors] " Guenter Roeck
2012-08-30 20:10   ` Guenter Roeck
2012-08-30 21:09 ` [lm-sensors] " Guenter Roeck
2012-08-30 21:09   ` Guenter Roeck
2012-08-31 14:37   ` [lm-sensors] " Jean Delvare
2012-08-31 14:37     ` Jean Delvare
2012-08-31 16:07     ` [lm-sensors] " Guenter Roeck
2012-08-31 16:07       ` Guenter Roeck
2012-08-30 21:10 ` [lm-sensors] " Vivien Didelot
2012-08-30 21:10   ` Vivien Didelot
2012-08-30 21:14   ` [lm-sensors] " Guenter Roeck
2012-08-30 21:14     ` Guenter Roeck
2012-08-30 21:22 ` Vivien Didelot [this message]
2012-08-30 21:22   ` Vivien Didelot
2012-08-30 21:25   ` [lm-sensors] " Guenter Roeck
2012-08-30 21:25     ` Guenter Roeck
2012-08-31 17:38 ` [lm-sensors] " Vivien Didelot
2012-08-31 17:38   ` Vivien Didelot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=378258773.403150.1346361722651.JavaMail.root@mail.savoirfairelinux.com \
    --to=vivien.didelot@savoirfairelinux.com \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lm-sensors@lm-sensors.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.