Re: [PATCH 1/5] pinctrl: r7s72100: add riic groups

[Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>]

Hi Wolfram,

Thank you for the patch.

On Tuesday 17 December 2013 22:44:34 Wolfram Sang wrote:
> From: Wolfram Sang <wsa-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org>
> 
> Tested RIIC2 on a genmai board. Other riic groups are untested but seem
> trivial enough to be added.
> 
> Signed-off-by: Wolfram Sang <wsa-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org>
> Acked-by: Magnus Damm <damm-yzvPICuk2ACczHhG9Qg4qA@public.gmane.org>
> ---
> 
> Note: With the current PFC driver as posted by Magnus, it needs another
> patch to work. Yet, I think this is a seperate PFC issue which needs to be
> sorted out seperately and shouldn't affect these declarations. I'll add the
> needed patch as a response to this mail.
> 
>  drivers/pinctrl/sh-pfc/pfc-r7s72100.c | 45 ++++++++++++++++++++++++++++++++
>  1 file changed, 45 insertions(+)
> 
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r7s72100.c
> b/drivers/pinctrl/sh-pfc/pfc-r7s72100.c index a662876..2b716d1 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r7s72100.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r7s72100.c
> @@ -229,6 +229,27 @@ SCIF5(RZ_PIN_AND_MUX)
>  SCIF6(RZ_PIN_AND_MUX)
>  SCIF7(RZ_PIN_AND_MUX)
> 
> +#define RIIC0(fn)			\
> +	fn(riic0, scl, 1, 0, 1)		\
> +	fn(riic0, sda, 1, 1, 1)
> +
> +#define RIIC1(fn)			\
> +	fn(riic1, scl, 1, 2, 1)		\
> +	fn(riic1, sda, 1, 3, 1)
> +
> +#define RIIC2(fn)			\
> +	fn(riic2, scl, 1, 4, 1)		\
> +	fn(riic2, sda, 1, 5, 1)
> +
> +#define RIIC3(fn)			\
> +	fn(riic3, scl, 1, 6, 1)		\
> +	fn(riic3, sda, 1, 7, 1)
> +
> +RIIC0(RZ_PIN_AND_MUX)
> +RIIC1(RZ_PIN_AND_MUX)
> +RIIC2(RZ_PIN_AND_MUX)
> +RIIC3(RZ_PIN_AND_MUX)

Could you please move this above the SCIF declarations (same comment below) ? 
The pfc-*.c files tend to grow pretty big, and keeping entries sorted 
alphabetically helps.

> +
>  static const struct sh_pfc_pin_group pinmux_groups[] = {
>  	SCIF0(RZ_PMX_GROUP)
>  	SCIF1(RZ_PMX_GROUP)
> @@ -238,6 +259,10 @@ static const struct sh_pfc_pin_group pinmux_groups[] =
> { SCIF5(RZ_PMX_GROUP)
>  	SCIF6(RZ_PMX_GROUP)
>  	SCIF7(RZ_PMX_GROUP)
> +	RIIC0(RZ_PMX_GROUP)
> +	RIIC1(RZ_PMX_GROUP)
> +	RIIC2(RZ_PMX_GROUP)
> +	RIIC3(RZ_PMX_GROUP)
>  };
> 
>  static const char * const scif0_groups[] = {
> @@ -272,6 +297,22 @@ static const char * const scif7_groups[] = {
>  	SCIF7(RZ_GROUPS)
>  };
> 
> +static const char * const riic0_groups[] = {
> +	RIIC0(RZ_GROUPS)
> +};
> +
> +static const char * const riic1_groups[] = {
> +	RIIC1(RZ_GROUPS)
> +};
> +
> +static const char * const riic2_groups[] = {
> +	RIIC2(RZ_GROUPS)
> +};
> +
> +static const char * const riic3_groups[] = {
> +	RIIC3(RZ_GROUPS)
> +};
> +
>  static const struct sh_pfc_function pinmux_functions[] = {
>  	SH_PFC_FUNCTION(scif0),
>  	SH_PFC_FUNCTION(scif1),
> @@ -281,6 +322,10 @@ static const struct sh_pfc_function pinmux_functions[]
> = { SH_PFC_FUNCTION(scif5),
>  	SH_PFC_FUNCTION(scif6),
>  	SH_PFC_FUNCTION(scif7),
> +	SH_PFC_FUNCTION(riic0),
> +	SH_PFC_FUNCTION(riic1),
> +	SH_PFC_FUNCTION(riic2),
> +	SH_PFC_FUNCTION(riic3),
>  };
> 
>  #define PFC_REG(idx, name, reg)						\
-- 
Regards,

Laurent Pinchart