Re: [PATCH 4/5] arm: shmobile: genmai: adapt dts to use native i2c driver

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

On 18-12-2013 1:44, Wolfram Sang wrote:

> From: Wolfram Sang <wsa@sang-engineering.com>

> Switch from the gpio-driver to the shiny new native driver. Tested by
> accessing the eeprom on the genmai board.

> Signed-off-by: Wolfram Sang <wsa@sang-engineering.com>
> Acked-by: Magnus Damm <damm@opensource.se>
> ---
>   arch/arm/boot/dts/r7s72100-genmai-reference.dts | 29 ++++++++++---------------
>   1 file changed, 11 insertions(+), 18 deletions(-)

> diff --git a/arch/arm/boot/dts/r7s72100-genmai-reference.dts b/arch/arm/boot/dts/r7s72100-genmai-reference.dts
> index ce5da0b..739448a 100644
> --- a/arch/arm/boot/dts/r7s72100-genmai-reference.dts
> +++ b/arch/arm/boot/dts/r7s72100-genmai-reference.dts
> @@ -39,24 +39,6 @@
>   			gpios = <&port4 11 GPIO_ACTIVE_LOW>;
>   		};
>   	};
> -
> -	i2c@0 {
> -		compatible = "i2c-gpio";
> -		gpios = <&port1 5 GPIO_ACTIVE_HIGH /* sda */
> -			 &port1 4 GPIO_ACTIVE_HIGH /* scl */
> -			>;
> -		i2c-gpio,sda-open-drain;
> -		i2c-gpio,scl-open-drain;
> -		i2c-gpio,delay-us = <5>;	/* ~100 kHz */
> -		#address-cells = <1>;
> -		#size-cells = <0>;
> -
> -		flash@50 {
> -			compatible = "renesas,24c128";
> -			reg = <0x50>;
> -			pagesize = <64>;
> -		};
> -	};
>   };
>
>   &pfc {
> @@ -68,3 +50,14 @@
>   		renesas,function = "scif2";
>   	};
>   };
> +
> +&i2c2 {
> +	status = "okay";
> +	clock-frequency = <400000>;
> +
> +	eeprom: 24c128@50 {

    The node was called "flash@50" for a reason: according to ePAPR spec,  for 
node names the generic device names should be used, not chip-specific.

> +		compatible = "renesas,24c128";
> +		reg = <0x50>;
> +		pagesize = <64>;
> +	};
> +};

WBR, Sergei