* [PATCH v2] target/i386: Add ARCH_CAPABILITIES related bits into Icelake-Server CPU model
@ 2020-03-16 9:56 Xiaoyao Li
2020-03-23 2:32 ` Tao Xu
0 siblings, 1 reply; 5+ messages in thread
From: Xiaoyao Li @ 2020-03-16 9:56 UTC (permalink / raw)
To: Paolo Bonzini, Richard Henderson, Eduardo Habkost; +Cc: Xiaoyao Li, qemu-devel
Current Icelake-Server CPU model lacks all the features enumerated by
MSR_IA32_ARCH_CAPABILITIES.
Add them, so that guest of "Icelake-Server" can see all of them.
Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
---
v2:
- Add it as a new version.
---
target/i386/cpu.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 92fafa265914..5fba6a2ad6b3 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -3496,6 +3496,19 @@ static X86CPUDefinition builtin_x86_defs[] = {
{ /* end of list */ }
},
},
+ {
+ .version = 3,
+ .props = (PropValue[]) {
+ { "arch-capabilities", "on" },
+ { "rdctl-no", "on" },
+ { "ibrs-all", "on" },
+ { "skip-l1dfl-vmentry", "on" },
+ { "mds-no", "on" },
+ { "pschange-mc-no", "on" },
+ { "taa-no", "on" },
+ { /* end of list */ }
+ },
+ },
{ /* end of list */ }
}
},
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] target/i386: Add ARCH_CAPABILITIES related bits into Icelake-Server CPU model
2020-03-16 9:56 [PATCH v2] target/i386: Add ARCH_CAPABILITIES related bits into Icelake-Server CPU model Xiaoyao Li
@ 2020-03-23 2:32 ` Tao Xu
2020-03-23 2:58 ` Xiaoyao Li
0 siblings, 1 reply; 5+ messages in thread
From: Tao Xu @ 2020-03-23 2:32 UTC (permalink / raw)
To: Xiaoyao Li, Eduardo Habkost
Cc: Paolo Bonzini, qemu-devel@nongnu.org, Richard Henderson
Hi Xiaoyao,
May be you can add .note for this new version.
for example:
+ .version = 3,
+ .note = "ARCH_CAPABILITIES",
+ .props = (PropValue[]) {
On 3/16/2020 5:56 PM, Xiaoyao Li wrote:
> Current Icelake-Server CPU model lacks all the features enumerated by
> MSR_IA32_ARCH_CAPABILITIES.
>
> Add them, so that guest of "Icelake-Server" can see all of them.
>
> Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
> ---
> v2:
> - Add it as a new version.
> ---
> target/i386/cpu.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index 92fafa265914..5fba6a2ad6b3 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -3496,6 +3496,19 @@ static X86CPUDefinition builtin_x86_defs[] = {
> { /* end of list */ }
> },
> },
> + {
> + .version = 3,
> + .props = (PropValue[]) {
> + { "arch-capabilities", "on" },
> + { "rdctl-no", "on" },
> + { "ibrs-all", "on" },
> + { "skip-l1dfl-vmentry", "on" },
> + { "mds-no", "on" },
> + { "pschange-mc-no", "on" },
> + { "taa-no", "on" },
> + { /* end of list */ }
> + },
> + },
> { /* end of list */ }
> }
> },
> --
> 2.20.1
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] target/i386: Add ARCH_CAPABILITIES related bits into Icelake-Server CPU model
2020-03-23 2:32 ` Tao Xu
@ 2020-03-23 2:58 ` Xiaoyao Li
2020-03-23 18:39 ` Eduardo Habkost
0 siblings, 1 reply; 5+ messages in thread
From: Xiaoyao Li @ 2020-03-23 2:58 UTC (permalink / raw)
To: Eduardo Habkost, Paolo Bonzini
Cc: Tao Xu, qemu-devel@nongnu.org, Richard Henderson
On 3/23/2020 10:32 AM, Tao Xu wrote:
> Hi Xiaoyao,
>
> May be you can add .note for this new version.
>
> for example:
>
> + .version = 3,
> + .note = "ARCH_CAPABILITIES",
> + .props = (PropValue[]) {
Hi Paolo and Eduardo,
Need I spin a new version to add the .note ?
Maybe you can add it when queue?
Thanks,
-Xiaoyao
> On 3/16/2020 5:56 PM, Xiaoyao Li wrote:
>> Current Icelake-Server CPU model lacks all the features enumerated by
>> MSR_IA32_ARCH_CAPABILITIES.
>>
>> Add them, so that guest of "Icelake-Server" can see all of them.
>>
>> Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
>> ---
>> v2:
>> - Add it as a new version.
>> ---
>> target/i386/cpu.c | 13 +++++++++++++
>> 1 file changed, 13 insertions(+)
>>
>> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
>> index 92fafa265914..5fba6a2ad6b3 100644
>> --- a/target/i386/cpu.c
>> +++ b/target/i386/cpu.c
>> @@ -3496,6 +3496,19 @@ static X86CPUDefinition builtin_x86_defs[] = {
>> { /* end of list */ }
>> },
>> },
>> + {
>> + .version = 3,
>> + .props = (PropValue[]) {
>> + { "arch-capabilities", "on" },
>> + { "rdctl-no", "on" },
>> + { "ibrs-all", "on" },
>> + { "skip-l1dfl-vmentry", "on" },
>> + { "mds-no", "on" },
>> + { "pschange-mc-no", "on" },
>> + { "taa-no", "on" },
>> + { /* end of list */ }
>> + },
>> + },
>> { /* end of list */ }
>> }
>> },
>> --
>> 2.20.1
>>
>>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] target/i386: Add ARCH_CAPABILITIES related bits into Icelake-Server CPU model
2020-03-23 2:58 ` Xiaoyao Li
@ 2020-03-23 18:39 ` Eduardo Habkost
2020-03-24 0:23 ` Tao Xu
0 siblings, 1 reply; 5+ messages in thread
From: Eduardo Habkost @ 2020-03-23 18:39 UTC (permalink / raw)
To: Xiaoyao Li
Cc: Paolo Bonzini, Tao Xu, qemu-devel@nongnu.org, Richard Henderson
On Mon, Mar 23, 2020 at 10:58:16AM +0800, Xiaoyao Li wrote:
> On 3/23/2020 10:32 AM, Tao Xu wrote:
> > Hi Xiaoyao,
> >
> > May be you can add .note for this new version.
> >
> > for example:
> >
> > + .version = 3,
> > + .note = "ARCH_CAPABILITIES",
> > + .props = (PropValue[]) {
>
> Hi Paolo and Eduardo,
>
> Need I spin a new version to add the .note ?
> Maybe you can add it when queue?
Please send a follow up patch so we don't hold a bug fix because
of something that's just cosmetic. I will queue this patch. We
still need a new version of "target/i386: Add notes for versioned
CPU models"[1], don't we?
[1] https://lore.kernel.org/qemu-devel/20200228215253.GB494511@habkost.net/
--
Eduardo
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] target/i386: Add ARCH_CAPABILITIES related bits into Icelake-Server CPU model
2020-03-23 18:39 ` Eduardo Habkost
@ 2020-03-24 0:23 ` Tao Xu
0 siblings, 0 replies; 5+ messages in thread
From: Tao Xu @ 2020-03-24 0:23 UTC (permalink / raw)
To: Eduardo Habkost
Cc: Paolo Bonzini, Li, Xiaoyao, qemu-devel@nongnu.org,
Richard Henderson
On 3/24/2020 2:39 AM, Eduardo Habkost wrote:
> On Mon, Mar 23, 2020 at 10:58:16AM +0800, Xiaoyao Li wrote:
>> On 3/23/2020 10:32 AM, Tao Xu wrote:
>>> Hi Xiaoyao,
>>>
>>> May be you can add .note for this new version.
>>>
>>> for example:
>>>
>>> + .version = 3,
>>> + .note = "ARCH_CAPABILITIES",
>>> + .props = (PropValue[]) {
>>
>> Hi Paolo and Eduardo,
>>
>> Need I spin a new version to add the .note ?
>> Maybe you can add it when queue?
>
> Please send a follow up patch so we don't hold a bug fix because
> of something that's just cosmetic. I will queue this patch. We
> still need a new version of "target/i386: Add notes for versioned
> CPU models"[1], don't we?
>
> [1] https://lore.kernel.org/qemu-devel/20200228215253.GB494511@habkost.net/
>
I am sorry for misunderstanding your comments in that patch[1]. I will
submit a new version of this patch.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-03-24 0:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-16 9:56 [PATCH v2] target/i386: Add ARCH_CAPABILITIES related bits into Icelake-Server CPU model Xiaoyao Li
2020-03-23 2:32 ` Tao Xu
2020-03-23 2:58 ` Xiaoyao Li
2020-03-23 18:39 ` Eduardo Habkost
2020-03-24 0:23 ` Tao Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.