From: "Heiko Stübner" <heiko@sntech.de>
To: Johan Jonker <jbx6244@gmail.com>, Peter Geis <pgwipeout@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
devicetree <devicetree@vger.kernel.org>,
arm-mail-list <linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] arm64: dts: rockchip: add Quartz64-A sdmmc1 node
Date: Thu, 27 Jan 2022 11:15:13 +0100 [thread overview]
Message-ID: <3859424.JUeRptVaKW@diego> (raw)
In-Reply-To: <CAMdYzYrKq==Bs0aonrJBC+W2c4nQ8cUn2dn_Se4WDaRCkT6SYg@mail.gmail.com>
Am Donnerstag, 27. Januar 2022, 10:55:13 CET schrieb Peter Geis:
> On Thu, Jan 27, 2022 at 1:18 AM Johan Jonker <jbx6244@gmail.com> wrote:
> >
> >
> >
> > On 1/27/22 02:00, Peter Geis wrote:
> > > The sdmmc1 node on Quartz64-A supports the optional wifi module from
> > > Pine64.
> > > Add the sdmmc1 node and requisite sdio_pwrseq to enable wifi support on
> > > the Quartz64-A.
> > >
> > > Signed-off-by: Peter Geis <pgwipeout@gmail.com>
> > > ---
> > > .../boot/dts/rockchip/rk3566-quartz64-a.dts | 45 +++++++++++++++++++
> > > 1 file changed, 45 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts
> > > index 33c2c18caaa9..1d73ac6557c5 100644
> > > --- a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts
> > > +++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts
> > > @@ -91,6 +91,18 @@ simple-audio-card,codec {
> > > };
> > > };
> > >
> > > + sdio_pwrseq: sdio-pwrseq {
> >
> > > + status = "okay";
> >
> > When a node is not previously disabled, then there's no need for "okay".
>
> Thanks, this is here in case an end user wants to easily hack the
> board to use this for other purposes.
but please drop it here as well.
A user "hacking" a devicetree should be able to also just _add_
a status "disabled" :-) .
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Johan Jonker <jbx6244@gmail.com>, Peter Geis <pgwipeout@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
devicetree <devicetree@vger.kernel.org>,
arm-mail-list <linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] arm64: dts: rockchip: add Quartz64-A sdmmc1 node
Date: Thu, 27 Jan 2022 11:15:13 +0100 [thread overview]
Message-ID: <3859424.JUeRptVaKW@diego> (raw)
In-Reply-To: <CAMdYzYrKq==Bs0aonrJBC+W2c4nQ8cUn2dn_Se4WDaRCkT6SYg@mail.gmail.com>
Am Donnerstag, 27. Januar 2022, 10:55:13 CET schrieb Peter Geis:
> On Thu, Jan 27, 2022 at 1:18 AM Johan Jonker <jbx6244@gmail.com> wrote:
> >
> >
> >
> > On 1/27/22 02:00, Peter Geis wrote:
> > > The sdmmc1 node on Quartz64-A supports the optional wifi module from
> > > Pine64.
> > > Add the sdmmc1 node and requisite sdio_pwrseq to enable wifi support on
> > > the Quartz64-A.
> > >
> > > Signed-off-by: Peter Geis <pgwipeout@gmail.com>
> > > ---
> > > .../boot/dts/rockchip/rk3566-quartz64-a.dts | 45 +++++++++++++++++++
> > > 1 file changed, 45 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts
> > > index 33c2c18caaa9..1d73ac6557c5 100644
> > > --- a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts
> > > +++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts
> > > @@ -91,6 +91,18 @@ simple-audio-card,codec {
> > > };
> > > };
> > >
> > > + sdio_pwrseq: sdio-pwrseq {
> >
> > > + status = "okay";
> >
> > When a node is not previously disabled, then there's no need for "okay".
>
> Thanks, this is here in case an end user wants to easily hack the
> board to use this for other purposes.
but please drop it here as well.
A user "hacking" a devicetree should be able to also just _add_
a status "disabled" :-) .
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Johan Jonker <jbx6244@gmail.com>, Peter Geis <pgwipeout@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
devicetree <devicetree@vger.kernel.org>,
arm-mail-list <linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] arm64: dts: rockchip: add Quartz64-A sdmmc1 node
Date: Thu, 27 Jan 2022 11:15:13 +0100 [thread overview]
Message-ID: <3859424.JUeRptVaKW@diego> (raw)
In-Reply-To: <CAMdYzYrKq==Bs0aonrJBC+W2c4nQ8cUn2dn_Se4WDaRCkT6SYg@mail.gmail.com>
Am Donnerstag, 27. Januar 2022, 10:55:13 CET schrieb Peter Geis:
> On Thu, Jan 27, 2022 at 1:18 AM Johan Jonker <jbx6244@gmail.com> wrote:
> >
> >
> >
> > On 1/27/22 02:00, Peter Geis wrote:
> > > The sdmmc1 node on Quartz64-A supports the optional wifi module from
> > > Pine64.
> > > Add the sdmmc1 node and requisite sdio_pwrseq to enable wifi support on
> > > the Quartz64-A.
> > >
> > > Signed-off-by: Peter Geis <pgwipeout@gmail.com>
> > > ---
> > > .../boot/dts/rockchip/rk3566-quartz64-a.dts | 45 +++++++++++++++++++
> > > 1 file changed, 45 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts
> > > index 33c2c18caaa9..1d73ac6557c5 100644
> > > --- a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts
> > > +++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts
> > > @@ -91,6 +91,18 @@ simple-audio-card,codec {
> > > };
> > > };
> > >
> > > + sdio_pwrseq: sdio-pwrseq {
> >
> > > + status = "okay";
> >
> > When a node is not previously disabled, then there's no need for "okay".
>
> Thanks, this is here in case an end user wants to easily hack the
> board to use this for other purposes.
but please drop it here as well.
A user "hacking" a devicetree should be able to also just _add_
a status "disabled" :-) .
next prev parent reply other threads:[~2022-01-27 10:16 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 1:00 [PATCH 0/3] Quartz64-A fixes and enablement from 5.17-rc1 Peter Geis
2022-01-27 1:00 ` Peter Geis
2022-01-27 1:00 ` Peter Geis
2022-01-27 1:00 ` [PATCH 1/3] arm64: dts: rockchip: fix Quartz64-A ddr regulator voltage Peter Geis
2022-01-27 1:00 ` Peter Geis
2022-01-27 1:00 ` Peter Geis
2022-01-27 1:00 ` [PATCH 2/3] arm64: dts: rockchip: add Quartz64-A pmu_io_domains Peter Geis
2022-01-27 1:00 ` Peter Geis
2022-01-27 1:00 ` Peter Geis
2022-01-27 5:57 ` Johan Jonker
2022-01-27 5:57 ` Johan Jonker
2022-01-27 5:57 ` Johan Jonker
2022-01-27 9:52 ` Peter Geis
2022-01-27 9:52 ` Peter Geis
2022-01-27 9:52 ` Peter Geis
2022-01-27 1:00 ` [PATCH 3/3] arm64: dts: rockchip: add Quartz64-A sdmmc1 node Peter Geis
2022-01-27 1:00 ` Peter Geis
2022-01-27 1:00 ` Peter Geis
2022-01-27 6:18 ` Johan Jonker
2022-01-27 6:18 ` Johan Jonker
2022-01-27 6:18 ` Johan Jonker
2022-01-27 9:55 ` Peter Geis
2022-01-27 9:55 ` Peter Geis
2022-01-27 9:55 ` Peter Geis
2022-01-27 10:15 ` Heiko Stübner [this message]
2022-01-27 10:15 ` Heiko Stübner
2022-01-27 10:15 ` Heiko Stübner
2022-01-27 23:32 ` Peter Geis
2022-01-27 23:32 ` Peter Geis
2022-01-27 23:32 ` Peter Geis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3859424.JUeRptVaKW@diego \
--to=heiko@sntech.de \
--cc=devicetree@vger.kernel.org \
--cc=jbx6244@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=pgwipeout@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.