From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
To: FUKAUMI Naoki <naoki@radxa.com>, heiko@sntech.de
Cc: michael.opdenacker@rootcommit.com, joseph.kogut@gmail.com,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
quentin.schulz@cherry.de, jonas@kwiboo.se,
kever.yang@rock-chips.com, i@next.chainsx.cn,
honyuenkwun@gmail.com, inindev@gmail.com, dsimic@manjaro.org,
pbrobinson@gmail.com, devicetree@vger.kernel.org,
linux-rockchip@lists.infradead.org
Subject: Re: [RESEND PATCH v5 3/3] arm64: dts: rockchip: Add support for CM5 IO carrier
Date: Tue, 2 Dec 2025 08:30:27 +0000 (UTC) [thread overview]
Message-ID: <39d3d988-f436-4b31-a130-c65dc292c469@rootcommit.com> (raw)
In-Reply-To: <20251202052702.155523-4-naoki@radxa.com>
Hi Naoki,
Thanks for the patch update!
On 12/2/25 06:27, FUKAUMI Naoki wrote:
> From: Joseph Kogut <joseph.kogut@gmail.com>
>
> From: Joseph Kogut <joseph.kogut@gmail.com>
>
> Specification:
> - 1x HDMI
> - 2x MIPI DSI
> - 2x MIPI CSI
> - 1x eDP
> - 1x M.2 E key
> - 1x USB 3.0 Host
> - 1x USB 3.0 OTG
> - 2x USB 2.0 Host
> - Headphone jack w/ microphone
> - Gigabit Ethernet w/ PoE
> - microSD slot
> - 40-pin expansion header
> - 12V DC
>
> Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
> ---
> Rebased on linux-next 20251201, no change.
> ---
> arch/arm64/boot/dts/rockchip/Makefile | 1 +
> .../dts/rockchip/rk3588s-radxa-cm5-io.dts | 486 ++++++++++++++++++
> 2 files changed, 487 insertions(+)
> create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts
>
> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
> index dbdda9783e93..697808b544d8 100644
> --- a/arch/arm64/boot/dts/rockchip/Makefile
> +++ b/arch/arm64/boot/dts/rockchip/Makefile
> @@ -210,6 +210,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-odroid-m2.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-orangepi-5.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-orangepi-5b.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-roc-pc.dtb
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-radxa-cm5-io.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-rock-5a.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-rock-5c.dtb
Small nitpick...
The file names are alphanumerically ordered in this file.
You should have rk3588s-radxa-cm5-io.dtb before rk3588s-roc-pc.dtb.
Cheers
Michael.
--
Michael Opdenacker
Root Commit
Yocto Project and OpenEmbedded Training course - Learn by doing:
https://rootcommit.com/training/yocto/
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
To: FUKAUMI Naoki <naoki@radxa.com>, heiko@sntech.de
Cc: michael.opdenacker@rootcommit.com, joseph.kogut@gmail.com,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
quentin.schulz@cherry.de, jonas@kwiboo.se,
kever.yang@rock-chips.com, i@next.chainsx.cn,
honyuenkwun@gmail.com, inindev@gmail.com, dsimic@manjaro.org,
pbrobinson@gmail.com, devicetree@vger.kernel.org,
linux-rockchip@lists.infradead.org
Subject: Re: [RESEND PATCH v5 3/3] arm64: dts: rockchip: Add support for CM5 IO carrier
Date: Tue, 2 Dec 2025 08:30:27 +0000 (UTC) [thread overview]
Message-ID: <39d3d988-f436-4b31-a130-c65dc292c469@rootcommit.com> (raw)
In-Reply-To: <20251202052702.155523-4-naoki@radxa.com>
Hi Naoki,
Thanks for the patch update!
On 12/2/25 06:27, FUKAUMI Naoki wrote:
> From: Joseph Kogut <joseph.kogut@gmail.com>
>
> From: Joseph Kogut <joseph.kogut@gmail.com>
>
> Specification:
> - 1x HDMI
> - 2x MIPI DSI
> - 2x MIPI CSI
> - 1x eDP
> - 1x M.2 E key
> - 1x USB 3.0 Host
> - 1x USB 3.0 OTG
> - 2x USB 2.0 Host
> - Headphone jack w/ microphone
> - Gigabit Ethernet w/ PoE
> - microSD slot
> - 40-pin expansion header
> - 12V DC
>
> Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
> ---
> Rebased on linux-next 20251201, no change.
> ---
> arch/arm64/boot/dts/rockchip/Makefile | 1 +
> .../dts/rockchip/rk3588s-radxa-cm5-io.dts | 486 ++++++++++++++++++
> 2 files changed, 487 insertions(+)
> create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts
>
> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
> index dbdda9783e93..697808b544d8 100644
> --- a/arch/arm64/boot/dts/rockchip/Makefile
> +++ b/arch/arm64/boot/dts/rockchip/Makefile
> @@ -210,6 +210,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-odroid-m2.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-orangepi-5.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-orangepi-5b.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-roc-pc.dtb
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-radxa-cm5-io.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-rock-5a.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-rock-5c.dtb
Small nitpick...
The file names are alphanumerically ordered in this file.
You should have rk3588s-radxa-cm5-io.dtb before rk3588s-roc-pc.dtb.
Cheers
Michael.
--
Michael Opdenacker
Root Commit
Yocto Project and OpenEmbedded Training course - Learn by doing:
https://rootcommit.com/training/yocto/
next prev parent reply other threads:[~2025-12-02 8:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 5:26 [RESEND PATCH v5 0/3] Add Radxa CM5 module and IO board dts FUKAUMI Naoki
2025-12-02 5:26 ` FUKAUMI Naoki
2025-12-02 5:27 ` [RESEND PATCH v5 1/3] dt-bindings: arm: rockchip: Add Radxa CM5 IO board FUKAUMI Naoki
2025-12-02 5:27 ` FUKAUMI Naoki
2025-12-02 7:45 ` Krzysztof Kozlowski
2025-12-02 7:45 ` Krzysztof Kozlowski
2025-12-02 8:33 ` FUKAUMI Naoki
2025-12-02 8:33 ` FUKAUMI Naoki
2025-12-02 10:54 ` Krzysztof Kozlowski
2025-12-02 10:54 ` Krzysztof Kozlowski
2025-12-02 11:03 ` FUKAUMI Naoki
2025-12-02 11:03 ` FUKAUMI Naoki
2025-12-02 5:27 ` [RESEND PATCH v5 2/3] arm64: dts: rockchip: Add rk3588 based Radxa CM5 FUKAUMI Naoki
2025-12-02 5:27 ` FUKAUMI Naoki
2025-12-02 5:27 ` [RESEND PATCH v5 3/3] arm64: dts: rockchip: Add support for CM5 IO carrier FUKAUMI Naoki
2025-12-02 5:27 ` FUKAUMI Naoki
2025-12-02 8:30 ` Michael Opdenacker [this message]
2025-12-02 8:30 ` Michael Opdenacker
2025-12-02 8:37 ` FUKAUMI Naoki
2025-12-02 8:37 ` FUKAUMI Naoki
2025-12-02 5:33 ` [RESEND PATCH v5 0/3] Add Radxa CM5 module and IO board dts FUKAUMI Naoki
2025-12-02 5:33 ` FUKAUMI Naoki
2025-12-02 5:48 ` FUKAUMI Naoki
2025-12-02 5:48 ` FUKAUMI Naoki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39d3d988-f436-4b31-a130-c65dc292c469@rootcommit.com \
--to=michael.opdenacker@rootcommit.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dsimic@manjaro.org \
--cc=heiko@sntech.de \
--cc=honyuenkwun@gmail.com \
--cc=i@next.chainsx.cn \
--cc=inindev@gmail.com \
--cc=jonas@kwiboo.se \
--cc=joseph.kogut@gmail.com \
--cc=kever.yang@rock-chips.com \
--cc=krzk+dt@kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=naoki@radxa.com \
--cc=pbrobinson@gmail.com \
--cc=quentin.schulz@cherry.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.