From: Manfred Spraul <manfred@colorfullife.com>
To: Jeff Garzik <jgarzik@mandrakesoft.com>
Cc: davej@suse.de, Alan Cox <alan@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] starfire reads irq before pci_enable_device.
Date: Wed, 07 Feb 2001 21:34:49 +0100 [thread overview]
Message-ID: <3A81B169.B4539406@colorfullife.com> (raw)
In-Reply-To: <Pine.LNX.4.31.0102071951060.17788-100000@athlon.local> <3A81A89C.DFD09434@mandrakesoft.com>
Jeff Garzik wrote:
>
> + SET_MODULE_OWNER(dev);
>
> irq = pdev->irq;
>
One question:
The code copies 'pdev->irq' into 'dev->irq'.
Is that required, who need 'dev->irq'?
> retval = request_irq(dev->irq, &intr_handler, SA_SHIRQ, dev->name, dev);
Can't the driver use?
retval = request_irq(np->pci_dev->irq)
--
Manfred
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2001-02-07 20:34 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-07 19:52 [PATCH] starfire reads irq before pci_enable_device davej
2001-02-07 19:57 ` Jeff Garzik
2001-02-07 20:34 ` Manfred Spraul [this message]
2001-02-08 4:00 ` Jeff Garzik
2001-02-08 1:52 ` Ion Badulescu
2001-02-08 20:28 ` Jeff Garzik
2001-02-08 21:18 ` Ion Badulescu
2001-02-08 21:38 ` Jeff Garzik
2001-02-08 22:05 ` Ion Badulescu
2001-02-09 19:08 ` Jeff Garzik
2001-02-09 20:07 ` Ion Badulescu
2001-02-09 20:11 ` Jeff Garzik
2001-02-09 20:21 ` Ion Badulescu
2001-02-09 20:26 ` Jeff Garzik
2001-02-08 21:43 ` Manfred Spraul
2001-02-08 21:46 ` Ion Badulescu
2001-02-09 21:43 ` Jes Sorensen
2001-02-09 21:52 ` Ion Badulescu
2001-02-12 18:54 ` Jes Sorensen
2001-02-14 1:35 ` Ion Badulescu
2001-02-10 14:48 ` Manfred Spraul
2001-02-08 21:26 ` Donald Becker
2001-02-08 22:16 ` Ion Badulescu
2001-02-09 0:09 ` Ion Badulescu
2001-02-09 0:44 ` Donald Becker
2001-02-09 0:47 ` Ion Badulescu
2001-02-09 10:49 ` Alan Cox
2001-02-09 23:32 ` Ion Badulescu
2001-02-09 23:35 ` Alan Cox
2001-02-10 8:48 ` Gérard Roudier
2001-02-12 19:01 ` Jes Sorensen
2001-02-13 13:06 ` Jeff Garzik
2001-02-13 20:29 ` Ion Badulescu
2001-02-14 2:05 ` Ion Badulescu
2001-02-14 20:10 ` Gérard Roudier
2001-02-14 15:39 ` Jes Sorensen
2001-02-17 21:34 ` David S. Miller
2001-02-19 11:00 ` Jes Sorensen
2001-02-09 21:42 ` Jes Sorensen
2001-02-09 22:56 ` Donald Becker
2001-02-12 18:54 ` Jes Sorensen
2001-02-14 1:20 ` Donald Becker
2001-02-14 12:37 ` Alan Cox
2001-02-14 12:49 ` Jeff Garzik
2001-02-14 12:54 ` Ion Badulescu
2001-02-14 13:05 ` Alan Cox
2001-02-14 13:38 ` Ion Badulescu
2001-02-14 15:35 ` Jes Sorensen
-- strict thread matches above, loose matches on Subject: below --
2001-02-14 16:54 Petr Vandrovec
2001-02-15 16:09 ` Jes Sorensen
2001-02-07 18:42 davej
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3A81B169.B4539406@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=alan@redhat.com \
--cc=davej@suse.de \
--cc=jgarzik@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.