All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@digeo.com>
To: dipankar@in.ibm.com
Cc: lkml <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: 2.5.38-mm2 [PATCH]
Date: Mon, 23 Sep 2002 09:28:41 -0700	[thread overview]
Message-ID: <3D8F4139.6BB60A35@digeo.com> (raw)
In-Reply-To: 20020923151559.B29900@in.ibm.com

Dipankar Sarma wrote:
> 
> ...
> -#ifdef CONFIG_PREEMPTION
> +#ifdef CONFIG_PREEMPT
>  #define rcu_read_lock()                preempt_disable()
>  #define rcu_read_unlock()      preempt_enable()
>  #else

Thanks.  I just replaced

#ifdef CONFIG_PREEMPTION
#define rcu_read_lock()        preempt_disable()
#define rcu_read_unlock()      preempt_enable()
#else
#define rcu_read_lock()        do {} while(0)
#define rcu_read_unlock()      do {} while(0)
#endif

with

#define rcu_read_lock()        preempt_disable()
#define rcu_read_unlock()      preempt_enable()

because preempt_disable() is a no-op on CONFIG_PREEMPT=n anyway.

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@digeo.com>
To: dipankar@in.ibm.com
Cc: lkml <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: 2.5.38-mm2 [PATCH]
Date: Mon, 23 Sep 2002 09:28:41 -0700	[thread overview]
Message-ID: <3D8F4139.6BB60A35@digeo.com> (raw)
In-Reply-To: 20020923151559.B29900@in.ibm.com

Dipankar Sarma wrote:
> 
> ...
> -#ifdef CONFIG_PREEMPTION
> +#ifdef CONFIG_PREEMPT
>  #define rcu_read_lock()                preempt_disable()
>  #define rcu_read_unlock()      preempt_enable()
>  #else

Thanks.  I just replaced

#ifdef CONFIG_PREEMPTION
#define rcu_read_lock()        preempt_disable()
#define rcu_read_unlock()      preempt_enable()
#else
#define rcu_read_lock()        do {} while(0)
#define rcu_read_unlock()      do {} while(0)
#endif

with

#define rcu_read_lock()        preempt_disable()
#define rcu_read_unlock()      preempt_enable()

because preempt_disable() is a no-op on CONFIG_PREEMPT=n anyway.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/

  reply	other threads:[~2002-09-23 19:11 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-23  4:20 2.5.38-mm2 Andrew Morton
2002-09-23  4:20 ` 2.5.38-mm2 Andrew Morton
2002-09-23  7:16 ` 2.5.38-mm2 Jens Axboe
2002-09-23  7:16   ` 2.5.38-mm2 Jens Axboe
2002-09-23  7:43   ` 2.5.38-mm2 Andrew Morton
2002-09-23  7:43     ` 2.5.38-mm2 Andrew Morton
2002-09-24 21:10   ` 2.5.38-mm2 Bill Davidsen
2002-09-24 21:10     ` 2.5.38-mm2 Bill Davidsen
2002-09-23  9:45 ` 2.5.38-mm2 [PATCH] Dipankar Sarma
2002-09-23  9:45   ` Dipankar Sarma
2002-09-23 16:28   ` Andrew Morton [this message]
2002-09-23 16:28     ` Andrew Morton
2002-09-23 17:33     ` Dipankar Sarma
2002-09-23 17:33       ` Dipankar Sarma
2002-09-24  4:41   ` Rusty Russell
2002-09-24  4:41     ` Rusty Russell
2002-09-24 10:24     ` Dipankar Sarma
2002-09-24 10:24       ` Dipankar Sarma
2002-09-24 14:56       ` Rusty Russell
2002-09-24 14:56         ` Rusty Russell
2002-09-23  9:56 ` 2.5.38-mm2 [PATCH] (dcache) Dipankar Sarma
2002-09-23  9:56   ` Dipankar Sarma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D8F4139.6BB60A35@digeo.com \
    --to=akpm@digeo.com \
    --cc=dipankar@in.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.