All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Dave Airlie <airlied@redhat.com>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] drm/i915: Make vblank evade warnings optional
Date: Sun, 7 May 2017 11:46:07 -0600	[thread overview]
Message-ID: <3c44fef6-751a-b322-3b84-eef192012606@kernel.dk> (raw)
In-Reply-To: <20170507171252.5149-1-ville.syrjala@linux.intel.com>

On 05/07/2017 11:12 AM, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Add a new Kconfig option to enable/disable the extra warnings
> from the vblank evade code. For now we'll keep the warning
> about an actually missed vblank always enabled as that can have
> an actual user visible impact. But if we miss the deadline
> othrwise there's no real need to bother the user with that.
> We'll want these warnings enabled during development however
> so that we can catch regressions.
> 
> Based on the reports it looks like this is still very easy
> to hit on SKL, so we have more work ahead of us to optimize
> the crtiical section further.

Shouldn't it just be a debug printk or something instead, so that normal
people don't see it, but the folks that turn on debugging can get the
info they need? Seems silly to add a kconfig option for this.

-- 
Jens Axboe

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@kernel.dk>
To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Daniel Vetter <daniel@ffwll.ch>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Dave Airlie <airlied@redhat.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Subject: Re: [PATCH] drm/i915: Make vblank evade warnings optional
Date: Sun, 7 May 2017 11:46:07 -0600	[thread overview]
Message-ID: <3c44fef6-751a-b322-3b84-eef192012606@kernel.dk> (raw)
In-Reply-To: <20170507171252.5149-1-ville.syrjala@linux.intel.com>

On 05/07/2017 11:12 AM, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Add a new Kconfig option to enable/disable the extra warnings
> from the vblank evade code. For now we'll keep the warning
> about an actually missed vblank always enabled as that can have
> an actual user visible impact. But if we miss the deadline
> othrwise there's no real need to bother the user with that.
> We'll want these warnings enabled during development however
> so that we can catch regressions.
> 
> Based on the reports it looks like this is still very easy
> to hit on SKL, so we have more work ahead of us to optimize
> the crtiical section further.

Shouldn't it just be a debug printk or something instead, so that normal
people don't see it, but the folks that turn on debugging can get the
info they need? Seems silly to add a kconfig option for this.

-- 
Jens Axboe

  reply	other threads:[~2017-05-07 17:46 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-03  3:44 [git pull] drm pull for v4.12 Dave Airlie
2017-05-03  3:44 ` Dave Airlie
2017-05-06 20:02 ` Linus Torvalds
2017-05-06 20:02   ` Linus Torvalds
2017-05-07 12:33   ` Daniel Vetter
2017-05-07 12:33     ` Daniel Vetter
2017-05-07 17:12   ` [PATCH] drm/i915: Make vblank evade warnings optional ville.syrjala
2017-05-07 17:12     ` ville.syrjala
2017-05-07 17:46     ` Jens Axboe [this message]
2017-05-07 17:46       ` Jens Axboe
2017-05-07 17:56       ` Daniel Vetter
2017-05-07 17:56         ` Daniel Vetter
2017-05-08  1:52         ` Jens Axboe
2017-05-08  1:52           ` Jens Axboe
2017-05-08  7:25           ` Daniel Vetter
2017-05-08  7:25             ` Daniel Vetter
2017-05-08 15:19             ` Jens Axboe
2017-05-08 15:19               ` Jens Axboe
2017-05-08  7:26     ` Daniel Vetter
2017-05-08  7:26       ` Daniel Vetter
2017-05-07 17:30 ` ✓ Fi.CI.BAT: success for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3c44fef6-751a-b322-3b84-eef192012606@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=airlied@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.