[PATCH] Xenstore testsuite robustness: save output rather than rerun on failure.

[PATCH] Xenstore testsuite robustness: save output rather than rerun on failure.

[Rusty Russell]

"make check" reruns a test which fails with more verbosity.  If the test
fails intermittently, that doesn't work well: save the output and simply
dump it if the test fails.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

# HG changeset patch
# User Rusty Russell <rusty@rustcorp.com.au>
# Node ID 07b986fec159c8bd18f7f109ca78c5b1250ee07c
# Parent  68ace2715cbc988c27c494a44a3154dbfcf83d0e
Rather than re-run on failure, record and replay (needed for occasional failures)

diff -r 68ace2715cbc -r 07b986fec159 tools/xenstore/testsuite/test.sh
--- a/tools/xenstore/testsuite/test.sh	Sat Aug 20 05:53:26 2005
+++ b/tools/xenstore/testsuite/test.sh	Sun Aug 21 06:29:47 2005
@@ -52,11 +52,10 @@
     case `basename $f` in $MATCH) RUN=1;; esac
     [ -n "$RUN" ] || continue
 
-    if run_test $f > /dev/null; then
+    if run_test $f -x >/tmp/out; then
 	echo -n .
     else
-	echo Test $f failed, running verbosely...
-	run_test $f -x || true
+	cat /tmp/out
 	# That will have filled the screen, repeat message.
 	echo Test $f failed
 	exit 1

-- 
A bad analogy is like a leaky screwdriver -- Richard Braakman

Re: [PATCH] Xenstore testsuite robustness: save output rather than rerun on failure.

[Christian Limpach]

Thanks!

On 8/21/05, Rusty Russell <rusty@rustcorp.com.au> wrote:
> "make check" reruns a test which fails with more verbosity.  If the test
> fails intermittently, that doesn't work well: save the output and simply
> dump it if the test fails.
> 
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
> 
> # HG changeset patch
> # User Rusty Russell <rusty@rustcorp.com.au>
> # Node ID 07b986fec159c8bd18f7f109ca78c5b1250ee07c
> # Parent  68ace2715cbc988c27c494a44a3154dbfcf83d0e
> Rather than re-run on failure, record and replay (needed for occasional failures)
> 
> diff -r 68ace2715cbc -r 07b986fec159 tools/xenstore/testsuite/test.sh
> --- a/tools/xenstore/testsuite/test.sh  Sat Aug 20 05:53:26 2005
> +++ b/tools/xenstore/testsuite/test.sh  Sun Aug 21 06:29:47 2005
> @@ -52,11 +52,10 @@
>     case `basename $f` in $MATCH) RUN=1;; esac
>     [ -n "$RUN" ] || continue
> 
> -    if run_test $f > /dev/null; then
> +    if run_test $f -x >/tmp/out; then
>        echo -n .
>     else
> -       echo Test $f failed, running verbosely...
> -       run_test $f -x || true
> +       cat /tmp/out
>        # That will have filled the screen, repeat message.
>        echo Test $f failed
>        exit 1
> 
> --
> A bad analogy is like a leaky screwdriver -- Richard Braakman
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>