All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Limpach <christian.limpach@gmail.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Xen Tools Developers <xen-tools@lists.xensource.com>,
	Dan Smith <danms@us.ibm.com>,
	Xen Developers <xen-devel@lists.xensource.com>
Subject: Re: [Xen-tools] Re: [PATCH] Make xend reject duplicates and rename zombies
Date: Fri, 16 Sep 2005 20:52:05 +0100	[thread overview]
Message-ID: <3d8eece205091612523cf7b900@mail.gmail.com> (raw)
In-Reply-To: <4329C366.2070006@us.ibm.com>

On 9/15/05, Anthony Liguori <aliguori@us.ibm.com> wrote:
> I think this is not the right solution to the problem at hand.  The
> problem stems from the fact that xm destroy is just a call to
> xc_domain_destroy which is really just a request to the hypervisor to
> destroy the domain.

Indeed.

> Therefore, there is a race condition if you assume that the domain is
> dead after xm destroy returns.  This patch renames the domain name which
> prevents a name class but does not solve the general problem.  Consider,
> for instance, if a domain is using a block device and you do an xm
> destroy.  It is not safe to create a new domain with that same block
> device until you know that the previously mentioned domain is gone.

I think renaming would make sense if a domain is crashed.  You might
want to keep the domain around to attach a debugger to it but at the
same time restart a fresh copy as soon as possible.

> This patch would allow:
> xm destroy xmexample1 && xm create /etc/xen/xmexample1
> 
> I think the right solution is to make xm destroy not return until the
> domain has actually gone away and add a flag to xm destroy to return
> immediately if that behavior is ever desired.

Sounds good.

> I'll work up a patch tonight after class.

Thanks!

     christian

  parent reply	other threads:[~2005-09-16 19:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-15 15:49 [PATCH] Make xend reject duplicates and rename zombies Dan Smith
2005-09-15 18:54 ` Anthony Liguori
2005-09-15 19:16   ` Dan Smith
2005-09-16 14:45     ` Ted Kaczmarek
2005-09-16 19:52   ` Christian Limpach [this message]
2005-09-16 21:37     ` [Xen-tools] " Anthony Liguori
2005-09-16 21:48       ` Christian Limpach
2005-09-16 21:49         ` Anthony Liguori
2005-09-16 22:19           ` Christian Limpach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3d8eece205091612523cf7b900@mail.gmail.com \
    --to=christian.limpach@gmail.com \
    --cc=Christian.Limpach@cl.cam.ac.uk \
    --cc=aliguori@us.ibm.com \
    --cc=danms@us.ibm.com \
    --cc=xen-devel@lists.xensource.com \
    --cc=xen-tools@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.