All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v3 06/14] dt-bindings: fsi: Document the FSI controller common properties
Date: Fri, 26 Apr 2024 08:23:24 +0200	[thread overview]
Message-ID: <3f381a54-49ce-4a45-a960-00cf2e91b044@kernel.org> (raw)
In-Reply-To: <20240425213701.655540-7-eajames@linux.ibm.com>

On 25/04/2024 23:36, Eddie James wrote:
> Since there are multiple FSI controllers documented, the common
> properties should be documented separately and then referenced
> from the specific controller documentation.
> 
> Signed-off-by: Eddie James <eajames@linux.ibm.com>
> ---


> +
> +  no-scan-on-init:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description:
> +      The FSI controller cannot scan the bus during initialization.
> +
> +patternProperties:
> +  "cfam@[0-9a-f],[0-9a-f]":
> +    type: object
> +    properties:
> +      chip-id:
> +        $ref: /schemas/types.yaml#/definitions/uint32

Missing description

> +
> +      reg:
> +        maxItems: 1
> +
> +      "#address-cells":
> +        const: 1
> +
> +      "#size-cells":
> +        const: 1
> +
> +    required:
> +      - reg
> +
> +    additionalProperties: true> +
> +additionalProperties: true
> +
> +examples:
> +  - |
> +    fsi at 3400 {
> +        #address-cells = <2>;
> +        #size-cells = <0>;
> +        compatible = "fsi-controller";

No, there is no such compatible here.

> +        reg = <0x3400 0x400>;

Neither reg.

Also, keep order of properties matching DTS coding style.


Best regards,
Krzysztof


WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Eddie James <eajames@linux.ibm.com>, linux-aspeed@lists.ozlabs.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-fsi@lists.ozlabs.org, linux-spi@vger.kernel.org,
	linux-i2c@vger.kernel.org, lakshmiy@us.ibm.com, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org, joel@jms.id.au,
	andrew@codeconstruct.com.au
Subject: Re: [PATCH v3 06/14] dt-bindings: fsi: Document the FSI controller common properties
Date: Fri, 26 Apr 2024 08:23:24 +0200	[thread overview]
Message-ID: <3f381a54-49ce-4a45-a960-00cf2e91b044@kernel.org> (raw)
In-Reply-To: <20240425213701.655540-7-eajames@linux.ibm.com>

On 25/04/2024 23:36, Eddie James wrote:
> Since there are multiple FSI controllers documented, the common
> properties should be documented separately and then referenced
> from the specific controller documentation.
> 
> Signed-off-by: Eddie James <eajames@linux.ibm.com>
> ---


> +
> +  no-scan-on-init:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description:
> +      The FSI controller cannot scan the bus during initialization.
> +
> +patternProperties:
> +  "cfam@[0-9a-f],[0-9a-f]":
> +    type: object
> +    properties:
> +      chip-id:
> +        $ref: /schemas/types.yaml#/definitions/uint32

Missing description

> +
> +      reg:
> +        maxItems: 1
> +
> +      "#address-cells":
> +        const: 1
> +
> +      "#size-cells":
> +        const: 1
> +
> +    required:
> +      - reg
> +
> +    additionalProperties: true> +
> +additionalProperties: true
> +
> +examples:
> +  - |
> +    fsi@3400 {
> +        #address-cells = <2>;
> +        #size-cells = <0>;
> +        compatible = "fsi-controller";

No, there is no such compatible here.

> +        reg = <0x3400 0x400>;

Neither reg.

Also, keep order of properties matching DTS coding style.


Best regards,
Krzysztof


  parent reply	other threads:[~2024-04-26  6:23 UTC|newest]

Thread overview: 98+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-25 21:36 [PATCH v3 00/14] ARM: dts: aspeed: Add IBM P11 BMC Boards Eddie James
2024-04-25 21:36 ` Eddie James
2024-04-25 21:36 ` [PATCH v3 01/14] dt-bindings: spi: Document the IBM Power SPI controller Eddie James
2024-04-25 21:36   ` Eddie James
2024-04-25 23:39   ` Rob Herring
2024-04-25 23:39     ` Rob Herring
2024-04-26  6:15   ` Krzysztof Kozlowski
2024-04-26  6:15     ` Krzysztof Kozlowski
2024-04-26 14:49     ` Eddie James
2024-04-26 14:49       ` Eddie James
2024-04-28 16:39       ` Krzysztof Kozlowski
2024-04-28 16:39         ` Krzysztof Kozlowski
2024-04-29 14:38         ` Eddie James
2024-04-29 14:38           ` Eddie James
2024-04-29 18:17           ` Krzysztof Kozlowski
2024-04-29 18:17             ` Krzysztof Kozlowski
2024-04-25 21:36 ` [PATCH v3 02/14] dt-bindings: fsi: fsi2spi: Document SPI controller child nodes Eddie James
2024-04-25 21:36   ` Eddie James
2024-04-25 21:36 ` [PATCH v3 03/14] dt-bindings: fsi: Document the FSI2PIB engine Eddie James
2024-04-25 21:36   ` Eddie James
2024-04-26  6:17   ` Krzysztof Kozlowski
2024-04-26  6:17     ` Krzysztof Kozlowski
2024-04-26  6:18   ` Krzysztof Kozlowski
2024-04-26  6:18     ` Krzysztof Kozlowski
2024-04-26 15:00     ` Eddie James
2024-04-26 15:00       ` Eddie James
2024-04-28 16:41       ` Krzysztof Kozlowski
2024-04-28 16:41         ` Krzysztof Kozlowski
2024-04-29 14:42         ` Eddie James
2024-04-29 14:42           ` Eddie James
2024-04-25 21:36 ` [PATCH v3 04/14] dt-bindings: fsi: p9-occ: Switch to yaml format Eddie James
2024-04-25 21:36   ` Eddie James
2024-04-26  6:19   ` Krzysztof Kozlowski
2024-04-26  6:19     ` Krzysztof Kozlowski
2024-04-26 15:05     ` Eddie James
2024-04-26 15:05       ` Eddie James
2024-04-25 21:36 ` [PATCH v3 05/14] dt-bindings: fsi: Document the IBM SBEFIFO engine Eddie James
2024-04-25 21:36   ` Eddie James
2024-04-26  6:20   ` Krzysztof Kozlowski
2024-04-26  6:20     ` Krzysztof Kozlowski
2024-04-26 15:09     ` Eddie James
2024-04-26 15:09       ` Eddie James
2024-04-25 21:36 ` [PATCH v3 06/14] dt-bindings: fsi: Document the FSI controller common properties Eddie James
2024-04-25 21:36   ` Eddie James
2024-04-25 23:40   ` Rob Herring
2024-04-25 23:40     ` Rob Herring
2024-04-26  6:23   ` Krzysztof Kozlowski [this message]
2024-04-26  6:23     ` Krzysztof Kozlowski
2024-04-26 15:11     ` Eddie James
2024-04-26 15:11       ` Eddie James
2024-04-25 21:36 ` [PATCH v3 07/14] dt-bindings: fsi: ibm,i2cr-fsi-master: Reference common FSI controller Eddie James
2024-04-25 21:36   ` Eddie James
2024-04-25 21:36 ` [PATCH v3 08/14] dt-bindings: fsi: ast2600-fsi-master: Switch to yaml format Eddie James
2024-04-25 21:36   ` Eddie James
2024-04-26  6:25   ` Krzysztof Kozlowski
2024-04-26  6:25     ` Krzysztof Kozlowski
2024-04-26 15:13     ` Eddie James
2024-04-26 15:13       ` Eddie James
2024-04-26 18:43       ` Rob Herring
2024-04-26 18:43         ` Rob Herring
2024-04-25 21:36 ` [PATCH v3 09/14] dt-bindings: fsi: Document the FSI Hub Controller Eddie James
2024-04-25 21:36   ` Eddie James
2024-04-26  6:26   ` Krzysztof Kozlowski
2024-04-26  6:26     ` Krzysztof Kozlowski
2024-04-26 15:19     ` Eddie James
2024-04-26 15:19       ` Eddie James
2024-04-28 16:43       ` Krzysztof Kozlowski
2024-04-28 16:43         ` Krzysztof Kozlowski
2024-04-25 21:36 ` [PATCH v3 10/14] dt-bindings: i2c: i2c-fsi: Switch to yaml format Eddie James
2024-04-25 21:36   ` Eddie James
2024-04-26  0:21   ` kernel test robot
2024-04-26  0:21     ` kernel test robot
2024-04-26  6:29   ` Krzysztof Kozlowski
2024-04-26  6:29     ` Krzysztof Kozlowski
2024-04-26 15:23     ` Eddie James
2024-04-26 15:23       ` Eddie James
2024-04-25 21:36 ` [PATCH v3 11/14] dt-bindings: arm: aspeed: add IBM P11 BMC boards Eddie James
2024-04-25 21:36   ` Eddie James
2024-04-25 21:36 ` [PATCH v3 12/14] ARM: dts: aspeed: Add IBM P11 FSI devices Eddie James
2024-04-25 21:36   ` Eddie James
2024-04-26  6:31   ` Krzysztof Kozlowski
2024-04-26  6:31     ` Krzysztof Kozlowski
2024-04-26 13:18     ` Eddie James
2024-04-26 13:18       ` Eddie James
2024-04-28 16:39       ` Krzysztof Kozlowski
2024-04-28 16:39         ` Krzysztof Kozlowski
2024-04-25 21:37 ` [PATCH v3 13/14] ARM: dts: aspeed: Add IBM P11 Blueridge BMC system Eddie James
2024-04-25 21:37   ` Eddie James
2024-04-26  6:35   ` Krzysztof Kozlowski
2024-04-26  6:35     ` Krzysztof Kozlowski
2024-04-26 13:22     ` Eddie James
2024-04-26 13:22       ` Eddie James
2024-04-25 21:37 ` [PATCH v3 14/14] ARM: dts: aspeed: Add IBM P11 Fuji " Eddie James
2024-04-25 21:37   ` Eddie James
2024-04-26  6:36   ` Krzysztof Kozlowski
2024-04-26  6:36     ` Krzysztof Kozlowski
2024-04-26 14:22 ` [PATCH v3 00/14] ARM: dts: aspeed: Add IBM P11 BMC Boards Rob Herring
2024-04-26 14:22   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f381a54-49ce-4a45-a960-00cf2e91b044@kernel.org \
    --to=krzk@kernel.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.