From: Jens Axboe <axboe@kernel.dk>
To: Sergey Senozhatsky <senozhatsky@chromium.org>,
Christoph Hellwig <hch@lst.de>
Cc: Richard Weinberger <richard@nod.at>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Josef Bacik <josef@toxicpanda.com>,
Minchan Kim <minchan@kernel.org>, Coly Li <colyli@suse.de>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-um@lists.infradead.org, linux-block@vger.kernel.org,
nbd@other.debian.org, linux-bcache@vger.kernel.org,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH 7/9] zram: use the default discard granularity
Date: Tue, 2 Jan 2024 08:40:36 -0700 [thread overview]
Message-ID: <400dbdbf-e99e-4747-94db-54fb6674fdd5@kernel.dk> (raw)
In-Reply-To: <20240102011543.GA21409@google.com>
On 1/1/24 6:15 PM, Sergey Senozhatsky wrote:
> On (23/12/28 07:55), Christoph Hellwig wrote:
>>
>> The discard granularity now defaults to a single sector, so don't set
>> that value explicitly
>
> Hmm, but sector size != PAGE_SIZE
>
> [..]
>
>> @@ -2227,7 +2227,6 @@ static int zram_add(void)
>> ZRAM_LOGICAL_BLOCK_SIZE);
>> blk_queue_io_min(zram->disk->queue, PAGE_SIZE);
>> blk_queue_io_opt(zram->disk->queue, PAGE_SIZE);
>> - zram->disk->queue->limits.discard_granularity = PAGE_SIZE;
Yep, that does indeed look buggy.
--
Jens Axboe
WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@kernel.dk>
To: Sergey Senozhatsky <senozhatsky@chromium.org>,
Christoph Hellwig <hch@lst.de>
Cc: Richard Weinberger <richard@nod.at>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Josef Bacik <josef@toxicpanda.com>,
Minchan Kim <minchan@kernel.org>, Coly Li <colyli@suse.de>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-um@lists.infradead.org, linux-block@vger.kernel.org,
nbd@other.debian.org, linux-bcache@vger.kernel.org,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH 7/9] zram: use the default discard granularity
Date: Tue, 2 Jan 2024 08:40:36 -0700 [thread overview]
Message-ID: <400dbdbf-e99e-4747-94db-54fb6674fdd5@kernel.dk> (raw)
In-Reply-To: <20240102011543.GA21409@google.com>
On 1/1/24 6:15 PM, Sergey Senozhatsky wrote:
> On (23/12/28 07:55), Christoph Hellwig wrote:
>>
>> The discard granularity now defaults to a single sector, so don't set
>> that value explicitly
>
> Hmm, but sector size != PAGE_SIZE
>
> [..]
>
>> @@ -2227,7 +2227,6 @@ static int zram_add(void)
>> ZRAM_LOGICAL_BLOCK_SIZE);
>> blk_queue_io_min(zram->disk->queue, PAGE_SIZE);
>> blk_queue_io_opt(zram->disk->queue, PAGE_SIZE);
>> - zram->disk->queue->limits.discard_granularity = PAGE_SIZE;
Yep, that does indeed look buggy.
--
Jens Axboe
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2024-01-02 15:40 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-28 7:55 provide a sane discard_granularity default Christoph Hellwig
2023-12-28 7:55 ` Christoph Hellwig
2023-12-28 7:55 ` [PATCH 1/9] block: remove two comments in bio_split_discard Christoph Hellwig
2023-12-28 7:55 ` Christoph Hellwig
2023-12-28 7:55 ` [PATCH 2/9] bcache: discard_granularity should not be smaller than a sector Christoph Hellwig
2023-12-28 7:55 ` Christoph Hellwig
2023-12-28 7:55 ` [PATCH 3/9] block: default the discard granularity to sector size Christoph Hellwig
2023-12-28 7:55 ` Christoph Hellwig
2024-01-02 22:11 ` John Pittman
2024-01-02 22:11 ` John Pittman
2024-01-03 7:57 ` Christoph Hellwig
2024-01-03 7:57 ` Christoph Hellwig
2023-12-28 7:55 ` [PATCH 4/9] ubd: use the default discard granularity Christoph Hellwig
2023-12-28 7:55 ` Christoph Hellwig
2023-12-28 11:10 ` Richard Weinberger
2023-12-28 11:10 ` Richard Weinberger
2023-12-28 7:55 ` [PATCH 5/9] nbd: " Christoph Hellwig
2023-12-28 7:55 ` Christoph Hellwig
2023-12-28 7:55 ` [PATCH 6/9] null_blk: " Christoph Hellwig
2023-12-28 7:55 ` Christoph Hellwig
2023-12-28 7:55 ` [PATCH 7/9] zram: " Christoph Hellwig
2023-12-28 7:55 ` Christoph Hellwig
2024-01-02 1:15 ` Sergey Senozhatsky
2024-01-02 1:15 ` Sergey Senozhatsky
2024-01-02 15:40 ` Jens Axboe [this message]
2024-01-02 15:40 ` Jens Axboe
2024-01-02 15:44 ` Jens Axboe
2024-01-02 15:44 ` Jens Axboe
2024-01-02 15:47 ` Jens Axboe
2024-01-02 15:47 ` Jens Axboe
2024-01-06 1:32 ` Sergey Senozhatsky
2024-01-06 1:32 ` Sergey Senozhatsky
2023-12-28 7:55 ` [PATCH 8/9] bcache: " Christoph Hellwig
2023-12-28 7:55 ` Christoph Hellwig
2024-01-05 7:03 ` Coly Li
2024-01-05 7:03 ` Coly Li
2023-12-28 7:55 ` [PATCH 9/9] mtd_blkdevs: " Christoph Hellwig
2023-12-28 7:55 ` Christoph Hellwig
2023-12-28 11:09 ` Richard Weinberger
2023-12-28 11:09 ` Richard Weinberger
2023-12-29 15:44 ` provide a sane discard_granularity default Jens Axboe
2023-12-29 15:44 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=400dbdbf-e99e-4747-94db-54fb6674fdd5@kernel.dk \
--to=axboe@kernel.dk \
--cc=anton.ivanov@cambridgegreys.com \
--cc=colyli@suse.de \
--cc=hch@lst.de \
--cc=josef@toxicpanda.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-um@lists.infradead.org \
--cc=minchan@kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=nbd@other.debian.org \
--cc=richard@nod.at \
--cc=senozhatsky@chromium.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.