All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: hch <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
	anton ivanov <anton.ivanov@cambridgegreys.com>,
	 Josef Bacik <josef@toxicpanda.com>,
	Minchan Kim <minchan@kernel.org>,
	 senozhatsky <senozhatsky@chromium.org>, Coly Li <colyli@suse.de>,
	 Miquel Raynal <miquel.raynal@bootlin.com>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 linux-um <linux-um@lists.infradead.org>,
	 linux-block <linux-block@vger.kernel.org>,
	nbd@other.debian.org,
	 linux-bcache <linux-bcache@vger.kernel.org>,
	 linux-mtd <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH 9/9] mtd_blkdevs: use the default discard granularity
Date: Thu, 28 Dec 2023 12:09:38 +0100 (CET)	[thread overview]
Message-ID: <651248504.172152.1703761778190.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <20231228075545.362768-10-hch@lst.de>

----- Ursprüngliche Mail -----
> Von: "hch" <hch@lst.de>
> An: "Jens Axboe" <axboe@kernel.dk>
> CC: "richard" <richard@nod.at>, "anton ivanov" <anton.ivanov@cambridgegreys.com>, "Josef Bacik" <josef@toxicpanda.com>,
> "Minchan Kim" <minchan@kernel.org>, "senozhatsky" <senozhatsky@chromium.org>, "Coly Li" <colyli@suse.de>, "Miquel
> Raynal" <miquel.raynal@bootlin.com>, "Vignesh Raghavendra" <vigneshr@ti.com>, "linux-um"
> <linux-um@lists.infradead.org>, "linux-block" <linux-block@vger.kernel.org>, nbd@other.debian.org, "linux-bcache"
> <linux-bcache@vger.kernel.org>, "linux-mtd" <linux-mtd@lists.infradead.org>
> Gesendet: Donnerstag, 28. Dezember 2023 08:55:45
> Betreff: [PATCH 9/9] mtd_blkdevs: use the default discard granularity

> The discard granularity now defaults to a single sector, so don't set
> that value explicitly.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/mtd/mtd_blkdevs.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c
> index ff18636e088973..0da7b33849471a 100644
> --- a/drivers/mtd/mtd_blkdevs.c
> +++ b/drivers/mtd/mtd_blkdevs.c
> @@ -376,10 +376,8 @@ int add_mtd_blktrans_dev(struct mtd_blktrans_dev *new)
> 	blk_queue_flag_set(QUEUE_FLAG_NONROT, new->rq);
> 	blk_queue_flag_clear(QUEUE_FLAG_ADD_RANDOM, new->rq);
> 
> -	if (tr->discard) {
> +	if (tr->discard)
> 		blk_queue_max_discard_sectors(new->rq, UINT_MAX);
> -		new->rq->limits.discard_granularity = tr->blksize;
> -	}

Acked-by: Richard Weinberger <richard@nod.at>

Thanks,
//richard

WARNING: multiple messages have this Message-ID (diff)
From: Richard Weinberger <richard@nod.at>
To: hch <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
	anton ivanov <anton.ivanov@cambridgegreys.com>,
	 Josef Bacik <josef@toxicpanda.com>,
	Minchan Kim <minchan@kernel.org>,
	 senozhatsky <senozhatsky@chromium.org>, Coly Li <colyli@suse.de>,
	 Miquel Raynal <miquel.raynal@bootlin.com>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 linux-um <linux-um@lists.infradead.org>,
	 linux-block <linux-block@vger.kernel.org>,
	nbd@other.debian.org,
	 linux-bcache <linux-bcache@vger.kernel.org>,
	 linux-mtd <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH 9/9] mtd_blkdevs: use the default discard granularity
Date: Thu, 28 Dec 2023 12:09:38 +0100 (CET)	[thread overview]
Message-ID: <651248504.172152.1703761778190.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <20231228075545.362768-10-hch@lst.de>

----- Ursprüngliche Mail -----
> Von: "hch" <hch@lst.de>
> An: "Jens Axboe" <axboe@kernel.dk>
> CC: "richard" <richard@nod.at>, "anton ivanov" <anton.ivanov@cambridgegreys.com>, "Josef Bacik" <josef@toxicpanda.com>,
> "Minchan Kim" <minchan@kernel.org>, "senozhatsky" <senozhatsky@chromium.org>, "Coly Li" <colyli@suse.de>, "Miquel
> Raynal" <miquel.raynal@bootlin.com>, "Vignesh Raghavendra" <vigneshr@ti.com>, "linux-um"
> <linux-um@lists.infradead.org>, "linux-block" <linux-block@vger.kernel.org>, nbd@other.debian.org, "linux-bcache"
> <linux-bcache@vger.kernel.org>, "linux-mtd" <linux-mtd@lists.infradead.org>
> Gesendet: Donnerstag, 28. Dezember 2023 08:55:45
> Betreff: [PATCH 9/9] mtd_blkdevs: use the default discard granularity

> The discard granularity now defaults to a single sector, so don't set
> that value explicitly.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/mtd/mtd_blkdevs.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c
> index ff18636e088973..0da7b33849471a 100644
> --- a/drivers/mtd/mtd_blkdevs.c
> +++ b/drivers/mtd/mtd_blkdevs.c
> @@ -376,10 +376,8 @@ int add_mtd_blktrans_dev(struct mtd_blktrans_dev *new)
> 	blk_queue_flag_set(QUEUE_FLAG_NONROT, new->rq);
> 	blk_queue_flag_clear(QUEUE_FLAG_ADD_RANDOM, new->rq);
> 
> -	if (tr->discard) {
> +	if (tr->discard)
> 		blk_queue_max_discard_sectors(new->rq, UINT_MAX);
> -		new->rq->limits.discard_granularity = tr->blksize;
> -	}

Acked-by: Richard Weinberger <richard@nod.at>

Thanks,
//richard

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2023-12-28 11:15 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-28  7:55 provide a sane discard_granularity default Christoph Hellwig
2023-12-28  7:55 ` Christoph Hellwig
2023-12-28  7:55 ` [PATCH 1/9] block: remove two comments in bio_split_discard Christoph Hellwig
2023-12-28  7:55   ` Christoph Hellwig
2023-12-28  7:55 ` [PATCH 2/9] bcache: discard_granularity should not be smaller than a sector Christoph Hellwig
2023-12-28  7:55   ` Christoph Hellwig
2023-12-28  7:55 ` [PATCH 3/9] block: default the discard granularity to sector size Christoph Hellwig
2023-12-28  7:55   ` Christoph Hellwig
2024-01-02 22:11   ` John Pittman
2024-01-02 22:11     ` John Pittman
2024-01-03  7:57     ` Christoph Hellwig
2024-01-03  7:57       ` Christoph Hellwig
2023-12-28  7:55 ` [PATCH 4/9] ubd: use the default discard granularity Christoph Hellwig
2023-12-28  7:55   ` Christoph Hellwig
2023-12-28 11:10   ` Richard Weinberger
2023-12-28 11:10     ` Richard Weinberger
2023-12-28  7:55 ` [PATCH 5/9] nbd: " Christoph Hellwig
2023-12-28  7:55   ` Christoph Hellwig
2023-12-28  7:55 ` [PATCH 6/9] null_blk: " Christoph Hellwig
2023-12-28  7:55   ` Christoph Hellwig
2023-12-28  7:55 ` [PATCH 7/9] zram: " Christoph Hellwig
2023-12-28  7:55   ` Christoph Hellwig
2024-01-02  1:15   ` Sergey Senozhatsky
2024-01-02  1:15     ` Sergey Senozhatsky
2024-01-02 15:40     ` Jens Axboe
2024-01-02 15:40       ` Jens Axboe
2024-01-02 15:44       ` Jens Axboe
2024-01-02 15:44         ` Jens Axboe
2024-01-02 15:47         ` Jens Axboe
2024-01-02 15:47           ` Jens Axboe
2024-01-06  1:32   ` Sergey Senozhatsky
2024-01-06  1:32     ` Sergey Senozhatsky
2023-12-28  7:55 ` [PATCH 8/9] bcache: " Christoph Hellwig
2023-12-28  7:55   ` Christoph Hellwig
2024-01-05  7:03   ` Coly Li
2024-01-05  7:03     ` Coly Li
2023-12-28  7:55 ` [PATCH 9/9] mtd_blkdevs: " Christoph Hellwig
2023-12-28  7:55   ` Christoph Hellwig
2023-12-28 11:09   ` Richard Weinberger [this message]
2023-12-28 11:09     ` Richard Weinberger
2023-12-29 15:44 ` provide a sane discard_granularity default Jens Axboe
2023-12-29 15:44   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=651248504.172152.1703761778190.JavaMail.zimbra@nod.at \
    --to=richard@nod.at \
    --cc=anton.ivanov@cambridgegreys.com \
    --cc=axboe@kernel.dk \
    --cc=colyli@suse.de \
    --cc=hch@lst.de \
    --cc=josef@toxicpanda.com \
    --cc=linux-bcache@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-um@lists.infradead.org \
    --cc=minchan@kernel.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=nbd@other.debian.org \
    --cc=senozhatsky@chromium.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.