From: Arnd Bergmann <arnd@arndb.de>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: linux-rpi-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Peter Chen <peter.chen@freescale.com>,
Olivier Blin <dev@blino.org>,
Stephen Warren <swarren@wwwdotorg.org>,
popcornmix <popcornmix@gmail.com>
Subject: Re: [PATCH 2/2] net/smscx5xx: use the device tree for mac address
Date: Thu, 04 Feb 2016 09:24 +0100 [thread overview]
Message-ID: <40411294.EnLd2i85mo@wuerfel> (raw)
In-Reply-To: <1454571364-24708-3-git-send-email-lkundrak@v3.sk>
On Thursday 04 February 2016 08:36:04 Lubomir Rintel wrote:
>
> [lkundrak@v3.sk: updated to use of_get_property() as per suggestion from Arnd,
> reworded the message and comments a bit]
>
> Tested-by: Lubomir Rintel <lkundrak@v3.sk>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>
Looks good to me now. We could debate which MAC address should
be used when both EEPROM and DT exist. The current version prefers
the EEPROM address, and I think some other drivers do the opposite,
but I don't really know which is best.
Arnd
prev parent reply other threads:[~2016-02-04 8:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-04 7:36 [PATCH v2 0/2] Set the Raspberry Pi Ethernet MAC address Lubomir Rintel
2016-02-04 7:36 ` Lubomir Rintel
[not found] ` <1454571364-24708-1-git-send-email-lkundrak-NGH9Lh4a5iE@public.gmane.org>
2016-02-04 7:36 ` [PATCH v2 1/2] ARM: bcm2835: dt: Add the ethernet to the device trees Lubomir Rintel
2016-02-04 7:36 ` Lubomir Rintel
[not found] ` <1454571364-24708-2-git-send-email-lkundrak-NGH9Lh4a5iE@public.gmane.org>
2016-02-04 8:22 ` Peter Chen
2016-02-04 8:22 ` Peter Chen
2016-02-05 14:25 ` Olivier Blin
2016-02-05 14:25 ` Olivier Blin
[not found] ` <m3fux76xqa.fsf-sb2orAewljU5LtT840wCHw@public.gmane.org>
2016-02-05 14:55 ` Lubomir Rintel
2016-02-05 14:55 ` Lubomir Rintel
[not found] ` <1454684126.2779.2.camel-NGH9Lh4a5iE@public.gmane.org>
2016-02-05 15:07 ` Olivier Blin
2016-02-05 15:07 ` Olivier Blin
2016-02-06 4:13 ` Stephen Warren
2016-02-06 4:13 ` Stephen Warren
[not found] ` <56B572D8.9030701-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2016-04-28 12:52 ` Olivier Blin
2016-04-28 12:52 ` Olivier Blin
[not found] ` <m3wpnhrj42.fsf-sb2orAewljU5LtT840wCHw@public.gmane.org>
2016-04-28 16:26 ` Stefan Wahren
2016-04-28 16:26 ` Stefan Wahren
2016-04-28 16:29 ` Lubomir Rintel
2016-02-04 7:36 ` [PATCH 2/2] net/smscx5xx: use the device tree for mac address Lubomir Rintel
2016-02-04 7:36 ` Lubomir Rintel
2016-02-04 8:24 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40411294.EnLd2i85mo@wuerfel \
--to=arnd@arndb.de \
--cc=dev@blino.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=lkundrak@v3.sk \
--cc=peter.chen@freescale.com \
--cc=popcornmix@gmail.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.