All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org>
To: Olivier Blin <dev-RZzICDNEOQ/YtjvyW6yDsg@public.gmane.org>,
	Lubomir Rintel <lkundrak-NGH9Lh4a5iE@public.gmane.org>,
	eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Peter Chen <peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
	linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v2 1/2] ARM: bcm2835: dt: Add the ethernet to the device trees
Date: Thu, 28 Apr 2016 18:26:12 +0200	[thread overview]
Message-ID: <572239A4.3030100@i2se.com> (raw)
In-Reply-To: <m3wpnhrj42.fsf-sb2orAewljU5LtT840wCHw@public.gmane.org>

Hi Olivier

Am 28.04.2016 um 14:52 schrieb Olivier Blin:
> Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> writes:
>
>> On 02/04/2016 12:36 AM, Lubomir Rintel wrote:
>>> The hub and the ethernet in its port 1 are hardwired on the board.
>>>
>>> Compared to the adapters that can be plugged into the USB ports, this
>>> one has no serial EEPROM to store its MAC. Nevertheless, the Raspberry Pi
>>> has the MAC address for this adapter in its ROM, accessible from its
>>> firmware.
>>>
>>> U-Boot can read out the address and set the local-mac-address property of the
>>> node with "ethernet" alias. Let's add the node so that U-Boot can do its
>>> business.
>>>
>>> Model B rev2 and Model B+ entries were verified by me, the hierarchy and
>>> pid/vid pair for the Version 2 was provided by Olivier Blin. Original
>>> Model B is a blind short, though very likely correct.
>> The series,
>> Tested-by: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
>>
>> A few nits though...
> [...]
>
> Is this still being queued in some tree?
> Or does it need more fixes and a resubmit?

Yes, a V3 should address the comments from Peter and Stephen.

Regards
Stefan

>
> Without this, Raspberry Pi devices boot with a random MAC address.
>


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Stefan Wahren <stefan.wahren@i2se.com>
To: Olivier Blin <dev@blino.org>, Lubomir Rintel <lkundrak@v3.sk>,
	eric@anholt.net
Cc: devicetree@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org,
	Peter Chen <peter.chen@freescale.com>,
	linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/2] ARM: bcm2835: dt: Add the ethernet to the device trees
Date: Thu, 28 Apr 2016 18:26:12 +0200	[thread overview]
Message-ID: <572239A4.3030100@i2se.com> (raw)
In-Reply-To: <m3wpnhrj42.fsf@euphor.blino.org>

Hi Olivier

Am 28.04.2016 um 14:52 schrieb Olivier Blin:
> Stephen Warren <swarren@wwwdotorg.org> writes:
>
>> On 02/04/2016 12:36 AM, Lubomir Rintel wrote:
>>> The hub and the ethernet in its port 1 are hardwired on the board.
>>>
>>> Compared to the adapters that can be plugged into the USB ports, this
>>> one has no serial EEPROM to store its MAC. Nevertheless, the Raspberry Pi
>>> has the MAC address for this adapter in its ROM, accessible from its
>>> firmware.
>>>
>>> U-Boot can read out the address and set the local-mac-address property of the
>>> node with "ethernet" alias. Let's add the node so that U-Boot can do its
>>> business.
>>>
>>> Model B rev2 and Model B+ entries were verified by me, the hierarchy and
>>> pid/vid pair for the Version 2 was provided by Olivier Blin. Original
>>> Model B is a blind short, though very likely correct.
>> The series,
>> Tested-by: Stephen Warren <swarren@wwwdotorg.org>
>>
>> A few nits though...
> [...]
>
> Is this still being queued in some tree?
> Or does it need more fixes and a resubmit?

Yes, a V3 should address the comments from Peter and Stephen.

Regards
Stefan

>
> Without this, Raspberry Pi devices boot with a random MAC address.
>

  parent reply	other threads:[~2016-04-28 16:26 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-04  7:36 [PATCH v2 0/2] Set the Raspberry Pi Ethernet MAC address Lubomir Rintel
2016-02-04  7:36 ` Lubomir Rintel
     [not found] ` <1454571364-24708-1-git-send-email-lkundrak-NGH9Lh4a5iE@public.gmane.org>
2016-02-04  7:36   ` [PATCH v2 1/2] ARM: bcm2835: dt: Add the ethernet to the device trees Lubomir Rintel
2016-02-04  7:36     ` Lubomir Rintel
     [not found]     ` <1454571364-24708-2-git-send-email-lkundrak-NGH9Lh4a5iE@public.gmane.org>
2016-02-04  8:22       ` Peter Chen
2016-02-04  8:22         ` Peter Chen
2016-02-05 14:25       ` Olivier Blin
2016-02-05 14:25         ` Olivier Blin
     [not found]         ` <m3fux76xqa.fsf-sb2orAewljU5LtT840wCHw@public.gmane.org>
2016-02-05 14:55           ` Lubomir Rintel
2016-02-05 14:55             ` Lubomir Rintel
     [not found]             ` <1454684126.2779.2.camel-NGH9Lh4a5iE@public.gmane.org>
2016-02-05 15:07               ` Olivier Blin
2016-02-05 15:07                 ` Olivier Blin
2016-02-06  4:13       ` Stephen Warren
2016-02-06  4:13         ` Stephen Warren
     [not found]         ` <56B572D8.9030701-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2016-04-28 12:52           ` Olivier Blin
2016-04-28 12:52             ` Olivier Blin
     [not found]             ` <m3wpnhrj42.fsf-sb2orAewljU5LtT840wCHw@public.gmane.org>
2016-04-28 16:26               ` Stefan Wahren [this message]
2016-04-28 16:26                 ` Stefan Wahren
2016-04-28 16:29                 ` Lubomir Rintel
2016-02-04  7:36   ` [PATCH 2/2] net/smscx5xx: use the device tree for mac address Lubomir Rintel
2016-02-04  7:36     ` Lubomir Rintel
2016-02-04  8:24     ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=572239A4.3030100@i2se.com \
    --to=stefan.wahren-es4nqchxeme@public.gmane.org \
    --cc=arnd-r2nGTMty4D4@public.gmane.org \
    --cc=dev-RZzICDNEOQ/YtjvyW6yDsg@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=lkundrak-NGH9Lh4a5iE@public.gmane.org \
    --cc=peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.