Re: [PATCH v2 1/2] ARM: bcm2835: dt: Add the ethernet to the device trees

[Olivier Blin <dev-RZzICDNEOQ/YtjvyW6yDsg@public.gmane.org>]

Lubomir Rintel <lkundrak-NGH9Lh4a5iE@public.gmane.org> writes:

> diff --git a/arch/arm/boot/dts/bcm2836-rpi-2-b.dts b/arch/arm/boot/dts/bcm2836-rpi-2-b.dts
[...]
> @@ -33,3 +37,17 @@
>  		brcm,function = <BCM2835_FSEL_ALT0>;
>  	};
>  };
> +
> +&usb {
> +	usb1@1 {
> +		compatible = "usb0424,9514";
> +		reg = <01>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		ethernet: usbether@1 {
> +			compatible = "usb0424,ec00";
> +			reg = <01>;
> +		};
> +	};
> +};

Hi,

This works for me, after making sure that your u-boot patch gets a
chance to be run (unset usbethaddr from u-boot).

Though, I am not really DT-literate, but shouldn't the ethernet block
use the PID from the ethernet device?
The usbether device is 9514 on RPi2, while ec00 is the hub.

Your patch works, but this works as well after swapping the PIDs.

Thanks

-- 
Olivier Blin - blino
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html