From: Arnd Bergmann <arnd@arndb.de>
To: Amitkumar Karwar <akarwar@marvell.com>
Cc: linux-wireless@vger.kernel.org,
Nishant Sarmukadam <nishants@marvell.com>,
wnhuang@chromium.com, devicetree@vger.kernel.org,
Xinming Hu <huxm@marvell.com>
Subject: Re: [PATCH v3 2/3] mwifiex: parse chip specific gpio from device tree
Date: Mon, 08 Feb 2016 13:11:03 +0100 [thread overview]
Message-ID: <4072066.xhEHjcRQWo@wuerfel> (raw)
In-Reply-To: <1454926528-17480-2-git-send-email-akarwar@marvell.com>
On Monday 08 February 2016 02:15:27 Amitkumar Karwar wrote:
> if (adapter->dt_node) {
> + if (of_property_read_u32(adapter->dt_node,
> + "mwifiex,chip-gpio",
> + &data) == 0) {
> + mwifiex_dbg(adapter, INFO,
> + "chip_gpio = 0x%x\n", data);
> + adapter->hs_cfg.gpio = data;
> + }
> +
>
Please use the GPIO DT binding. Reading a number from DT is not a proper
way to get a GPIO number, as you may have more than one GPIO controller
in a system and it is not obvious to which controller this number belongs,
or if you need to specify things like polarity.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Amitkumar Karwar <akarwar-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Nishant Sarmukadam
<nishants-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
wnhuang-F7+t8E8rja9Wk0Htik3J/w@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Xinming Hu <huxm-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH v3 2/3] mwifiex: parse chip specific gpio from device tree
Date: Mon, 08 Feb 2016 13:11:03 +0100 [thread overview]
Message-ID: <4072066.xhEHjcRQWo@wuerfel> (raw)
In-Reply-To: <1454926528-17480-2-git-send-email-akarwar-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
On Monday 08 February 2016 02:15:27 Amitkumar Karwar wrote:
> if (adapter->dt_node) {
> + if (of_property_read_u32(adapter->dt_node,
> + "mwifiex,chip-gpio",
> + &data) == 0) {
> + mwifiex_dbg(adapter, INFO,
> + "chip_gpio = 0x%x\n", data);
> + adapter->hs_cfg.gpio = data;
> + }
> +
>
Please use the GPIO DT binding. Reading a number from DT is not a proper
way to get a GPIO number, as you may have more than one GPIO controller
in a system and it is not obvious to which controller this number belongs,
or if you need to specify things like polarity.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-02-08 12:11 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 10:15 [PATCH v3 1/3] mwifiex: register platform specific driver Amitkumar Karwar
2016-02-08 10:15 ` Amitkumar Karwar
2016-02-08 10:15 ` [PATCH v3 2/3] mwifiex: parse chip specific gpio from device tree Amitkumar Karwar
2016-02-08 10:15 ` Amitkumar Karwar
2016-02-08 12:11 ` Arnd Bergmann [this message]
2016-02-08 12:11 ` Arnd Bergmann
2016-02-08 21:47 ` Rob Herring
2016-02-08 21:47 ` Rob Herring
2016-02-09 14:03 ` Amitkumar Karwar
2016-02-09 14:03 ` Amitkumar Karwar
2016-02-09 14:19 ` Arnd Bergmann
2016-02-09 14:19 ` Arnd Bergmann
2016-02-09 14:26 ` Amitkumar Karwar
2016-02-09 14:26 ` Amitkumar Karwar
2016-02-08 10:15 ` [PATCH v3 3/3] mwifiex: parse host wakeup configuration " Amitkumar Karwar
2016-02-08 10:15 ` Amitkumar Karwar
2016-02-08 12:12 ` Arnd Bergmann
2016-02-08 12:12 ` Arnd Bergmann
2016-02-09 13:46 ` Amitkumar Karwar
2016-02-09 13:46 ` Amitkumar Karwar
2016-02-08 12:09 ` [PATCH v3 1/3] mwifiex: register platform specific driver Arnd Bergmann
2016-02-08 12:09 ` Arnd Bergmann
2016-02-09 13:44 ` Amitkumar Karwar
2016-02-09 13:44 ` Amitkumar Karwar
2016-02-09 14:18 ` Arnd Bergmann
2016-02-09 14:18 ` Arnd Bergmann
2016-02-09 14:27 ` Amitkumar Karwar
2016-02-09 14:27 ` Amitkumar Karwar
2016-02-08 21:56 ` Rob Herring
2016-02-08 21:56 ` Rob Herring
2016-02-09 14:00 ` Amitkumar Karwar
2016-02-09 14:00 ` Amitkumar Karwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4072066.xhEHjcRQWo@wuerfel \
--to=arnd@arndb.de \
--cc=akarwar@marvell.com \
--cc=devicetree@vger.kernel.org \
--cc=huxm@marvell.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nishants@marvell.com \
--cc=wnhuang@chromium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.