All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Amitkumar Karwar <akarwar@marvell.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	Nishant Sarmukadam <nishants@marvell.com>,
	"wnhuang@chromium.com" <wnhuang@chromium.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Xinming Hu <huxm@marvell.com>, Cathy Luo <cluo@marvell.com>
Subject: Re: [PATCH v3 1/3] mwifiex: register platform specific driver
Date: Tue, 09 Feb 2016 15:18:18 +0100	[thread overview]
Message-ID: <6131181.bluDODkWmt@wuerfel> (raw)
In-Reply-To: <5ef981436ee64f67beef7ca1e2470c69@SC-EXCH04.marvell.com>

On Tuesday 09 February 2016 13:44:16 Amitkumar Karwar wrote:
> > > index 0000000..39b6a74
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/mwifiex.txt
> > > @@ -0,0 +1,29 @@
> > > +mwifiex
> > > +------
> > > +
> > > +Required properties:
> > > +
> > > +  - name : must be "mwifiex"
> > 
> > This is a very unusual requirement.
> > 
> > Can you use one of the standard device names instead?
> > 
> 
> We will make use of marvell-sd8xxx in updated version as per Rob Herring's suggestions.
> It includes vendor name and a chipset/device name.

I meant the node name, not the compatible string. This should be something
like "ethernet" or "wlan".

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Amitkumar Karwar <akarwar-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
Cc: "linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Nishant Sarmukadam
	<nishants-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
	"wnhuang-F7+t8E8rja9Wk0Htik3J/w@public.gmane.org"
	<wnhuang-F7+t8E8rja9Wk0Htik3J/w@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Xinming Hu <huxm-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
	Cathy Luo <cluo-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH v3 1/3] mwifiex: register platform specific driver
Date: Tue, 09 Feb 2016 15:18:18 +0100	[thread overview]
Message-ID: <6131181.bluDODkWmt@wuerfel> (raw)
In-Reply-To: <5ef981436ee64f67beef7ca1e2470c69-uAViF8V/CPOq90oVIqnETxL4W9x8LtSr@public.gmane.org>

On Tuesday 09 February 2016 13:44:16 Amitkumar Karwar wrote:
> > > index 0000000..39b6a74
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/mwifiex.txt
> > > @@ -0,0 +1,29 @@
> > > +mwifiex
> > > +------
> > > +
> > > +Required properties:
> > > +
> > > +  - name : must be "mwifiex"
> > 
> > This is a very unusual requirement.
> > 
> > Can you use one of the standard device names instead?
> > 
> 
> We will make use of marvell-sd8xxx in updated version as per Rob Herring's suggestions.
> It includes vendor name and a chipset/device name.

I meant the node name, not the compatible string. This should be something
like "ethernet" or "wlan".

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2016-02-09 14:18 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-08 10:15 [PATCH v3 1/3] mwifiex: register platform specific driver Amitkumar Karwar
2016-02-08 10:15 ` Amitkumar Karwar
2016-02-08 10:15 ` [PATCH v3 2/3] mwifiex: parse chip specific gpio from device tree Amitkumar Karwar
2016-02-08 10:15   ` Amitkumar Karwar
2016-02-08 12:11   ` Arnd Bergmann
2016-02-08 12:11     ` Arnd Bergmann
2016-02-08 21:47     ` Rob Herring
2016-02-08 21:47       ` Rob Herring
2016-02-09 14:03       ` Amitkumar Karwar
2016-02-09 14:03         ` Amitkumar Karwar
2016-02-09 14:19         ` Arnd Bergmann
2016-02-09 14:19           ` Arnd Bergmann
2016-02-09 14:26           ` Amitkumar Karwar
2016-02-09 14:26             ` Amitkumar Karwar
2016-02-08 10:15 ` [PATCH v3 3/3] mwifiex: parse host wakeup configuration " Amitkumar Karwar
2016-02-08 10:15   ` Amitkumar Karwar
2016-02-08 12:12   ` Arnd Bergmann
2016-02-08 12:12     ` Arnd Bergmann
2016-02-09 13:46     ` Amitkumar Karwar
2016-02-09 13:46       ` Amitkumar Karwar
2016-02-08 12:09 ` [PATCH v3 1/3] mwifiex: register platform specific driver Arnd Bergmann
2016-02-08 12:09   ` Arnd Bergmann
2016-02-09 13:44   ` Amitkumar Karwar
2016-02-09 13:44     ` Amitkumar Karwar
2016-02-09 14:18     ` Arnd Bergmann [this message]
2016-02-09 14:18       ` Arnd Bergmann
2016-02-09 14:27       ` Amitkumar Karwar
2016-02-09 14:27         ` Amitkumar Karwar
2016-02-08 21:56 ` Rob Herring
2016-02-08 21:56   ` Rob Herring
2016-02-09 14:00   ` Amitkumar Karwar
2016-02-09 14:00     ` Amitkumar Karwar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6131181.bluDODkWmt@wuerfel \
    --to=arnd@arndb.de \
    --cc=akarwar@marvell.com \
    --cc=cluo@marvell.com \
    --cc=devicetree@vger.kernel.org \
    --cc=huxm@marvell.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=nishants@marvell.com \
    --cc=wnhuang@chromium.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.