From: "Heiko Stübner" <heiko@sntech.de>
To: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
Mark Yao <mark.yao@rock-chips.com>
Subject: Re: [PATCH v2 0/2] drm/rockchip: Optimization vop dpms control
Date: Sat, 24 Jan 2015 16:14:54 +0100 [thread overview]
Message-ID: <4077998.GJIlik9CKQ@phil> (raw)
In-Reply-To: <1421922597-18351-1-git-send-email-mark.yao@rock-chips.com>
Am Donnerstag, 22. Januar 2015, 18:29:55 schrieb Mark Yao:
> drm dpms have many power modes, ON,OFF,SUSPEND,STANDBY, etc.
> but vop only have enable/disable mode, maybe case such bug:
> --> DRM_DPMS_ON: power on vop
> --> DRM_DPMS_SUSPEND: power off vop
> --> DRM_DPMS_OFF: already power off at SUSPEND, crash
> so use a bool val is more suitable.
>
> another problem at vop_crtc_dpms:
> vop_enable()->drm_vblank_on, drm_vblank_on may call vop
> enable vblank. if it happen, vblank enable would failed,
> then cause irq status error. because is_enabled value is set
> after drm_vblank_on.
This series, on a rk3288-firefly board with a sda7123 vga connector
Tested-by: Heiko Stuebner <heiko@sntech.de>
Heiko
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: dri-devel@lists.freedesktop.org
Cc: Mark Yao <mark.yao@rock-chips.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Rob Clark <robdclark@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Daniel Kurtz <djkurtz@chromium.org>,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v2 0/2] drm/rockchip: Optimization vop dpms control
Date: Sat, 24 Jan 2015 16:14:54 +0100 [thread overview]
Message-ID: <4077998.GJIlik9CKQ@phil> (raw)
In-Reply-To: <1421922597-18351-1-git-send-email-mark.yao@rock-chips.com>
Am Donnerstag, 22. Januar 2015, 18:29:55 schrieb Mark Yao:
> drm dpms have many power modes, ON,OFF,SUSPEND,STANDBY, etc.
> but vop only have enable/disable mode, maybe case such bug:
> --> DRM_DPMS_ON: power on vop
> --> DRM_DPMS_SUSPEND: power off vop
> --> DRM_DPMS_OFF: already power off at SUSPEND, crash
> so use a bool val is more suitable.
>
> another problem at vop_crtc_dpms:
> vop_enable()->drm_vblank_on, drm_vblank_on may call vop
> enable vblank. if it happen, vblank enable would failed,
> then cause irq status error. because is_enabled value is set
> after drm_vblank_on.
This series, on a rk3288-firefly board with a sda7123 vga connector
Tested-by: Heiko Stuebner <heiko@sntech.de>
Heiko
next prev parent reply other threads:[~2015-01-24 15:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 10:29 [PATCH v2 0/2] drm/rockchip: Optimization vop dpms control Mark Yao
2015-01-22 10:29 ` Mark Yao
2015-01-22 10:29 ` [PATCH v2 1/2] drm/rockchip: vop use is_enabled instead of dpms mode Mark Yao
2015-01-22 10:29 ` Mark Yao
2015-01-23 2:04 ` Daniel Kurtz
2015-01-23 2:04 ` Daniel Kurtz
2015-01-22 10:29 ` [PATCH v2 2/2] drm/rockchip: vop: set vop enabled after enable iommu Mark Yao
2015-01-22 10:29 ` Mark Yao
2015-01-24 15:14 ` Heiko Stübner [this message]
2015-01-24 15:14 ` [PATCH v2 0/2] drm/rockchip: Optimization vop dpms control Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4077998.GJIlik9CKQ@phil \
--to=heiko@sntech.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.yao@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.