* Regmap regression in next caused by of_iomap change
@ 2016-09-08 18:41 ` Tony Lindgren
0 siblings, 0 replies; 8+ messages in thread
From: Tony Lindgren @ 2016-09-08 18:41 UTC (permalink / raw)
To: Andrey Smirnov, Lee Jones; +Cc: linux-omap, linux-arm-kernel, Arnd Bergmann
Hi,
Looks like commit 39de2c4275a9 ("mfd: syscon: Make use of of_iomap")
makes at least MMC PBIAS regulator stop working on omap3.
That's probably because of_syscon_register uses the now unintialized
struct resource res to set syscon_config.max_register.
I have a strange deja vu feeling that we've been through this
before :) See commit ca668f0edfae ("mfd: syscon: Set regmap max_register
in of_syscon_register")
Maybe we should add comments there instead?
Regards,
Tony
^ permalink raw reply [flat|nested] 8+ messages in thread* Regmap regression in next caused by of_iomap change
@ 2016-09-08 18:41 ` Tony Lindgren
0 siblings, 0 replies; 8+ messages in thread
From: Tony Lindgren @ 2016-09-08 18:41 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
Looks like commit 39de2c4275a9 ("mfd: syscon: Make use of of_iomap")
makes at least MMC PBIAS regulator stop working on omap3.
That's probably because of_syscon_register uses the now unintialized
struct resource res to set syscon_config.max_register.
I have a strange deja vu feeling that we've been through this
before :) See commit ca668f0edfae ("mfd: syscon: Set regmap max_register
in of_syscon_register")
Maybe we should add comments there instead?
Regards,
Tony
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: Regmap regression in next caused by of_iomap change
2016-09-08 18:41 ` Tony Lindgren
@ 2016-09-08 19:59 ` Arnd Bergmann
-1 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2016-09-08 19:59 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: Tony Lindgren, Andrey Smirnov, linux-omap, Lee Jones
On Thursday, September 8, 2016 11:41:12 AM CEST Tony Lindgren wrote:
> Hi,
>
> Looks like commit 39de2c4275a9 ("mfd: syscon: Make use of of_iomap")
> makes at least MMC PBIAS regulator stop working on omap3.
>
> That's probably because of_syscon_register uses the now unintialized
> struct resource res to set syscon_config.max_register.
Looks correct. Lee, please send a revert of that patch to Linus
along with any other fixes you may have.
> I have a strange deja vu feeling that we've been through this
> before See commit ca668f0edfae ("mfd: syscon: Set regmap max_register
> in of_syscon_register")
>
> Maybe we should add comments there instead?
I wonder why gcc didn't detect this case. I usually do my
test builds with -Wmaybe-uninitialized that should have
caught it but didn't.
Arnd
^ permalink raw reply [flat|nested] 8+ messages in thread* Regmap regression in next caused by of_iomap change
@ 2016-09-08 19:59 ` Arnd Bergmann
0 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2016-09-08 19:59 UTC (permalink / raw)
To: linux-arm-kernel
On Thursday, September 8, 2016 11:41:12 AM CEST Tony Lindgren wrote:
> Hi,
>
> Looks like commit 39de2c4275a9 ("mfd: syscon: Make use of of_iomap")
> makes at least MMC PBIAS regulator stop working on omap3.
>
> That's probably because of_syscon_register uses the now unintialized
> struct resource res to set syscon_config.max_register.
Looks correct. Lee, please send a revert of that patch to Linus
along with any other fixes you may have.
> I have a strange deja vu feeling that we've been through this
> before See commit ca668f0edfae ("mfd: syscon: Set regmap max_register
> in of_syscon_register")
>
> Maybe we should add comments there instead?
I wonder why gcc didn't detect this case. I usually do my
test builds with -Wmaybe-uninitialized that should have
caught it but didn't.
Arnd
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: Regmap regression in next caused by of_iomap change
2016-09-08 19:59 ` Arnd Bergmann
@ 2016-09-12 8:55 ` Lee Jones
-1 siblings, 0 replies; 8+ messages in thread
From: Lee Jones @ 2016-09-12 8:55 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Tony Lindgren, Andrey Smirnov, linux-omap, linux-arm-kernel
On Thu, 08 Sep 2016, Arnd Bergmann wrote:
> On Thursday, September 8, 2016 11:41:12 AM CEST Tony Lindgren wrote:
> > Hi,
> >
> > Looks like commit 39de2c4275a9 ("mfd: syscon: Make use of of_iomap")
> > makes at least MMC PBIAS regulator stop working on omap3.
> >
> > That's probably because of_syscon_register uses the now unintialized
> > struct resource res to set syscon_config.max_register.
>
> Looks correct. Lee, please send a revert of that patch to Linus
> along with any other fixes you may have.
No need. It's not in Mainline.
> > I have a strange deja vu feeling that we've been through this
> > before See commit ca668f0edfae ("mfd: syscon: Set regmap max_register
> > in of_syscon_register")
> >
> > Maybe we should add comments there instead?
>
> I wonder why gcc didn't detect this case. I usually do my
> test builds with -Wmaybe-uninitialized that should have
> caught it but didn't.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread* Regmap regression in next caused by of_iomap change
@ 2016-09-12 8:55 ` Lee Jones
0 siblings, 0 replies; 8+ messages in thread
From: Lee Jones @ 2016-09-12 8:55 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, 08 Sep 2016, Arnd Bergmann wrote:
> On Thursday, September 8, 2016 11:41:12 AM CEST Tony Lindgren wrote:
> > Hi,
> >
> > Looks like commit 39de2c4275a9 ("mfd: syscon: Make use of of_iomap")
> > makes at least MMC PBIAS regulator stop working on omap3.
> >
> > That's probably because of_syscon_register uses the now unintialized
> > struct resource res to set syscon_config.max_register.
>
> Looks correct. Lee, please send a revert of that patch to Linus
> along with any other fixes you may have.
No need. It's not in Mainline.
> > I have a strange deja vu feeling that we've been through this
> > before See commit ca668f0edfae ("mfd: syscon: Set regmap max_register
> > in of_syscon_register")
> >
> > Maybe we should add comments there instead?
>
> I wonder why gcc didn't detect this case. I usually do my
> test builds with -Wmaybe-uninitialized that should have
> caught it but didn't.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: Regmap regression in next caused by of_iomap change
2016-09-12 8:55 ` Lee Jones
@ 2016-09-12 8:55 ` Arnd Bergmann
-1 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2016-09-12 8:55 UTC (permalink / raw)
To: Lee Jones; +Cc: Tony Lindgren, Andrey Smirnov, linux-omap, linux-arm-kernel
On Monday, September 12, 2016 9:55:27 AM CEST Lee Jones wrote:
> On Thu, 08 Sep 2016, Arnd Bergmann wrote:
>
> > On Thursday, September 8, 2016 11:41:12 AM CEST Tony Lindgren wrote:
> > > Hi,
> > >
> > > Looks like commit 39de2c4275a9 ("mfd: syscon: Make use of of_iomap")
> > > makes at least MMC PBIAS regulator stop working on omap3.
> > >
> > > That's probably because of_syscon_register uses the now unintialized
> > > struct resource res to set syscon_config.max_register.
> >
> > Looks correct. Lee, please send a revert of that patch to Linus
> > along with any other fixes you may have.
>
> No need. It's not in Mainline.
>
Ah, good, I misread the history then.
Arnd
^ permalink raw reply [flat|nested] 8+ messages in thread* Regmap regression in next caused by of_iomap change
@ 2016-09-12 8:55 ` Arnd Bergmann
0 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2016-09-12 8:55 UTC (permalink / raw)
To: linux-arm-kernel
On Monday, September 12, 2016 9:55:27 AM CEST Lee Jones wrote:
> On Thu, 08 Sep 2016, Arnd Bergmann wrote:
>
> > On Thursday, September 8, 2016 11:41:12 AM CEST Tony Lindgren wrote:
> > > Hi,
> > >
> > > Looks like commit 39de2c4275a9 ("mfd: syscon: Make use of of_iomap")
> > > makes at least MMC PBIAS regulator stop working on omap3.
> > >
> > > That's probably because of_syscon_register uses the now unintialized
> > > struct resource res to set syscon_config.max_register.
> >
> > Looks correct. Lee, please send a revert of that patch to Linus
> > along with any other fixes you may have.
>
> No need. It's not in Mainline.
>
Ah, good, I misread the history then.
Arnd
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-09-12 8:55 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-08 18:41 Regmap regression in next caused by of_iomap change Tony Lindgren
2016-09-08 18:41 ` Tony Lindgren
2016-09-08 19:59 ` Arnd Bergmann
2016-09-08 19:59 ` Arnd Bergmann
2016-09-12 8:55 ` Lee Jones
2016-09-12 8:55 ` Lee Jones
2016-09-12 8:55 ` Arnd Bergmann
2016-09-12 8:55 ` Arnd Bergmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.