All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brad Fisher <brad@info-link.net>
To: netfilter-devel@lists.netfilter.org
Subject: [PATCH] Minor fix for patchlets which modify multiple projects
Date: Wed, 12 May 2004 14:04:44 -0500	[thread overview]
Message-ID: <40A2754C.F4AA6CEF@info-link.net> (raw)

While converting a match of mine to pom-ng, I noticed that
apply_patchlet doesn't properly determine the list of projects which are
affected by the patchlet.  In my case, the patch would be incompletely
applied - the kernel space part would apply, but the userspace part
would not.  The following patch (agains pom-ng cvs) should fix this.
-Brad Fisher

Index: Netfilter_POM.pm
===================================================================
RCS file: /cvspublic/patch-o-matic-ng/Netfilter_POM.pm,v
retrieving revision 1.26
diff -u -r1.26 Netfilter_POM.pm
--- Netfilter_POM.pm    11 May 2004 13:53:13 -0000      1.26
+++ Netfilter_POM.pm    12 May 2004 19:02:22 -0000
@@ -852,9 +852,11 @@
        my(@projects);

        # print Dumper($patchlet);
-       @projects = keys %{{ keys %{$patchlet->{files}},
-                            keys %{$patchlet->{patch}},
-                            keys %{$patchlet->{ladds}} }};
+       my %projects = ( );
+       foreach my $p ( keys %{$patchlet->{files}}, keys
%{$patchlet->{patch}}, keys %{$patchlet->{ladds}}) {
+               $projects{$p} = 1;
+       }
+       @projects = keys %projects;

        foreach my $proj (@projects) {
                return 0 unless ($self->apply_newfiles($patchlet, $proj,
$revert, $test, $copy)

             reply	other threads:[~2004-05-12 19:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-12 19:04 Brad Fisher [this message]
2004-05-13  3:02 ` [PATCH] Minor fix for patchlets which modify multiple projects Patrick McHardy
2004-05-13 16:09   ` Brad Fisher
2004-05-13 18:08     ` Patrick McHardy
2004-05-14  8:32 ` Jozsef Kadlecsik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40A2754C.F4AA6CEF@info-link.net \
    --to=brad@info-link.net \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.