Re: [PATCH] Minor fix for patchlets which modify multiple projects

[Patrick McHardy <kaber@trash.net>]

[-- Attachment #1: Type: text/plain, Size: 583 bytes --]

Brad Fisher wrote:

>While converting a match of mine to pom-ng, I noticed that
>apply_patchlet doesn't properly determine the list of projects which are
>affected by the patchlet.  In my case, the patch would be incompletely
>applied - the kernel space part would apply, but the userspace part
>would not.  The following patch (agains pom-ng cvs) should fix this.
>-Brad Fisher
>

Thanks Brad, I've applied a small variation of this, because I don't know if
perl will complain about two equally named variables (@projects and %projects)
with warnings turned on.

Regards
Patrick




[-- Attachment #2: y --]
[-- Type: text/plain, Size: 775 bytes --]

Index: Netfilter_POM.pm
===================================================================
RCS file: /cvsroot/patch-o-matic-ng/Netfilter_POM.pm,v
retrieving revision 1.26
diff -u -r1.26 Netfilter_POM.pm
--- Netfilter_POM.pm	11 May 2004 13:53:13 -0000	1.26
+++ Netfilter_POM.pm	13 May 2004 02:57:05 -0000
@@ -852,9 +852,11 @@
 	my(@projects);
 
 	# print Dumper($patchlet);
-	@projects = keys %{{ keys %{$patchlet->{files}}, 
-			     keys %{$patchlet->{patch}},
-			     keys %{$patchlet->{ladds}} }};
+	foreach my $p ( keys %{$patchlet->{files}},
+	                keys %{$patchlet->{patch}},
+			keys %{$patchlet->{ladds}} ) {
+		push @projects, $p;
+	}
 
 	foreach my $proj (@projects) {
 		return 0 unless ($self->apply_newfiles($patchlet, $proj, $revert, $test, $copy)