Re: [PATCH] Minor fix for patchlets which modify multiple projects

[Brad Fisher <brad@info-link.net>]

Patrick McHardy wrote:

> Thanks Brad, I've applied a small variation of this, because I don't know if
> perl will complain about two equally named variables (@projects and %projects)
> with warnings turned on.

I don't think your patch is quite right.  You can end up having the same project listed multiple
times with your patch, which is why I used the separate hash - key collisions are reduced to single
entries.  I guess as long as it is no problem for a project to be processed multiple times, then
your patch will be OK, but if that isn't the case, you may want to look into it again.

As far as variables with the same name and different types, I don't believe Perl complains.  I
typically program with 'use strict', which I believe enables all warnings, and have used naming
like this before.  Of course it does add quite a bit of ambiguity, so renaming the %projects hash
would probably be a good idea if you choose to use a variation of my patch.

> Regards
> Patrick

-Brad