All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian King <brking@us.ibm.com>
To: kernel-janitors@vger.kernel.org
Subject: [Kernel-janitors] Re: no set_current_state() before
Date: Tue, 13 Jul 2004 17:57:37 +0000	[thread overview]
Message-ID: <40F42291.5010202@us.ibm.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 742 bytes --]

Since I'm not seeing a return value on msleep to be able to tell if it 
terminates prematurely, TASK_UNINTERRUPTIBLE is the preferred state.

Thanks

-Brian

Nishanth Aravamudan wrote:
> Hi,
> 
> In continuing to replace, where appropriate, code with msleep() calls, I 
> ran across the following file(s) / function(s), which do not invoke 
> set_current_state() before schedule_timeout(), which causes the latter 
> to return immediately:
> 
> drivers/scsi/ipr.c::ipr_store_diagnostics()
> 
> If someone could tell me which state (TASK_INTERRUPTIBLE or 
> TASK_UNINTERRUPTIBLE) is desired, I can fix this and perhaps replace the 
> calls with msleep().
> 
> Thanks,
> Nish
> 

-- 
Brian King
eServer Storage I/O
IBM Linux Technology Center


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

             reply	other threads:[~2004-07-13 17:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-13 17:57 Brian King [this message]
2004-07-14  7:20 ` [Kernel-janitors] Re: no set_current_state() before Martin Schwidefsky
2004-07-16 10:01 ` [Kernel-janitors] " FarSite Support

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40F42291.5010202@us.ibm.com \
    --to=brking@us.ibm.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.