[Kernel-janitors] Re: no set_current_state() before

[Kernel-janitors] Re: no set_current_state() before

[Brian King]

[-- Attachment #1: Type: text/plain, Size: 742 bytes --]

Since I'm not seeing a return value on msleep to be able to tell if it 
terminates prematurely, TASK_UNINTERRUPTIBLE is the preferred state.

Thanks

-Brian

Nishanth Aravamudan wrote:
> Hi,
> 
> In continuing to replace, where appropriate, code with msleep() calls, I 
> ran across the following file(s) / function(s), which do not invoke 
> set_current_state() before schedule_timeout(), which causes the latter 
> to return immediately:
> 
> drivers/scsi/ipr.c::ipr_store_diagnostics()
> 
> If someone could tell me which state (TASK_INTERRUPTIBLE or 
> TASK_UNINTERRUPTIBLE) is desired, I can fix this and perhaps replace the 
> calls with msleep().
> 
> Thanks,
> Nish
> 

-- 
Brian King
eServer Storage I/O
IBM Linux Technology Center


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

[Kernel-janitors] Re: no set_current_state() before

[Martin Schwidefsky]

Hi Nish,
in both cases TASK_UNINTERRUPTIBLE is the correct state and both calls
are indeed broken. Thanks for the hint, I'll fix this in our CVS right
away.

blue skies,
   Martin

Linux/390 Design & Development, IBM Deutschland Entwicklung GmbH
Schönaicherstr. 220, D-71032 Böblingen, Telefon: 49 - (0)7031 - 16-2247
E-Mail: schwidefsky@de.ibm.com


_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

[Kernel-janitors] RE: no set_current_state() before

[FarSite Support]

[-- Attachment #1: Type: text/plain, Size: 1131 bytes --]

Hi,
	sorry for the delay in responding to this e-mail, I have been
out of the office for a couple of days.

	In answer to your question TASK_UNINTERRUPTIBLE would be
appropriate for this call.  Thank you for pointing it out.  I assume
that you will be making the change in the Kernel source tree.


Kind Regards

Kevin Curtis
Linux Development
FarSite Communications Ltd
http://www.farsite.co.uk
tel:  +44 1256 330461
fax:  +44 1256 854931

-----Original Message-----
From: Nishanth Aravamudan [mailto:nacc@us.ibm.com] 
Sent: 13 July 2004 18:21
To: kevin.curtis@farsite.co.uk
Cc: kernel-janitors@lists.osdl.org
Subject: no set_current_state() before schedule_timeout()


Hi,

In continuing to replace, where appropriate, code with msleep() calls, I

ran across the following file(s) / function(s), which do not invoke 
set_current_state() before schedule_timeout(), which causes the latter 
to return immediately:

drivers/net/wan/farsync.c::fst_issue_cmd()

If someone could tell me which state (TASK_INTERRUPTIBLE or 
TASK_UNINTERRUPTIBLE) is desired, I can fix this and perhaps replace the

calls with msleep().

Thanks,
Nish



[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors