From: Patrick McHardy <kaber@trash.net>
To: "David S. Miller" <davem@redhat.com>
Cc: shemminger@osdl.org, netdev@oss.sgi.com, devik@cdi.cz
Subject: Re: [PATCH 2.6]: Make packet scheduler clock source configurable
Date: Fri, 23 Jul 2004 02:52:32 +0200 [thread overview]
Message-ID: <41006150.9000702@trash.net> (raw)
In-Reply-To: <20040722171752.341d2476.davem@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 688 bytes --]
David S. Miller wrote:
>>It needs to increment at slightly above 1Mhz, otherwise delay will
>>be zero after this division and everything will fall apart:
>>delay /= rdelay.
>
> I see. I know for a fact that sparc64 meets this criterion, and
> I'm pretty sure ppc64 does too.
I'm pretty sure x86, x86_64, alpha, sparc64, ppc64 and ia64 can
be used. I'm not sure if the frequency of all ppcs is high enough,
so I won't add support for them.
> We could bug check this in psched calibration, in fact I think
> we should.
Done by this patch. I used BUG_ON instead of just printing a warning
because using packet schedulers after this error will cause a division
by zero.
Regards
Patrick
[-- Attachment #2: psched-bug_on_invalid_cycles.diff --]
[-- Type: application/octect-stream, Size: 761 bytes --]
next prev parent reply other threads:[~2004-07-23 0:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-13 2:21 [PATCH 2.6]: Make packet scheduler clock source configurable Patrick McHardy
2004-07-13 3:35 ` shemminger
2004-07-13 3:50 ` David S. Miller
[not found] ` <40F4862D.3070802@trash.net>
[not found] ` <40F4AC8B.40706@trash.net>
2004-07-21 21:31 ` David S. Miller
2004-07-22 23:36 ` Patrick McHardy
2004-07-23 0:17 ` David S. Miller
2004-07-23 0:52 ` Patrick McHardy [this message]
2004-07-23 1:00 ` Patrick McHardy
2004-07-23 1:03 ` David S. Miller
2004-07-23 17:14 ` Patrick McHardy
2004-07-23 17:53 ` Stephen Hemminger
2004-07-23 20:54 ` David S. Miller
2004-07-23 23:18 ` Patrick McHardy
2004-07-25 6:27 ` David S. Miller
2004-07-25 21:56 ` Patrick McHardy
2004-07-26 0:02 ` David S. Miller
2004-07-23 20:57 ` David S. Miller
2004-07-23 23:21 ` Patrick McHardy
2004-07-13 16:16 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41006150.9000702@trash.net \
--to=kaber@trash.net \
--cc=davem@redhat.com \
--cc=devik@cdi.cz \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.