All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: "David S. Miller" <davem@redhat.com>
Cc: shemminger@osdl.org, netdev@oss.sgi.com, devik@cdi.cz
Subject: Re: [PATCH 2.6]: Make packet scheduler clock source configurable
Date: Sat, 24 Jul 2004 01:18:50 +0200	[thread overview]
Message-ID: <41019CDA.9050401@trash.net> (raw)
In-Reply-To: <20040723135459.2ee5c42c.davem@redhat.com>

David S. Miller wrote:
> We can't use this stuff on Alpha, it's cycle counter overflows after
> just 10 minutes.  It works very strangely, something like only the
> lower 32-bits are guarenteed to be continually incrementing.

The code (although racy) can handle 32-bit cycle counters. get_cycles()
on alpha returns a 32-bit value, so psched_tick calls PSCHED_GET_TIME
to adjust psched_time_base once a second. It is basically the same as
before. This is the second condition for this too work, besides
get_cycles() incrementing at >1MHz, it needs to return either a 32-bit
value and really use the full 32 bit or return something bigger, which
is assumed not to overflow. Alpha seems to satisfy both conditions.

> I'm going to apply your patch and delete the Alpha parts.
> Meanwhile, ping Richard Henderson (rth@redhat.com) or one
> of the other Alpha experts for me to get confirmation on
> this stuff.

Even better.

Regards
Patrick

  reply	other threads:[~2004-07-23 23:18 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-13  2:21 [PATCH 2.6]: Make packet scheduler clock source configurable Patrick McHardy
2004-07-13  3:35 ` shemminger
2004-07-13  3:50   ` David S. Miller
     [not found]     ` <40F4862D.3070802@trash.net>
     [not found]       ` <40F4AC8B.40706@trash.net>
2004-07-21 21:31         ` David S. Miller
2004-07-22 23:36           ` Patrick McHardy
2004-07-23  0:17             ` David S. Miller
2004-07-23  0:52               ` Patrick McHardy
2004-07-23  1:00                 ` Patrick McHardy
2004-07-23  1:03                   ` David S. Miller
2004-07-23 17:14                 ` Patrick McHardy
2004-07-23 17:53                   ` Stephen Hemminger
2004-07-23 20:54                   ` David S. Miller
2004-07-23 23:18                     ` Patrick McHardy [this message]
2004-07-25  6:27                       ` David S. Miller
2004-07-25 21:56                         ` Patrick McHardy
2004-07-26  0:02                           ` David S. Miller
2004-07-23 20:57                   ` David S. Miller
2004-07-23 23:21                     ` Patrick McHardy
2004-07-13 16:16 ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41019CDA.9050401@trash.net \
    --to=kaber@trash.net \
    --cc=davem@redhat.com \
    --cc=devik@cdi.cz \
    --cc=netdev@oss.sgi.com \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.