* [PATCH] ppc64 SMT bugfix
@ 2004-07-27 18:44 Joel Schopp
2004-07-29 5:52 ` Anton Blanchard
0 siblings, 1 reply; 2+ messages in thread
From: Joel Schopp @ 2004-07-27 18:44 UTC (permalink / raw)
To: paulus, anton, akpm; +Cc: linuxppc64-dev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 263 bytes --]
This patch is fairly straightforward. maxcpus should be per SMT thread
and not per physical processor. SUSE picked this up back in May (was
discussed on ppc64 mailing list) and has had no trouble with it.
Signed-off-by: Joel Schopp <jschopp@austin.ibm.com>
[-- Attachment #2: smtjul27.patch --]
[-- Type: text/plain, Size: 484 bytes --]
diff -Nru a/arch/ppc64/kernel/smp.c b/arch/ppc64/kernel/smp.c
--- a/arch/ppc64/kernel/smp.c Tue Jul 27 13:44:45 2004
+++ b/arch/ppc64/kernel/smp.c Tue Jul 27 13:44:45 2004
@@ -422,7 +422,11 @@
}
maxcpus = ireg[num_addr_cell + num_size_cell];
- /* DRENG need to account for threads here too */
+
+ /* Double maxcpus for processors which have SMT capability */
+ if (cur_cpu_spec->cpu_features & CPU_FTR_SMT)
+ maxcpus *= 2;
+
if (maxcpus > NR_CPUS) {
printk(KERN_WARNING
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ppc64 SMT bugfix
2004-07-27 18:44 [PATCH] ppc64 SMT bugfix Joel Schopp
@ 2004-07-29 5:52 ` Anton Blanchard
0 siblings, 0 replies; 2+ messages in thread
From: Anton Blanchard @ 2004-07-29 5:52 UTC (permalink / raw)
To: Joel Schopp; +Cc: paulus, akpm, linuxppc64-dev, linux-kernel
Hi Joel,
Yep, looks good to me. Longer term we should allow an aribtrary number
of siblings but we can fix that when the cpu_to_sibling stuff goes in.
Anton
--
From: Joel Schopp <jschopp@austin.ibm.com>
This patch is fairly straightforward. maxcpus should be per SMT thread
and not per physical processor.
Signed-off-by: Joel Schopp <jschopp@austin.ibm.com>
Signed-off-by: Anton Blanchard <anton@samba.org>
diff -Nru a/arch/ppc64/kernel/smp.c b/arch/ppc64/kernel/smp.c
--- a/arch/ppc64/kernel/smp.c Tue Jul 27 13:44:45 2004
+++ b/arch/ppc64/kernel/smp.c Tue Jul 27 13:44:45 2004
@@ -422,7 +422,11 @@
}
maxcpus = ireg[num_addr_cell + num_size_cell];
- /* DRENG need to account for threads here too */
+
+ /* Double maxcpus for processors which have SMT capability */
+ if (cur_cpu_spec->cpu_features & CPU_FTR_SMT)
+ maxcpus *= 2;
+
if (maxcpus > NR_CPUS) {
printk(KERN_WARNING
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-07-29 5:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-07-27 18:44 [PATCH] ppc64 SMT bugfix Joel Schopp
2004-07-29 5:52 ` Anton Blanchard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.