[Kernel-janitors] ip_gre.c: update last_rx after netif_rx

[Kernel-janitors] ip_gre.c: update last_rx after netif_rx

[Jay Bourque]

Fix to update last_rx after netif_rx
This is my first patch so I'd appreciate any feedback.

-Jay

--- linux-2.6.8.1/net/ipv4/ip_gre.c    Sat Aug 14 05:55:48 2004
+++ linux-2.6.8.1/net/ipv4/ip_gre.c.new    Sat Aug 14 12:17:16 2004
@@ -646,6 +646,7 @@ int ipgre_rcv(struct sk_buff *skb)
         nf_reset(skb);
         ipgre_ecn_decapsulate(iph, skb);
         netif_rx(skb);
+       tunnel->dev->last_rx = jiffies;
         read_unlock(&ipgre_lock);
         return(0);
     }

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [Kernel-janitors] ip_gre.c: update last_rx after netif_rx

[maximilian attems]

[-- Attachment #1: Type: text/plain, Size: 986 bytes --]

On Sat, 14 Aug 2004, Jay Bourque wrote:

> Fix to update last_rx after netif_rx
> This is my first patch so I'd appreciate any feedback.
> 
> -Jay
> 
> --- linux-2.6.8.1/net/ipv4/ip_gre.c    Sat Aug 14 05:55:48 2004
> +++ linux-2.6.8.1/net/ipv4/ip_gre.c.new    Sat Aug 14 12:17:16 2004
> @@ -646,6 +646,7 @@ int ipgre_rcv(struct sk_buff *skb)
>         nf_reset(skb);
>         ipgre_ecn_decapsulate(iph, skb);
>         netif_rx(skb);
> +       tunnel->dev->last_rx = jiffies;
>         read_unlock(&ipgre_lock);
>         return(0);
>     }

well i hadn't researched that TODO item, when saying go for it,
sorry, but grepping for 'last_rx' in 2.6.8 shows only 2 items.
Arnaldo did lots of conversion at the beginning of the 2.4.x serie.
i think this task should be removed from TODO as the way to go is to
have correct rx pathes, but i'm not that good in networking code.
see: http://www.ussg.iu.edu/hypermail/linux/kernel/0302.2/1314.html

please confirm Arnaldo?

thanks
 
--
maks


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [Kernel-janitors] ip_gre.c: update last_rx after netif_rx

[maximilian attems]

[-- Attachment #1: Type: text/plain, Size: 1008 bytes --]

On Sat, 14 Aug 2004, Jay Bourque wrote:

> Fix to update last_rx after netif_rx
> This is my first patch so I'd appreciate any feedback.
> 
> -Jay
> 
> --- linux-2.6.8.1/net/ipv4/ip_gre.c    Sat Aug 14 05:55:48 2004
> +++ linux-2.6.8.1/net/ipv4/ip_gre.c.new    Sat Aug 14 12:17:16 2004
> @@ -646,6 +646,7 @@ int ipgre_rcv(struct sk_buff *skb)
>         nf_reset(skb);
>         ipgre_ecn_decapsulate(iph, skb);
>         netif_rx(skb);
> +       tunnel->dev->last_rx = jiffies;
>         read_unlock(&ipgre_lock);
>         return(0);
>     }
doesn't look complete, see patch below, but please read on:

the kj todo has an entry about "update last_rx after netif_rx", 
i wonder what that timestamping is good for, and newer 
sources 2.4.27 and 2.6.8 show 2 occurences of last_rx.

patches doing that are for young 2.4:
http://seclists.org/linux-kernel/2001/Feb/4846.html

i presume that this task is outdated,
thanks for putting light on that. 



--
maks
kernel janitor  	http://janitor.kernelnewbies.org/


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [Kernel-janitors] ip_gre.c: update last_rx after netif_rx

[maximilian attems]

On Sat, 14 Aug 2004, Jay Bourque wrote:

> Fix to update last_rx after netif_rx
> This is my first patch so I'd appreciate any feedback.
> 
> -Jay
> 
> --- linux-2.6.8.1/net/ipv4/ip_gre.c    Sat Aug 14 05:55:48 2004
> +++ linux-2.6.8.1/net/ipv4/ip_gre.c.new    Sat Aug 14 12:17:16 2004
> @@ -646,6 +646,7 @@ int ipgre_rcv(struct sk_buff *skb)
>         nf_reset(skb);
>         ipgre_ecn_decapsulate(iph, skb);
>         netif_rx(skb);
> +       tunnel->dev->last_rx = jiffies;
>         read_unlock(&ipgre_lock);
>         return(0);
>     }
doesn't look complete, see patch below, but please read on:

the kj todo has an entry about "update last_rx after netif_rx", 
i wonder what that timestamping is good for, and newer 
sources 2.4.27 and 2.6.8 show 2 occurences of last_rx.

patches doing that are for young 2.4:
http://seclists.org/linux-kernel/2001/Feb/4846.html

i presume that this task is outdated,
thanks for putting light on that. 



--
maks
kernel janitor  	http://janitor.kernelnewbies.org/

Re: [Kernel-janitors] ip_gre.c: update last_rx after netif_rx

[max attems]

[-- Attachment #1: Type: text/plain, Size: 526 bytes --]

hello jay,

On Sat, 21 Aug 2004, maximilian attems wrote:

> On Sat, 14 Aug 2004, Jay Bourque wrote:
> 
> > Fix to update last_rx after netif_rx
> > This is my first patch so I'd appreciate any feedback.
> > 
> > -Jay
..
 
> i presume that this task is outdated,

well nobody is really interested in aboves issue,
thanks for bringing up that old dust,
task removed from kernel janitor TODO.

please choose another item of the kj TODO list?
happy to read you soon.


--
maks
kernel janitor  	http://janitor.kernelnewbies.org/


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [Kernel-janitors] ip_gre.c: update last_rx after netif_rx

[max attems]

hello jay,

On Sat, 21 Aug 2004, maximilian attems wrote:

> On Sat, 14 Aug 2004, Jay Bourque wrote:
> 
> > Fix to update last_rx after netif_rx
> > This is my first patch so I'd appreciate any feedback.
> > 
> > -Jay
..
 
> i presume that this task is outdated,

well nobody is really interested in aboves issue,
thanks for bringing up that old dust,
task removed from kernel janitor TODO.

please choose another item of the kj TODO list?
happy to read you soon.


--
maks
kernel janitor  	http://janitor.kernelnewbies.org/