From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: "Hunt, David" <david.hunt@intel.com>,
Olivier Matz <olivier.matz@6wind.com>,
dev@dpdk.org, bruce.richardson@intel.com,
konstantin.ananyev@intel.com
Subject: Re: [PATCH] mbuf: replace c memcpy code semantics with optimized rte_memcpy
Date: Fri, 27 May 2016 17:05:45 +0200 [thread overview]
Message-ID: <4125316.GWKk7IhZzc@xps13> (raw)
In-Reply-To: <20160527114205.GA15118@localhost.localdomain>
2016-05-27 17:12, Jerin Jacob:
> IMHO, I think we should have means to abstract this _logical_ changes
> under conditional compilation flags and any arch/platform can choose
> to select what it suites better for that arch/platform.
>
> We may NOT need to have frequent patches to select the specific
> configuration, but logical patches under compilation flags can be accepted and
> each arch/platform can choose specific set configuration when we make
> the final release candidate for the release.
>
> Any thoughts?
Yes having some #ifdefs for arch configuration may be reasonnable.
But other methods must be preffered first:
1/ try implementing the function in arch-specific files
2/ and check at runtime if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_X
3/ or check #ifdef RTE_MACHINE_CPUFLAG_X
4/ or check #ifdef RTE_ARCH_Y
5/ or check a specific #ifdef RTE_FEATURE_NAME to choose in config files
The option 2 is a nice to have which implies other options.
Maybe that doc/guides/contributing/design.rst needs to be updated.
next prev parent reply other threads:[~2016-05-27 15:05 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 14:50 [PATCH] mbuf: replace c memcpy code semantics with optimized rte_memcpy Jerin Jacob
2016-05-24 14:59 ` Olivier Matz
2016-05-24 15:17 ` Jerin Jacob
2016-05-27 10:24 ` Hunt, David
2016-05-27 11:42 ` Jerin Jacob
2016-05-27 15:05 ` Thomas Monjalon [this message]
2016-05-30 8:44 ` Olivier Matz
2016-05-27 13:45 ` Hunt, David
2016-06-24 15:56 ` Hunt, David
2016-06-24 16:02 ` Olivier Matz
2016-05-26 8:07 ` [PATCH v2] mempool: " Jerin Jacob
2016-05-30 8:45 ` Olivier Matz
2016-05-31 12:58 ` Jerin Jacob
2016-05-31 21:05 ` Olivier MATZ
2016-06-01 7:00 ` Jerin Jacob
2016-06-02 7:36 ` Olivier MATZ
2016-06-02 9:39 ` Jerin Jacob
2016-06-02 21:16 ` Olivier MATZ
2016-06-03 7:02 ` Jerin Jacob
2016-06-17 10:40 ` Olivier Matz
2016-06-24 16:04 ` Olivier Matz
2016-06-30 9:41 ` Thomas Monjalon
2016-06-30 11:38 ` Jerin Jacob
2016-06-30 12:16 ` [PATCH v3] " Jerin Jacob
2016-06-30 17:28 ` Thomas Monjalon
2016-07-05 8:43 ` Ferruh Yigit
2016-07-05 11:32 ` Yuanhan Liu
2016-07-05 13:13 ` Jerin Jacob
2016-07-05 13:42 ` Yuanhan Liu
2016-07-05 14:09 ` Ferruh Yigit
2016-07-06 16:21 ` Ferruh Yigit
2016-07-07 13:51 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4125316.GWKk7IhZzc@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=bruce.richardson@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=konstantin.ananyev@intel.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.