From: Brad Campbell <brad@wasp.net.au>
Cc: Jeff Garzik <jgarzik@pobox.com>,
linux-ide@vger.kernel.org,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] libata ATA vs SATA detection and workaround.
Date: Mon, 30 Aug 2004 18:57:28 +0400 [thread overview]
Message-ID: <41334058.4050902@wasp.net.au> (raw)
In-Reply-To: <41333CDC.5040106@wasp.net.au>
[-- Attachment #1: Type: text/plain, Size: 232 bytes --]
Brad Campbell wrote:
>
> It works here anyway.
> Patch against vanilla 2.6.9-rc1 attached (including your ata.h patch)
>
Lets try this one that won't undo the work that the sata_sil Seagate/Maxtor blacklist does!
Regards,
Brad.
[-- Attachment #2: diff2 --]
[-- Type: text/plain, Size: 1509 bytes --]
diff -ur orig/linux/drivers/scsi/libata-core.c linux-2.6.9-rc1/drivers/scsi/libata-core.c
--- orig/linux/drivers/scsi/libata-core.c 2004-08-30 18:52:54.000000000 +0400
+++ linux-2.6.9-rc1/drivers/scsi/libata-core.c 2004-08-30 18:53:42.000000000 +0400
@@ -1150,6 +1150,15 @@
ata_dev_identify(ap, i);
if (ata_dev_present(&ap->device[i])) {
found = 1;
+ /* limit bridge transfers to udma5, 200 sectors */
+ if ((ap->cbl == ATA_CBL_SATA) && (!ata_id_is_sata(ap->device))) {
+ printk(KERN_INFO "ata%u(%u): applying bridge limits\n",
+ ap->id, ap->device->devno);
+ ap->udma_mask &= ATA_UDMA5;
+ ap->host->max_sectors = ATA_MAX_SECTORS;
+ ap->host->hostt->max_sectors = ATA_MAX_SECTORS;
+ ap->device->flags |= ATA_DFLAG_LOCK_SECTORS;
+ }
if (ap->ops->dev_config)
ap->ops->dev_config(ap, &ap->device[i]);
}
@@ -1226,7 +1235,7 @@
ata_port_disable(ap);
return;
}
-
+ ap->cbl = ATA_CBL_SATA;
ata_bus_reset(ap);
}
diff -ur orig/linux/include/linux/ata.h linux-2.6.9-rc1/include/linux/ata.h
--- orig/linux/include/linux/ata.h 2004-08-30 18:52:54.000000000 +0400
+++ linux-2.6.9-rc1/include/linux/ata.h 2004-08-30 18:42:41.000000000 +0400
@@ -218,6 +218,7 @@
};
#define ata_id_is_ata(dev) (((dev)->id[0] & (1 << 15)) == 0)
+#define ata_id_is_sata(dev) ((dev)->id[93] == 0)
#define ata_id_rahead_enabled(dev) ((dev)->id[85] & (1 << 6))
#define ata_id_wcache_enabled(dev) ((dev)->id[85] & (1 << 5))
#define ata_id_has_flush(dev) ((dev)->id[83] & (1 << 12))
WARNING: multiple messages have this Message-ID (diff)
From: Brad Campbell <brad@wasp.net.au>
To: unlisted-recipients:; (no To-header on input)
Cc: Jeff Garzik <jgarzik@pobox.com>,
linux-ide@vger.kernel.org,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] libata ATA vs SATA detection and workaround.
Date: Mon, 30 Aug 2004 18:57:28 +0400 [thread overview]
Message-ID: <41334058.4050902@wasp.net.au> (raw)
In-Reply-To: <41333CDC.5040106@wasp.net.au>
[-- Attachment #1: Type: text/plain, Size: 232 bytes --]
Brad Campbell wrote:
>
> It works here anyway.
> Patch against vanilla 2.6.9-rc1 attached (including your ata.h patch)
>
Lets try this one that won't undo the work that the sata_sil Seagate/Maxtor blacklist does!
Regards,
Brad.
[-- Attachment #2: diff2 --]
[-- Type: text/plain, Size: 1509 bytes --]
diff -ur orig/linux/drivers/scsi/libata-core.c linux-2.6.9-rc1/drivers/scsi/libata-core.c
--- orig/linux/drivers/scsi/libata-core.c 2004-08-30 18:52:54.000000000 +0400
+++ linux-2.6.9-rc1/drivers/scsi/libata-core.c 2004-08-30 18:53:42.000000000 +0400
@@ -1150,6 +1150,15 @@
ata_dev_identify(ap, i);
if (ata_dev_present(&ap->device[i])) {
found = 1;
+ /* limit bridge transfers to udma5, 200 sectors */
+ if ((ap->cbl == ATA_CBL_SATA) && (!ata_id_is_sata(ap->device))) {
+ printk(KERN_INFO "ata%u(%u): applying bridge limits\n",
+ ap->id, ap->device->devno);
+ ap->udma_mask &= ATA_UDMA5;
+ ap->host->max_sectors = ATA_MAX_SECTORS;
+ ap->host->hostt->max_sectors = ATA_MAX_SECTORS;
+ ap->device->flags |= ATA_DFLAG_LOCK_SECTORS;
+ }
if (ap->ops->dev_config)
ap->ops->dev_config(ap, &ap->device[i]);
}
@@ -1226,7 +1235,7 @@
ata_port_disable(ap);
return;
}
-
+ ap->cbl = ATA_CBL_SATA;
ata_bus_reset(ap);
}
diff -ur orig/linux/include/linux/ata.h linux-2.6.9-rc1/include/linux/ata.h
--- orig/linux/include/linux/ata.h 2004-08-30 18:52:54.000000000 +0400
+++ linux-2.6.9-rc1/include/linux/ata.h 2004-08-30 18:42:41.000000000 +0400
@@ -218,6 +218,7 @@
};
#define ata_id_is_ata(dev) (((dev)->id[0] & (1 << 15)) == 0)
+#define ata_id_is_sata(dev) ((dev)->id[93] == 0)
#define ata_id_rahead_enabled(dev) ((dev)->id[85] & (1 << 6))
#define ata_id_wcache_enabled(dev) ((dev)->id[85] & (1 << 5))
#define ata_id_has_flush(dev) ((dev)->id[83] & (1 << 12))
next prev parent reply other threads:[~2004-08-30 14:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-29 17:09 libata dev_config call order wrong Brad Campbell
2004-08-29 17:29 ` Jeff Garzik
2004-08-29 17:47 ` Brad Campbell
2004-08-29 17:59 ` Jeff Garzik
2004-08-29 18:25 ` Jeff Garzik
2004-08-29 18:59 ` Alan Cox
2004-08-30 9:12 ` Brad Campbell
2004-08-30 13:22 ` Alan Cox
2004-08-30 14:38 ` Brad Campbell
2004-08-30 14:42 ` [PATCH] libata ATA vs SATA detection and workaround Brad Campbell
2004-08-30 14:57 ` Brad Campbell [this message]
2004-08-30 14:57 ` Brad Campbell
2004-08-30 16:06 ` Jeff Garzik
2004-08-30 16:34 ` Brad Campbell
2004-08-30 16:37 ` Jeff Garzik
2004-08-30 17:17 ` Brad Campbell
2004-08-30 17:59 ` Jeff Garzik
2004-08-31 7:47 ` Brad Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41334058.4050902@wasp.net.au \
--to=brad@wasp.net.au \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.