From: Patrick McHardy <kaber@trash.net>
To: Luke Kenneth Casson Leighton <lkcl@lkcl.net>
Cc: Netfilter Development Mailinglist
<netfilter-devel@lists.netfilter.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6 NETFILTER] new netfilter module ipt_program.c
Date: Sat, 11 Sep 2004 14:51:24 +0200 [thread overview]
Message-ID: <4142F4CC.7080708@trash.net> (raw)
In-Reply-To: <20040911124106.GD24787@lkcl.net>
Luke Kenneth Casson Leighton wrote:
> decided to put this into a separate module. based on ipt_owner.c.
> does full program's pathname. like ipt_owner, only suitable for
> outgoing connections.
I agree that it would be useful to match the full path, but
the patch is broken, as are the owner match's pid-, sid- and
command-matching options. You can't grab files->file_lock
outside of process context. Besides, we want to consolidate
functionality, not add new matches that do basically the same
as existing ones.
Regards
Patrick
WARNING: multiple messages have this Message-ID (diff)
From: Patrick McHardy <kaber@trash.net>
To: Luke Kenneth Casson Leighton <lkcl@lkcl.net>
Cc: linux-kernel@vger.kernel.org,
Netfilter Development Mailinglist
<netfilter-devel@lists.netfilter.org>
Subject: Re: [PATCH 2.6 NETFILTER] new netfilter module ipt_program.c
Date: Sat, 11 Sep 2004 14:51:24 +0200 [thread overview]
Message-ID: <4142F4CC.7080708@trash.net> (raw)
In-Reply-To: <20040911124106.GD24787@lkcl.net>
Luke Kenneth Casson Leighton wrote:
> decided to put this into a separate module. based on ipt_owner.c.
> does full program's pathname. like ipt_owner, only suitable for
> outgoing connections.
I agree that it would be useful to match the full path, but
the patch is broken, as are the owner match's pid-, sid- and
command-matching options. You can't grab files->file_lock
outside of process context. Besides, we want to consolidate
functionality, not add new matches that do basically the same
as existing ones.
Regards
Patrick
next prev parent reply other threads:[~2004-09-11 12:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-11 12:41 [PATCH 2.6 NETFILTER] new netfilter module ipt_program.c Luke Kenneth Casson Leighton
2004-09-11 12:51 ` Patrick McHardy [this message]
2004-09-11 12:51 ` Patrick McHardy
2004-09-11 13:29 ` Luke Kenneth Casson Leighton
2004-09-11 13:34 ` Luke Kenneth Casson Leighton
2004-09-11 14:36 ` Patrick McHardy
2004-09-11 14:36 ` Patrick McHardy
2004-09-11 17:57 ` Luke Kenneth Casson Leighton
2004-09-11 14:49 ` Gianni Tedesco
2004-09-11 17:36 ` Luke Kenneth Casson Leighton
2004-09-13 11:50 ` Maciej Soltysiak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4142F4CC.7080708@trash.net \
--to=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lkcl@lkcl.net \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.