From: Patrick Gefre <pfg@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: tony.luck@intel.com, linux-kernel@vger.kernel.org,
linux-ia64@vger.kernel.org
Subject: Re: [PATCH] 2.6 SGI Altix I/O code reorganization
Date: Tue, 05 Oct 2004 18:26:28 +0000 [thread overview]
Message-ID: <4162E754.9020905@sgi.com> (raw)
In-Reply-To: <20041005164842.A19754@infradead.org>
Christoph Hellwig wrote:
> On Mon, Oct 04, 2004 at 04:57:06PM -0500, Pat Gefre wrote:
>
>>We have redone the I/O layer in the Altix code.
>>
>>We've broken the patch set down to 2 patches. One to remove the files,
>>the other to add in the new code. Most of the changes from the last
>>posting are in response to review comments.
>
>
> This looks pretty nice already, but a few small but important issues
> need sorting out.
> - the patch reformats various unrelated or only slightly related files.
> Please don't do that - in general the new style is better than the old
> one, but it doesn't belong in this patchA
Guess I don't understand this. Either the code base is Lindent'd or it isn't.
WARNING: multiple messages have this Message-ID (diff)
From: Patrick Gefre <pfg@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: tony.luck@intel.com, linux-kernel@vger.kernel.org,
linux-ia64@vger.kernel.org
Subject: Re: [PATCH] 2.6 SGI Altix I/O code reorganization
Date: Tue, 05 Oct 2004 13:26:28 -0500 [thread overview]
Message-ID: <4162E754.9020905@sgi.com> (raw)
In-Reply-To: <20041005164842.A19754@infradead.org>
Christoph Hellwig wrote:
> On Mon, Oct 04, 2004 at 04:57:06PM -0500, Pat Gefre wrote:
>
>>We have redone the I/O layer in the Altix code.
>>
>>We've broken the patch set down to 2 patches. One to remove the files,
>>the other to add in the new code. Most of the changes from the last
>>posting are in response to review comments.
>
>
> This looks pretty nice already, but a few small but important issues
> need sorting out.
> - the patch reformats various unrelated or only slightly related files.
> Please don't do that - in general the new style is better than the old
> one, but it doesn't belong in this patchA
Guess I don't understand this. Either the code base is Lindent'd or it isn't.
next prev parent reply other threads:[~2004-10-05 18:26 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-04 21:57 [PATCH] 2.6 SGI Altix I/O code reorganization Pat Gefre
2004-10-04 21:57 ` Pat Gefre
2004-10-05 5:13 ` Luck, Tony
2004-10-05 5:13 ` Luck, Tony
2004-10-05 15:43 ` Jesse Barnes
2004-10-05 15:43 ` Jesse Barnes
2004-10-05 16:22 ` Grant Grundler
2004-10-05 16:22 ` Grant Grundler
2004-10-05 17:45 ` Matthew Wilcox
2004-10-05 17:45 ` Matthew Wilcox
2004-10-05 19:00 ` Colin Ngam
2004-10-05 19:00 ` Colin Ngam
2004-10-05 19:10 ` Grant Grundler
2004-10-05 19:10 ` Grant Grundler
2004-10-05 19:15 ` Matthew Wilcox
2004-10-05 19:15 ` Matthew Wilcox
2004-10-05 18:20 ` Patrick Gefre
2004-10-05 18:20 ` Patrick Gefre
2004-10-05 18:34 ` Jesse Barnes
2004-10-05 18:34 ` Jesse Barnes
2004-10-05 15:48 ` Christoph Hellwig
2004-10-05 15:48 ` Christoph Hellwig
2004-10-05 18:26 ` Patrick Gefre [this message]
2004-10-05 18:26 ` Patrick Gefre
2004-10-05 23:30 ` Patrick Gefre
2004-10-05 23:30 ` Patrick Gefre
2004-10-05 15:50 ` Christoph Hellwig
2004-10-05 15:50 ` Christoph Hellwig
2004-10-05 19:16 ` Luck, Tony
2004-10-05 19:16 ` Luck, Tony
2004-10-05 19:35 ` Patrick Gefre
2004-10-05 19:35 ` Patrick Gefre
2004-10-05 20:34 ` Luck, Tony
2004-10-05 20:34 ` Luck, Tony
2004-10-06 15:32 ` Patrick Gefre
2004-10-06 15:32 ` Patrick Gefre
2004-10-06 18:57 ` Grant Grundler
2004-10-06 18:57 ` Grant Grundler
2004-10-06 19:09 ` Colin Ngam
2004-10-06 19:09 ` Colin Ngam
2004-10-06 19:54 ` Grant Grundler
2004-10-06 19:54 ` Grant Grundler
2004-10-06 19:54 ` Colin Ngam
2004-10-06 19:54 ` Colin Ngam
2004-10-06 20:10 ` Patrick Gefre
2004-10-06 20:10 ` Patrick Gefre
2004-10-06 20:44 ` Jesse Barnes
2004-10-06 20:44 ` Jesse Barnes
2004-10-07 15:02 ` Patrick Gefre
2004-10-07 15:02 ` Patrick Gefre
2004-10-07 16:52 ` Jesse Barnes
2004-10-07 16:52 ` Jesse Barnes
2004-10-06 20:27 ` Jesse Barnes
2004-10-06 20:27 ` Jesse Barnes
2004-10-06 20:21 ` Colin Ngam
2004-10-06 20:21 ` Colin Ngam
2004-10-06 20:33 ` Matthew Wilcox
2004-10-06 20:33 ` Matthew Wilcox
2004-10-06 20:48 ` Grant Grundler
2004-10-06 20:48 ` Grant Grundler
2004-10-06 21:05 ` Matthew Wilcox
2004-10-06 21:05 ` Matthew Wilcox
2004-10-06 20:55 ` Colin Ngam
2004-10-06 20:55 ` Colin Ngam
2004-10-08 15:16 ` Colin Ngam
2004-10-08 15:16 ` Colin Ngam
2004-10-08 16:37 ` Jesse Barnes
2004-10-08 16:37 ` Jesse Barnes
2004-10-09 22:20 ` Grant Grundler
2004-10-09 22:20 ` Grant Grundler
[not found] ` <4169A508.84FB19C7@sgi.com>
2004-10-11 14:03 ` Patrick Gefre
2004-10-11 14:03 ` Patrick Gefre
2004-10-08 22:37 ` Colin Ngam
2004-10-08 22:37 ` Colin Ngam
2004-10-07 17:06 ` Luck, Tony
2004-10-07 17:06 ` Luck, Tony
2004-10-07 17:22 ` Jesse Barnes
2004-10-07 17:22 ` Jesse Barnes
2004-10-07 18:59 ` Jes Sorensen
2004-10-07 18:59 ` Jes Sorensen
2004-10-11 20:49 ` Luck, Tony
2004-10-11 20:49 ` Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4162E754.9020905@sgi.com \
--to=pfg@sgi.com \
--cc=hch@infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.