* Surprising Code In sound/core/pcm_native.c In Recent Git Tree
@ 2008-07-18 20:37 Soumyadip Das Mahapatra
2008-07-18 21:02 ` Stefan Richter
0 siblings, 1 reply; 2+ messages in thread
From: Soumyadip Das Mahapatra @ 2008-07-18 20:37 UTC (permalink / raw)
To: linux-kernel
Hello everyone!
When i was reading the code in sound/core/pcm_native.c in
recent git tree, i got stuck in line no 3258. It is something
like this
snd_assert(substream != NULL, goto out);
That (goto statement) surprised me for a while unless i came to
know snd_assert() is a macro (as expected!). Previous version
too had a return statement in it.
The point is that can we have a nicer code? Because this type
of code is sometimes __CONFUSING__.
Thanks :-)
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: Surprising Code In sound/core/pcm_native.c In Recent Git Tree
2008-07-18 20:37 Surprising Code In sound/core/pcm_native.c In Recent Git Tree Soumyadip Das Mahapatra
@ 2008-07-18 21:02 ` Stefan Richter
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Richter @ 2008-07-18 21:02 UTC (permalink / raw)
To: Soumyadip Das Mahapatra; +Cc: linux-kernel
Soumyadip Das Mahapatra wrote:
> When i was reading the code in sound/core/pcm_native.c in
> recent git tree, i got stuck in line no 3258. It is something
> like this
> snd_assert(substream != NULL, goto out);
>
> That (goto statement) surprised me for a while unless i came to
> know snd_assert() is a macro (as expected!). Previous version
> too had a return statement in it.
>
> The point is that can we have a nicer code? Because this type
> of code is sometimes __CONFUSING__.
Curious. The "goto out", "return -EIO" and friends are not compiled in
if CONFIG_SND_DEBUG is not set.
Why would anybody want a debug macro to exit from functions?
BTW, grep tells me there are 829 occurrences of snd_assert in linux 2.6.26.
--
Stefan Richter
-=====-==--- -=== =--=-
http://arcgraph.de/sr/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-07-18 21:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-18 20:37 Surprising Code In sound/core/pcm_native.c In Recent Git Tree Soumyadip Das Mahapatra
2008-07-18 21:02 ` Stefan Richter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.