From: Jeff Garzik <jgarzik@pobox.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "Martin J. Bligh" <mbligh@aracnet.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
"Randy.Dunlap" <rddunlap@osdl.org>,
William Lee Irwin III <wli@holomorphy.com>,
Jens Axboe <axboe@suse.de>
Subject: Re: news about IDE PIO HIGHMEM bug
Date: Wed, 27 Oct 2004 14:33:45 -0400 [thread overview]
Message-ID: <417FEA09.6080502@pobox.com> (raw)
In-Reply-To: <20041027180816.GA32436@infradead.org>
Christoph Hellwig wrote:
>>To repeat what I said in IRC ... ;-)
>>
>>Actually, you could check this with the pfns being the same when >> MAX_ORDER-1.
>>We should be aligned on a MAX_ORDER boundary, I think.
>>
>>However, pfn_to_page(page_to_pfn(page) + 1) might be safer. If rather slower.
>
>
> I think this is the wrong level of interface exposed. Just add two hepler
> kmap_atomic_sg/kunmap_atomic_sg that gurantee to map/unmap a sg list entry,
> even if it's bigger than a page.
Why bother mapping anything larger than a page, when none of the users
need it?
Jeff
P.S. In your scheme you would need four helpers; you forgot kmap_sg()
and kunmap_sg().
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Garzik <jgarzik@pobox.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "Martin J. Bligh" <mbligh@aracnet.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
"Randy.Dunlap" <rddunlap@osdl.org>,
William Lee Irwin III <wli@holomorphy.com>,
Jens Axboe <axboe@suse.de>
Subject: Re: news about IDE PIO HIGHMEM bug
Date: Wed, 27 Oct 2004 14:33:45 -0400 [thread overview]
Message-ID: <417FEA09.6080502@pobox.com> (raw)
In-Reply-To: <20041027180816.GA32436@infradead.org>
Christoph Hellwig wrote:
>>To repeat what I said in IRC ... ;-)
>>
>>Actually, you could check this with the pfns being the same when >> MAX_ORDER-1.
>>We should be aligned on a MAX_ORDER boundary, I think.
>>
>>However, pfn_to_page(page_to_pfn(page) + 1) might be safer. If rather slower.
>
>
> I think this is the wrong level of interface exposed. Just add two hepler
> kmap_atomic_sg/kunmap_atomic_sg that gurantee to map/unmap a sg list entry,
> even if it's bigger than a page.
Why bother mapping anything larger than a page, when none of the users
need it?
Jeff
P.S. In your scheme you would need four helpers; you forgot kmap_sg()
and kunmap_sg().
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2004-10-27 18:45 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <58cb370e041027074676750027@mail.gmail.com>
2004-10-27 15:14 ` news about IDE PIO HIGHMEM bug (was: Re: 2.6.9-mm1) Jeff Garzik
2004-10-27 15:14 ` Jeff Garzik
2004-10-27 15:52 ` Martin J. Bligh
2004-10-27 15:52 ` Martin J. Bligh
2004-10-27 15:59 ` Jeff Garzik
2004-10-27 15:59 ` Jeff Garzik
2004-10-27 17:36 ` Martin J. Bligh
2004-10-27 17:36 ` Martin J. Bligh
2004-10-27 16:01 ` Martin J. Bligh
2004-10-27 16:01 ` Martin J. Bligh
2004-10-27 16:35 ` [PATCH] " Jeff Garzik
2004-10-27 21:29 ` Andrew Morton
2004-10-27 21:29 ` Andrew Morton
2004-10-27 21:31 ` Jeff Garzik
2004-10-27 21:31 ` Jeff Garzik
2004-10-27 21:34 ` William Lee Irwin III
2004-10-27 21:34 ` William Lee Irwin III
2004-10-27 18:08 ` Christoph Hellwig
2004-10-27 18:08 ` Christoph Hellwig
2004-10-27 18:33 ` Jeff Garzik [this message]
2004-10-27 18:33 ` news about IDE PIO HIGHMEM bug Jeff Garzik
2004-10-27 18:48 ` William Lee Irwin III
2004-10-27 18:48 ` William Lee Irwin III
2004-10-28 0:18 ` William Lee Irwin III
2004-10-28 0:18 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=417FEA09.6080502@pobox.com \
--to=jgarzik@pobox.com \
--cc=axboe@suse.de \
--cc=bzolnier@gmail.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mbligh@aracnet.com \
--cc=rddunlap@osdl.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.