* [PATCH] sr module_param conversion
@ 2004-11-13 23:40 Jan Dittmer
2004-11-21 11:13 ` Rolf Eike Beer
0 siblings, 1 reply; 2+ messages in thread
From: Jan Dittmer @ 2004-11-13 23:40 UTC (permalink / raw)
To: Linux kernel
module_param conversion for SCSI cdrom driver
Signed-off-by: Jan Dittmer <jdittmer@ppp0.net>
diff -Nru a/drivers/scsi/sr.c b/drivers/scsi/sr.c
--- a/drivers/scsi/sr.c 2004-11-14 00:36:56 +01:00
+++ b/drivers/scsi/sr.c 2004-11-14 00:36:56 +01:00
@@ -59,9 +59,6 @@
#include "sr.h"
-MODULE_PARM(xa_test, "i"); /* see sr_ioctl.c */
-
-
#define SR_DISKS 256
#define MAX_RETRIES 3
diff -Nru a/drivers/scsi/sr_ioctl.c b/drivers/scsi/sr_ioctl.c
--- a/drivers/scsi/sr_ioctl.c 2004-11-14 00:36:56 +01:00
+++ b/drivers/scsi/sr_ioctl.c 2004-11-14 00:36:56 +01:00
@@ -29,6 +29,9 @@
* It is off by default and can be turned on with this module parameter */
static int xa_test = 0;
+module_param(xa_test, int, S_IRUGO | S_IWUSR);
+
+
#define IOCTL_RETRIES 3
/* ATAPI drives don't have a SCMD_PLAYAUDIO_TI command. When these drives
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] sr module_param conversion
2004-11-13 23:40 [PATCH] sr module_param conversion Jan Dittmer
@ 2004-11-21 11:13 ` Rolf Eike Beer
0 siblings, 0 replies; 2+ messages in thread
From: Rolf Eike Beer @ 2004-11-21 11:13 UTC (permalink / raw)
To: Jan Dittmer; +Cc: Linux Kernel Mailing List
Jan Dittmer wrote:
> module_param conversion for SCSI cdrom driver
>
> Signed-off-by: Jan Dittmer <jdittmer@ppp0.net>
> diff -Nru a/drivers/scsi/sr_ioctl.c b/drivers/scsi/sr_ioctl.c
> --- a/drivers/scsi/sr_ioctl.c 2004-11-14 00:36:56 +01:00
> +++ b/drivers/scsi/sr_ioctl.c 2004-11-14 00:36:56 +01:00
> @@ -29,6 +29,9 @@
> * It is off by default and can be turned on with this module parameter */
> static int xa_test = 0;
>
> +module_param(xa_test, int, S_IRUGO | S_IWUSR);
> +
> +
I think it should be "bool" instead of "int". And one newline should be
enough for everyone.
You should CC linux-scsi@vger.kernel.org and James Bottomley
<James.Bottomley@steeleye.com> to get this applied.
Eike
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-11-21 11:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-11-13 23:40 [PATCH] sr module_param conversion Jan Dittmer
2004-11-21 11:13 ` Rolf Eike Beer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.