[KJ] [PATCH] drivers/ide/pci/cs5520.c fix return code value

[KJ] [PATCH] drivers/ide/pci/cs5520.c fix return code value

[Amit Gud]

[-- Attachment #1: Type: text/plain, Size: 659 bytes --]

Description: The patch follows from the suggestions by AC and Felipe W
Damasio for fixing the return codes from IDE drivers.

Do consider applying.


Signed-off-by: Amit Gud <gud@eth.net>

--- vanilla-2.6.10/drivers/ide/pci/cs5520.c     2005-01-19
11:19:28.000000000 +0530
+++ linux-2.6.9/drivers/ide/pci/cs5520.c        2005-01-19
14:23:50.000000000 +0530
@@ -224,7 +224,7 @@
        if(pci_enable_device_bars(dev, 1<<2))
        {
                printk(KERN_WARNING "%s: Unable to enable 55x0.\n",
d->name);
-               return 1;
+               return -EAGAIN;
        }
        pci_set_master(dev);
        if (pci_set_dma_mask(dev, 0xFFFFFFFF)) {



[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] drivers/ide/pci/cs5520.c fix return code value

[Domen Puncer]

[-- Attachment #1: Type: text/plain, Size: 1025 bytes --]

On 19/01/05 14:44 +0530, Amit Gud wrote:
> Description: The patch follows from the suggestions by AC and Felipe W
> Damasio for fixing the return codes from IDE drivers.
> 
> Do consider applying.
> 
> 
> Signed-off-by: Amit Gud <gud@eth.net>
> 
> --- vanilla-2.6.10/drivers/ide/pci/cs5520.c     2005-01-19
> 11:19:28.000000000 +0530

Line wrap. (Turn this off in your mailer)

> +++ linux-2.6.9/drivers/ide/pci/cs5520.c        2005-01-19
> 14:23:50.000000000 +0530
> @@ -224,7 +224,7 @@
>         if(pci_enable_device_bars(dev, 1<<2))
	
Whitespace damage.
(Don't copy/paste. Try mailing patch to yourself first, and see if it
 applies)

>         {
>                 printk(KERN_WARNING "%s: Unable to enable 55x0.\n",
> d->name);
> -               return 1;
> +               return -EAGAIN;

-EAGAIN? -ENODEV, like it's a few lines below looks more apropriate.


>         }
>         pci_set_master(dev);
>         if (pci_set_dma_mask(dev, 0xFFFFFFFF)) {
> 
> 

Wrt. generic.c patch... is seems already merged.


	Domen

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] drivers/ide/pci/cs5520.c fix return code value

[Randy.Dunlap]

Domen Puncer wrote:
> On 19/01/05 14:44 +0530, Amit Gud wrote:
> 
>>Description: The patch follows from the suggestions by AC and Felipe W
>>Damasio for fixing the return codes from IDE drivers.
>>
>>+++ linux-2.6.9/drivers/ide/pci/cs5520.c        2005-01-19
>>14:23:50.000000000 +0530
>>@@ -224,7 +224,7 @@
>>        if(pci_enable_device_bars(dev, 1<<2))

also, please use diff -up as indicated in
Documentation/SubmittingPatches .

-- 
~Randy
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors